omap3: beagle: fix compile error
PATCH 1/1 omap3: beagle: fix compile error
The configuration for beagle undefs CONFIG_CMD_NET. This leads to following error:
lib_arm/libarm.a(board.o): In function `start_armboot':/home/premi/u-boot/lib_arm/board.c:360: undefined reference
to `getenv_IPaddr'
make: *** [u-boot] Error 1
This patch fixes the error by including offending line in appropriate ifdef.
--- lib_arm/board.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
lib_arm/board.c +2 -1
@@ -357,8 +357,9 @@ void start_armboot (void)#endif /* IP Address */ +#ifdef CONFIG_CMD_NET gd->bd->bi_ip_addr =getenv_IPaddr ("ipaddr" ); - +#endif stdio_init ();/* get the devices list going. */ jumptable_init ();
Signature · 1 line
1.6.2.2
PATCH 1/1 omap3: beagle: fix compile error
Quoted 8 lines · Sanjeev Premi
The configuration for beagle undefs
CONFIG_CMD_NET. This leads to following error:lib_arm/libarm.a(board.o): In function `start_armboot':
/home/premi/u-boot/lib_arm/board.c:360: undefined reference
to `getenv_IPaddr'
make: *** [u-boot] Error 1
Quoted 4 lines
This patch fixes the error by including offending line in appropriate ifdef.
Signed-off-by Sanjeev Premi<[email protected]>
Tom: Could we get this applied and sent to Wolfgang asap? Mainline Beagle, Pandora, Zoom1and Zoom2 are broken without this.
Best regards
Dirk
Quoted 19 lines
--- lib_arm/board.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)lib_arm/board.c +2
-1@@ -357,8 +357,9 @@ void start_armboot (void)#endif /* IP Address */ +#ifdef CONFIG_CMD_NET gd->bd->bi_ip_addr =getenv_IPaddr ("ipaddr" ); - +#endif stdio_init ();/* get the devices list going. */ jumptable_init ();
PATCH 1/1 omap3: beagle: fix compile error
Dear Dirk Behme,
Quoted 12 lines · In message <[email protected]> you wrote:
Quoted 11 lines · Sanjeev Premi
The configuration for beagle undefs
CONFIG_CMD_NET. This leads to following error:lib_arm/libarm.a(board.o): In function `start_armboot':
/home/premi/u-boot/lib_arm/board.c:360: undefined reference
to `getenv_IPaddr'
make: *** [u-boot] Error 1This patch fixes the error by including offending line in appropriate ifdef.
Quoted 6 lines
Quoted 1 line
Signed-off-by Sanjeev Premi<[email protected]>Acked-by Dirk Behme <[email protected]>Tom: Could we get this applied and sent to Wolfgang asap? Mainline Beagle, Pandora, Zoom1and Zoom2 are broken without this.
Sorry, but I disagree.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "UNIX was not designed to stop you from doing stupid things, because that would also stop you from doing clever things." - Doug Gwyn
PATCH 1/1 omap3: beagle: fix compile error
Dear Wolfgang Denk,
Quoted 15 lines · Wolfgang Denk
Dear Dirk Behme,
Quoted 12 lines · In message<[email protected]> you wrote:
Quoted 11 lines · Sanjeev Premi
The configuration for beagle undefs
CONFIG_CMD_NET. This leads to following error:lib_arm/libarm.a(board.o): In function `start_armboot':
/home/premi/u-boot/lib_arm/board.c:360: undefined reference
to `getenv_IPaddr'
make: *** [u-boot] Error 1This patch fixes the error by including offending line in appropriate ifdef.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Sanjeev Premi<[email protected]>Acked-by Dirk Behme<[email protected]>Tom: Could we get this applied and sent to Wolfgang asap? Mainline Beagle, Pandora, Zoom1and Zoom2 are broken without this.
Sorry, but I disagree.
I hope you only disagree on the fix Sanjeev (and others, see below) proposed? And not that it should be fixed asap?
Please note that other architectures (not only boards) seem to have the same issue
http://lists.denx.de/pipermail/u-boot/2009-December/065810.html
Regarding your proposal to implement getenv_IPaddr() for all architectures
independent of CONFIG_NET
http://lists.denx.de/pipermail/u-boot/2009-December/065833.html
do you have a proposal where (in which file) this should be done? Sounds like it has to be a global function available for all architectures?
Best regards
Dirk
PATCH 1/1 omap3: beagle: fix compile error
Dear Dirk Behme,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 3 lines
Tom: Could we get this applied and sent to Wolfgang asap? Mainline Beagle, Pandora, Zoom1and Zoom2 are broken without this.
Sorry, but I disagree.
I hope you only disagree on the fix Sanjeev (and others, see below) proposed? And not that it should be fixed asap?
I agree that it should be fixed ASAP. But th fix is not removing this useful functuionality, but instead making this function not depend on CONFIG_NET.
Quoted 2 lines
Please note that other architectures (not only boards) seem to have the same issue
Yes, I know.
Quoted 1 line
do you have a proposal where (in which file) this should be done?
Maybe a new file lib_generic/net_utils.c ?
Quoted 2 lines
Sounds like it has to be a global function available for all architectures?
Correct.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de God runs electromagnetics by wave theory on Monday, Wednesday, and Friday, and the Devil runs them by quantum theory on Tuesday, Thurs- day, and Saturday. -- William Bragg
PATCH 1/1 omap3: beagle: fix compile error
In reply to Sanjeev PremiDear Sanjeev Premi,
Quoted 21 lines · In message <[email protected]> you wrote:
The configuration for beagle undefs
CONFIG_CMD_NET. This leads to following error:lib_arm/libarm.a(board.o): In function `start_armboot':
/home/premi/u-boot/lib_arm/board.c:360: undefined reference
to `getenv_IPaddr'
make: *** [u-boot] Error 1This patch fixes the error by including offending line in appropriate ifdef.
Signed-off-by Sanjeev Premi <[email protected]>--- lib_arm/board.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)lib_arm/board.c +0
-0
lib_arm/board.c void start_armboot (void) · line 363
Quoted 8 lines
lib_arm/board.c +2
-1@@ -357,8 +357,9 @@ void start_armboot (void)#endif /* IP Address */ +#ifdef CONFIG_CMD_NET gd->bd->bi_ip_addr =getenv_IPaddr ("ipaddr" ); - +#endif stdio_init ();/* get the devices list going. */
I don't think this is the right way to fix the problem.
This is global ARM code, and there may well be ARM boards out there that do not have network support in U-Boot, but they do so in Linux, which makes it desirable to be able to port network configuration (like the IP address) to the Linux kernel.
We should not make the passing of the IP configuration to Linux dependent on U-Boot features / settings.
Why cannot you simply implement getenv_IPaddr() ?
I think the right way to fix this issue is to make getenv_IPaddr() always available, independent of CONFIG_NET.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de panic: can't find /
Premi
PATCH 1/1 omap3: beagle: fix compile error
Quoted 44 lines
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Saturday, December 26, 2009 5:04 AM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] omap3: beagle: fix compile errorDear Sanjeev Premi,
Quoted 21 lines · In message <[email protected]> you wrote:
The configuration for beagle undefs
CONFIG_CMD_NET. This leads to following error:lib_arm/libarm.a(board.o): In function `start_armboot':
/home/premi/u-boot/lib_arm/board.c:360: undefined reference
to `getenv_IPaddr'
make: *** [u-boot] Error 1This patch fixes the error by including offending line in appropriate ifdef.
Signed-off-by Sanjeev Premi <[email protected]>--- lib_arm/board.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)lib_arm/board.c +0
-0lib_arm/board.c void start_armboot (void) · line 363
Quoted 8 lines
lib_arm/board.c +2
-1@@ -357,8 +357,9 @@ void start_armboot (void)#endif /* IP Address */ +#ifdef CONFIG_CMD_NET gd->bd->bi_ip_addr =getenv_IPaddr ("ipaddr" ); - +#endif stdio_init ();/* get the devices list going. */ I don't think this is the right way to fix the problem.
Quoted 4 lines
This is global ARM code, and there may well be ARM boards out there that do not have network support in U-Boot, but they do so in Linux, which makes it desirable to be able to port network configuration (like the IP address) to the Linux kernel.
[sp] I may not have great visibility into other ARM boards, but, aren't the Linux implementations free to init and configure the network on their own? Why would/should they depend/or not upon the u-boot setting an IP address?
Quoted 5 lines
We should not make the passing of the IP configuration to Linux dependent on U-Boot features / settings.
Why cannot you simply implement
getenv_IPaddr()?
[sp] The Beagleboard does not have any ethernet port. I believed that CONFIG_CMD_NET was one way of ensuring that the fix could address all boards which do not have ethernet connection. And, hence, would not be setting CONFIG_CMD_NET.
In any case, for beagle I can implement this function to return "0:0:0:0". But would that be useful?
Best regards,
Sanjeev
Quoted 15 lines
I think the right way to fix this issue is to make
getenv_IPaddr()always available, independent ofCONFIG_NET.Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de panic: can't find /
PATCH 1/1 omap3: beagle: fix compile error
Dear Sanjeev,
Quoted 10 lines · In message <[email protected]> you…
Quoted 5 lines
This is global ARM code, and there may well be ARM boards out there that do not have network support in U-Boot, but they do so in Linux, which makes it desirable to be able to port network configuration (like the IP address) to the Linux kernel.
[sp] I may not have great visibility into other ARM boards, but, aren't the Linux implementations free to init and configure the network on their own? Why would/should they depend/or not upon the u-boot setting an IP address?
It is a standard feature and established policy to have network configuration done only once, in a central place. for example, even when using DHCP or similar, it makes not much sense to run DHCP in U-boot for the kernel image download, and then again in Linux to determine the IP address settings. We do this once, in U-Boot, and then pass the information on to the Linux kernel. Similar for static IP settings.
In this case the board has no Ethernet support in U-Boot, but that does not mean that we should assume that no IP settings might be needed in Linux.
And it makes little sense to me to deviate from the "standard" behavior without real need.
Here the cure is so simple (just enable getenv_IPaddr() always, independent of CONFIG_NET settings) that it's not even worth much of a discussion.
Quoted 6 lines
Quoted 4 lines
We should not make the passing of the IP configuration to Linux dependent on U-Boot features / settings.
Why cannot you simply implement
getenv_IPaddr()?[sp] The Beagleboard does not have any ethernet port. I believed that
Yes, but you can still use networking in Linux, for example over USB.
Quoted 2 lines
In any case, for beagle I can implement this function to return "0:0:0:0". But would that be useful?
No, it would not, as it is supposed to return the meaningful value.
Also, I definitely do NOT want to see any board specific implemen- tation for a common, global function. That would be even worse.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "There is no distinctly American criminal class except Congress." - Mark Twain