Skip to contentSkip to conversation

netfilter: Fix typo in nf_queue.c

PATCH In review Holger Freyther 2 participants 3 messages Dec 26, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter: Fix typo in nf_queue.c

Hi all,

LaF0rge pointed me to libnetfilter_queue earlier this week and today I started to read the kernel code of it. I stumbled across a small typo in the code. I'm sorry that I take your attention away from a real issue for this but maybe it is still worth applying.

regards
holger

From e2046abf4c9d09dff4e2e45135b1feac4086f2b7 Mon Sep 17 00:00:00 2001
From: Holger Hans Peter Freyther <[email protected]>
Date: Sat, 26 Dec 2009 04:10:41 +0100
Subject: [PATCH] netfilter: Fix typo in nf_queue.c

---
 net/netfilter/nf_queue.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/netfilter/nf_queue.c +1 -1
index 3a6fd77..b3f76f9 100644
@@ -239,7 +239,7 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
 
 	nf_queue_entry_release_refs(entry);
 
-	/* Continue traversal iff userspace said ok... */
+	/* Continue traversal if userspace said ok... */
 	if (verdict == NF_REPEAT) {
 		elem = elem->prev;
 		verdict = NF_ACCEPT;
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 6 lines · Holger Freyther

Hi all,

LaF0rge pointed me to libnetfilter_queue earlier this week and today I started to read the kernel code of it. I stumbled across a small typo in the code. I'm sorry that I take your attention away from a real issue for this but maybe it is still worth applying.

"iff" is 'defined' in hacker dictionaries as "if and only if".

#2 lore raw
Quoted 4 lines · On Saturday 26 December 2009 12:22:46 Jan Engelhardt wrote:

On Saturday 2009-12-26 04:22, Holger Freyther wrote:

"iff" is 'defined' in hacker dictionaries as "if and only if".

haha, and I googled/yahooed before posting the patch...

thanks a lot.

z.