Skip to contentSkip to conversation

macrofying

PATCH In review Carles Pina i Estany 1 participant 2 messages Dec 28, 2009 – Dec 30, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 macrofying

Hi,

Attached a patch that macrofies some values. I don't see any reason that was not macrofied.

Signature · 2 lines
Carles Pina i Estany
	http://pinux.info

=== modified file 'ChangeLog'

ChangeLog +6 -0
@@ -1,3 +1,9 @@
+2009-12-28  Carles Pina i Estany  <[email protected]>
+
+	* loader/i386/efi/linux.c (grub_cmd_linux): Use GRUB_TERM_WIDTH and
+	GRUB_TERM_HEIGHT macros.
+	* loader/i386/ieee1275/linux.c (grub_linux_boot): Likewise.
+
 2009-12-27  Vladimir Serbinenko  <[email protected]>
 
 	* normal/menu_text.c (grub_print_message_indented): Prevent

=== modified file 'loader/i386/efi/linux.c'

i386/efi/linux.c +2 -2
@@ -697,9 +697,9 @@ grub_cmd_linux (grub_command_t cmd __att
   params->video_cursor_y = grub_getxy () & 0xff;
   params->video_page = 0; /* ??? */
   params->video_mode = grub_efi_system_table->con_out->mode->mode;
-  params->video_width = (grub_getwh () >> 8);
+  params->video_width = GRUB_TERM_WIDTH;
   params->video_ega_bx = 0;
-  params->video_height = (grub_getwh () & 0xff);
+  params->video_height = GRUB_TERM_HEIGHT;
   params->have_vga = 0;
   params->font_size = 16; /* XXX */
 

=== modified file 'loader/i386/ieee1275/linux.c'

i386/ieee1275/linux.c +2 -2
@@ -109,8 +109,8 @@ grub_linux_boot (void)
   params->cl_magic = GRUB_LINUX_CL_MAGIC;
   params->cl_offset = GRUB_OFW_LINUX_CL_OFFSET;
 
-  params->video_width = (grub_getwh () >> 8);
-  params->video_height = (grub_getwh () & 0xff);
+  params->video_width = GRUB_TERM_WIDTH;
+  params->video_height = GRUB_TERM_HEIGHT;
   params->font_size = 16;
 
   params->ofw_signature = GRUB_LINUX_OFW_SIGNATURE;
#1 lore raw

Hi,

Quoted 2 lines · Carles Pina i Estany

Attached a patch that macrofies some values. I don't see any reason that was not macrofied.

I forgot to mention: multiterm branch improved it in a different way.

Signature · 2 lines
Carles Pina i Estany
	http://pinux.info