Skip to contentSkip to conversation

erroneous CONFIG variable in infiniband code?

DISCUSSION Robert P. J. Day 2 participants 2 messages Dec 28, 2009 InfiniBand

lore
Share & tools
lore
#0 lore raw

drivers/infiniband/core/cma.c:2086:#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)

notice the difference in case there, "IPv6" versus "IPV6". someone
want to check that out?

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 5 lines · Robert P. J. Day

drivers/infiniband/core/cma.c:2086:#if defined(CONFIG_IPv6) || defined(CONFIG_IPV6_MODULE)

notice the difference in case there, "IPv6" versus "IPV6". someone
want to check that out?

Yup, looks like a bug introduced in commit d14714df61681cfecf945a58436edf197327e87f

Author: Sean Hefty <[email protected]>
Date:   Thu Nov 19 16:46:25 2009 -0800

IB/addr: Fix IPv6 routing lookup

Include link scope as part of address resolution. Combine local and remote address resolution into a single, simpler code path. Fix error checking in the IPv6 routing lookups.

Based on work from:
David Wilder <dwilder-r/[email protected]> Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

[ Fix up cma_check_linklocal() for !IPV6 case. - Roland ]

Before the change, they were
-#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)

Good catch. Submit a patch and Cc lkml.

Thanks,
Jon

Quoted 9 lines

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Quoted 7 lines
Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html