MUSB: CPPI 4.1 DMA driver (take 4)
A message that is not in the archive (sent off-list or not yet received): [email protected]
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Quoted 19 lines
Hello.
Quoted 6 lines · Russell King - ARM Linux
Quoted 2 lines
Quoted 1 line
Is there any updated patch on cppi4.1 core also?
Is there _any_ cppi4.1 core patch anywhere?? Not according to google.
Russell,
Here is the latest ersion of cppi4.1 core.
http://patchwork.kernel.org/patch/46698/Quoted 7 lines
[...]
Quoted 2 lines
If it's a USB DMA device (from the patches I can find, that seems to be the case) then why can't it live in
drivers/usbordrivers/dma?CPPI4.1 DMA engine can be used either by USB or by Ethernet interface though currently only USB is using it but in future even Ethernet devices may use it.
drivers/dmadoes seem to be the right place for this.
Quoted 9 lines
??? Russell, it makes me wonder why
drivers/dma/seemed the right place to you, just because of the name? :-)
??? After spending some time on studying the infrastructure there I came to conclusion that this is not the right place because all the controllers supported there have features like memory-to-memory transfers or even RAID function offloading -- which CPPI 4.1 totally lacks (it's there purely to serve the peripherals).
??? Addingdrivers/dma/people to this discussion in hopes they can correct me (or support me :-)...
As this discussion is taking time which is affecting the further development and bug fixes on CPPI4.1.
So can we move CPPI4.1 files to drivers/usb/musb for time being and submit a replacement patch whenever we all agree on the location of CPPI4.1 related files.
-Ajay
Quoted 2 lines
WBR, Sergei
--
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Hi,
Quoted 6 lines · Ajay Kumar
As this discussion is taking time which is affecting the further development and bug fixes on CPPI4.1.
So can we move CPPI4.1 files to
drivers/usb/musbfor time being and submit a replacement patch whenever we all agree on the location of CPPI4.1 related files.
problem is that once it's applied, no-one seems to care anymore. And it'll be there for good. Better is to decide what really is the correct place for this otherwise it'll be like tusb6010_omap.c
Signature · 1 line
balbi
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Felipe,
We have been on this front months together now!!! Ideally the place holder would be a place independant of platforms as this piece of code is more of a platform independant library relating to TI CPPI DMA operations. This would be used during initialization and confiuration of CPPI4.x based peripherals. Though today USB is the only peripheral that falls in that catagory ideally other like TI EMAC could fall in the same space.
Having said that I also see that there seems to be no roadmap/plan for any other peripheral other than USB to use CPPI4.x in the near future. TI EMAC seems to continue use CPPI3.x.
This was the reason I had recommended earlier to locate this generic CPPI 4.x functionality within MUSB. This definitely helps in having a functional peripheral in the near (and most probably long) term.
I think it is prudent to locate this functionality in the musb directory for now. In future if need arises we can relook at this later (I am sure this in all probabilities would not be required).
In either way I would really appreiciate if we can come to a conclusion at the earliest. Appreciate everybody's feedback and direction.
regards
swami
________________________________________
From: Felipe Balbi [felipe.balbi at nokia.com]
Sent: Tuesday, December 29, 2009 6:24 PM
To: Gupta, Ajay Kumar
Cc: linux-usb at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Sergei Shtylyov; Balbi Felipe (Nokia-D/Helsinki); Subbrathnam, Swaminathan
Subject: Re: [PATCH RFC 1/2] MUSB: CPPI 4.1 DMA driver (take 4)
Hi,
Quoted 6 lines · Ajay Kumar
As this discussion is taking time which is affecting the further development and bug fixes on CPPI4.1.
So can we move CPPI4.1 files to
drivers/usb/musbfor time being and submit a replacement patch whenever we all agree on the location of CPPI4.1 related files.
problem is that once it's applied, no-one seems to care anymore. And it'll be there for good. Better is to decide what really is the correct place for this otherwise it'll be like tusb6010_omap.c
--
balbi
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Hi,
please wrap your mails at 80 characters
Quoted 16 lines · Swaminathan
We have been on this front months together now!!! Ideally the place holder would be a place independant of platforms as this piece of code is more of a platform independant library relating to TI CPPI DMA operations. This would be used during initialization and confiuration of CPPI4.x based peripherals. Though today USB is the only peripheral that falls in that catagory ideally other like TI EMAC could fall in the same space.
Having said that I also see that there seems to be no roadmap/plan for any other peripheral other than USB to use CPPI4.x in the near future. TI EMAC seems to continue use CPPI3.x.
This was the reason I had recommended earlier to locate this generic CPPI 4.x functionality within MUSB. This definitely helps in having a functional peripheral in the near (and most probably long) term.
Quoted 7 lines
I think it is prudent to locate this functionality in the musb directory for now. In future if need arises we can relook at this later (I am sure this in all probabilities would not be required).
In either way I would really appreiciate if we can come to a conclusion at the earliest. Appreciate everybody's feedback and direction.
You can do like omap and have the generic dma interface sitting in mach-davinci, then for musb, you'd have a series of wrappers to use the cppi dma code. Just look at arch/arm/plat-omap/dma.c and drivers/usb/musb/tusb6010_omap.c
Signature · 1 line
balbi
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Felipe,
This code is also being used for other architectures such as OMAP3517, OMAPL13x etc.
Given this I do not think we can locate it under a mach-* directory.
Have corrected the wrap issue. Thanks for point it out.
regards
swami
________________________________________
From: Felipe Balbi [me at felipebalbi.com]
Sent: Wednesday, December 30, 2009 5:54 PM
To: Subbrathnam, Swaminathan
Cc: felipe.balbi at nokia.com; Gupta, Ajay Kumar; linux-usb at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Sergei Shtylyov
Subject: Re: [PATCH RFC 1/2] MUSB: CPPI 4.1 DMA driver (take 4)
Hi,
please wrap your mails at 80 characters
Quoted 16 lines · Swaminathan
We have been on this front months together now!!! Ideally the place holder would be a place independant of platforms as this piece of code is more of a platform independant library relating to TI CPPI DMA operations. This would be used during initialization and confiuration of CPPI4.x based peripherals. Though today USB is the only peripheral that falls in that catagory ideally other like TI EMAC could fall in the same space.
Having said that I also see that there seems to be no roadmap/plan for any other peripheral other than USB to use CPPI4.x in the near future. TI EMAC seems to continue use CPPI3.x.
This was the reason I had recommended earlier to locate this generic CPPI 4.x functionality within MUSB. This definitely helps in having a functional peripheral in the near (and most probably long) term.
Quoted 7 lines
I think it is prudent to locate this functionality in the musb directory for now. In future if need arises we can relook at this later (I am sure this in all probabilities would not be required).
In either way I would really appreiciate if we can come to a conclusion at the earliest. Appreciate everybody's feedback and direction.
You can do like omap and have the generic dma interface sitting in mach-davinci, then for musb, you'd have a series of wrappers to use the cppi dma code. Just look at arch/arm/plat-omap/dma.c and drivers/usb/musb/tusb6010_omap.c
--
balbi
A message that is not in the archive (sent off-list or not yet received): [email protected]
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Hi,
Quoted 4 lines · Sergei Shtylyov
We're currently having it there but the matter is it should be shred
between different platforms, soarch/arm/common/seems like the right place (which Russell didn't like, suggesting ill suited for thatdrivers/dma/instead).
if it had to be shared between different platforms, it could very well live under drivers/usb/musb, problem is that it has to be shared among several devices. Then drivers/usb/musb is not the right place anymore.
Signature · 1 line
balbi
A message that is not in the archive (sent off-list or not yet received): [email protected]
RFC PATCH 1/2 MUSB: CPPI 4.1 DMA driver (take 4)
Quoted 25 lines
Hello.
Quoted 8 lines · Russell King - ARM Linux
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Is there any updated patch on cppi4.1 core also?
Is there _any_ cppi4.1 core patch anywhere? Not according to google.
Russell,
Here is the latest version of cppi4.1 core.
http://patchwork.kernel.org/patch/46698/[...]
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
If it's a USB DMA device (from the patches I can find, that seems to be the case) then why can't it live in
drivers/usbordrivers/dma?CPPI4.1 DMA engine can be used either by USB or by Ethernet interface
though
Quoted 1 line
Quoted 1 line
currently only USB is using it but in future even Ethernet devices may
use it.
Quoted 1 line
drivers/dmadoes seem to be the right place for this.
Quoted 11 lines
Russell, it makes me wonder why
drivers/dma/seemed the right place to
you, just because of the name? :-)
After spending some time on studying the infrastructure there I came
to
conclusion that this is not the right place because all the controllers supported there have features like memory-to-memory transfers or even RAID function offloading -- which CPPI 4.1 totally lacks (it's there purely to serve the peripherals).
Addingdrivers/dma/people to this discussion in hopes they can
correct
me (or support me :-)...
Russell,
Please provide your thought/suggestion on this issue which is affecting further development of CPPI4.1 DMA driver.
As Sergei pointed out, arch/arm/common seems to be the best suited place for this driver. Is this fine for you OR do you see any issue with this approach?
Please let us know if you need more details.
Regards,
Ajay
Quoted 3 lines
WBR, Sergei
--