Skip to contentSkip to conversation

generic_permission: MAY_OPEN is not write access

PATCH New Serge E. Hallyn 1 participant 1 message Dec 29, 2009 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic_permission: MAY_OPEN is not write access

generic_permission was refusing CAP_DAC_READ_SEARCH-enabled processes from opening DAC-protected files read-only, because do_filp_open adds MAY_OPEN to the open mask.

Ignore MAY_OPEN. After this patch, CAP_DAC_READ_SEARCH is again sufficient to open(fname, O_RDONLY) on a file to which DAC otherwise refuses us read permission.

---
 fs/namei.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/namei.c +1 -0
index 68921d9..b55440b 100644
@@ -232,6 +232,7 @@ int generic_permission(struct inode *inode, int mask,
 	/*
 	 * Searching includes executable on directories, else just read.
 	 */
+	mask &= MAY_READ | MAY_WRITE | MAY_EXEC;
 	if (mask == MAY_READ || (S_ISDIR(inode->i_mode) && !(mask & MAY_WRITE)))
 		if (capable(CAP_DAC_READ_SEARCH))
 			return 0;
Signature · 1 line
1.6.0.4