Skip to contentSkip to conversation

error message when FLAT reloc symbol is invalid, v2

PATCH In review Jun Sun 3 participants 3 messages Jan 1, 2010 – Jan 11, 2010

Subsystems (2)
lore
Share & tools
lore

Jun Sun

author
#0 lore raw

PATCH 1/1 error message when FLAT reloc symbol is invalid, v2

See the attachement.

Jun
-------------- next part --------------
This patch fixes a cosmetic error in printk. Text segment and data/bss segment are allocated from two different areas. It is not meaningful to give the diff between them in the error reporting messages.

---

fs/binfmt_flat.c renamed from fs/binfmt_flat.c.orig +1 -1
diff -Nru linux-2.6.32.2/fs/binfmt_flat.c.orig linux-2.6.32.2/fs/binfmt_flat.c
@@ -355,7 +355,7 @@
 
 	if (!flat_reloc_valid(r, start_brk - start_data + text_len)) {
 		printk("BINFMT_FLAT: reloc outside program 0x%x (0 - 0x%x/0x%x)",
-		       (int) r,(int)(start_brk-start_code),(int)text_len);
+		       (int) r,(int)(start_brk-start_data+text_len),(int)text_len);
 		goto failed;
 	}
 
#2 lore raw
In reply to Jun Sun

Hi Jun,

Quoted 1 line · Jun Sun

See the attachement.

That looks good. I'll apply to the m68knommu git tree and push to Linus in the next merge window (for 2.6.34).

Regards
Greg

Signature · 5 lines
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     [email protected]
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com