Skip to contentSkip to conversation

fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list

PATCH In review Michael Schutte 2 participants 3 messages Jan 1, 2010 VFS

lore
Share & tools
lore

Michael Schutte

author
#0 lore raw

PATCH 1/1 fs/compat_ioctl.c: Add KD[GS]KBDIACRUC to the compatible list

Allow handling of Unicode compose sequences by 32-bit apps on a 64-bit system. The issue has been reported in <http://bugs.debian.org/540534>
and <http://lists.altlinux.org/pipermail/kbd/2009-December/000235.html>.

A formal check of the two affected ioctls in drivers/char/vt_ioctl.c (introduced in 04c71976) and a test using x86 kbd 1.15.1 on a so patched x86_64 kernel both confirm that KD[GS]KBDIACRUC are ioctl32() compatible.

Signed-off-by Michael Schutte <[email protected]>
---
 fs/compat_ioctl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/compat_ioctl.c +2 -0
index 332dd00..07096e9 100644
@@ -991,6 +991,8 @@ COMPATIBLE_IOCTL(KDGKBSENT)
 COMPATIBLE_IOCTL(KDSKBSENT)
 COMPATIBLE_IOCTL(KDGKBDIACR)
 COMPATIBLE_IOCTL(KDSKBDIACR)
+COMPATIBLE_IOCTL(KDGKBDIACRUC)
+COMPATIBLE_IOCTL(KDSKBDIACRUC)
 COMPATIBLE_IOCTL(KDKBDREP)
 COMPATIBLE_IOCTL(KDGKBLED)
 COMPATIBLE_IOCTL(KDGETLED)
Signature · 5 lines
1.6.5


-- 
Michael Schutte <[email protected]>
#1 lore raw
Quoted 10 lines · Michael Schutte

Allow handling of Unicode compose sequences by 32-bit apps on a 64-bit system. The issue has been reported in <http://bugs.debian.org/540534>
and <http://lists.altlinux.org/pipermail/kbd/2009-December/000235.html>.

A formal check of the two affected ioctls in drivers/char/vt_ioctl.c (introduced in 04c71976) and a test using x86 kbd 1.15.1 on a so patched x86_64 kernel both confirm that KD[GS]KBDIACRUC are ioctl32() compatible.

Signed-off-by Michael Schutte <[email protected]>

Since 2.6.32, we handle all VT specific ioctls in the vt_compat_ioctl() function, which should fix this one implicitly. Please try to reproduce with a recent kernel.

Arnd

author
#2 lore raw
Quoted 9 lines · Arnd Bergmann
Quoted 4 lines · Michael Schutte

Allow handling of Unicode compose sequences by 32-bit apps on a 64-bit system. The issue has been reported in <http://bugs.debian.org/540534>
and <http://lists.altlinux.org/pipermail/kbd/2009-December/000235.html>.
[…]

Since 2.6.32, we handle all VT specific ioctls in the vt_compat_ioctl() function, which should fix this one implicitly. Please try to reproduce with a recent kernel.

Works indeed. Thank you for the pointer and sorry for the noise.

Cheers,

Signature · 1 line
Michael Schutte <[email protected]>