Skip to contentSkip to conversation

Samsung N130 ATA exception after 5min uptime -- Phoenix FailSafe issue?

DISCUSSION Hans Werner 3 participants 5 messages Dec 30, 2009 – Jan 4, 2010

lore
Share & tools
lore
#0 lore raw
Quoted 12 lines

Betreff: Re: Samsung N130 ATA exception after 5min uptime -- Phoenix FailSafe issue?

Hello,

Quoted 5 lines · Johannes Stezenbach

I've booted with rdinit=/bin/sh (busybox sh in initramfs), so nothing accesses the disk. After 5min the C state switch happens, but no ATA exception. I waited a few more miniutes and then used dd if=/dev/sda of=/dev/null -> ATA exception. There is no way to escape it.

Quoted 6 lines

Ah, okay, so whatever follows the switch times out.

I have no idea what to do about it at this point. :-(

Signature · 1 line
tejun

Tejun,

testing in the Arch Linux Forums has shown that if one applies a patch which you posted to the linux-ide ML on 2008-11-21 then the problem is no longer seen. Instead the kernel log shows that a spurious IRQ was cleared.

[PATCH #upstraem-fixes] ata_piix: detect and clear spurious IRQs
http://marc.info/?l=linux-ide&m=122724081603679&w=2
http://bbs.archlinux.org/viewtopic.php?id=86454

What's the current status of this patch? Is it safe to use? What does it tell us about the Samsung N130/140?

Regards,
Hans

Signature · 4 lines
Release early, release often.

GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01
#1 lore raw
Quoted 6 lines · Hans Werner

testing in the Arch Linux Forums has shown that if one applies a patch which you posted to the linux-ide ML on 2008-11-21 then the problem is no longer seen. Instead the kernel log shows that a spurious IRQ was cleared.

Quoted 6 lines

[PATCH #upstraem-fixes] ata_piix: detect and clear spurious IRQs
http://marc.info/?l=linux-ide&m=122724081603679&w=2
http://bbs.archlinux.org/viewtopic.php?id=86454

What's the current status of this patch? Is it safe to use? What does it tell us about the Samsung N130/140?

FWIW, I just tested a current git kernel (v2.6.33-rc2-268-g45d28b0) with Tejun's patch applied on my N130. The ATA exception and hang is indeed gone, just "ata1: clearing spurious IRQ" is logged.

I've see Tejun's comment in
http://bugzilla.kernel.org/show_bug.cgi?id=14314
and I would like to add that the ATA irq is not shared.

 14:      43885          0   IO-APIC-edge      ata_piix
 15:          0          0   IO-APIC-edge      ata_piix

Thanks,
Johannes

#2 lore raw

Hello,

Quoted 18 lines · Johannes Stezenbach
Quoted 6 lines · Hans Werner

testing in the Arch Linux Forums has shown that if one applies a patch which you posted to the linux-ide ML on 2008-11-21 then the problem is no longer seen. Instead the kernel log shows that a spurious IRQ was cleared.

Quoted 6 lines

[PATCH #upstraem-fixes] ata_piix: detect and clear spurious IRQs
http://marc.info/?l=linux-ide&m=122724081603679&w=2
http://bbs.archlinux.org/viewtopic.php?id=86454

What's the current status of this patch? Is it safe to use? What does it tell us about the Samsung N130/140?

FWIW, I just tested a current git kernel (v2.6.33-rc2-268-g45d28b0) with Tejun's patch applied on my N130. The ATA exception and hang is indeed gone, just "ata1: clearing spurious IRQ" is logged.

Quoted 6 lines

I've see Tejun's comment in
http://bugzilla.kernel.org/show_bug.cgi?id=14314
and I would like to add that the ATA irq is not shared.

 14:      43885          0   IO-APIC-edge      ata_piix
 15:          0          0   IO-APIC-edge      ata_piix

Can you please post that on bug#14314? If the IRQ line indeed wasn't shared, it might mean that the controller raised the IRQ line before getting its internal state in order and the IRQ checking sequence cleared the external IRQ status while leaving the internal pending bit intact, which I've never heard of on piix and don't think is possible. Hmmmm... given that the problem was dependent on BIOS on the other model (is it the N130?), maybe the BIOS is doing something funny. :-( Anyways, please post full output of "cat /proc/interrupts" at the bz.

Thanks.

Signature · 1 line
tejun
#3 lore raw
Quoted 13 lines · Tejun Heo
Quoted 11 lines · Johannes Stezenbach

FWIW, I just tested a current git kernel (v2.6.33-rc2-268-g45d28b0) with Tejun's patch applied on my N130. The ATA exception and hang is indeed gone, just "ata1: clearing spurious IRQ" is logged.

I've see Tejun's comment in
http://bugzilla.kernel.org/show_bug.cgi?id=14314
and I would like to add that the ATA irq is not shared.

 14:      43885          0   IO-APIC-edge      ata_piix
 15:          0          0   IO-APIC-edge      ata_piix
Quoted 8 lines

Can you please post that on bug#14314? If the IRQ line indeed wasn't shared, it might mean that the controller raised the IRQ line before getting its internal state in order and the IRQ checking sequence cleared the external IRQ status while leaving the internal pending bit intact, which I've never heard of on piix and don't think is possible. Hmmmm... given that the problem was dependent on BIOS on the other model (is it the N130?), maybe the BIOS is doing something funny. :-( Anyways, please post full output of "cat /proc/interrupts" at the bz.

I've updated bug#14314. It is certainly a BIOS issue, but the "spurious IRQ" check deals way better with it than the previous 30sec hang waiting for timeout. IMHO the patch should be merged into mainline asap. Or do you think it has any downside?

Thanks
Johannes

#4 lore raw

Hello,

Quoted 4 lines · Johannes Stezenbach

I've updated bug#14314. It is certainly a BIOS issue, but the "spurious IRQ" check deals way better with it than the previous 30sec hang waiting for timeout. IMHO the patch should be merged into mainline asap. Or do you think it has any downside?

The danger is that when the hardware is actually malfunctioning and causing IRQ storm, the driver will tell the IRQ subsystem that the IRQs aren't spurious. This will bypass the IRQ storm detection logic and lead to complete system lockup under such conditions. Small modification to the patch should remove that problem. I'll post an updated patch soon.

Thanks.

Signature · 1 line
tejun