VLYNQ: add missing linux/irq.h include

PATCH In review Florian Fainelli 2 participants 3 messages Jan 4, 2010

Share & tools

Florian Fainelli

author

2010-01-04 17:43 UTC #0 lore raw

PATCH 1/1 VLYNQ: add missing linux/irq.h include

This patch adds the missing linux/irq.h header which will trigger compilation errors on non-AR7 platforms (i.e: TI Davinci).

Reported-by Rohan Tabish <[email protected]>

Signed-off-by Regards, Florian Fainelli <[email protected]>

---

drivers/vlynq/vlynq.c +1 -0

index 9554ad5..14b1af9 100644
@@ -30,6 +30,7 @@
 #include <linux/interrupt.h>
 #include <linux/delay.h>
 #include <linux/io.h>
+#include <linux/irq.h>
 
 #include <linux/vlynq.h>

Signature · 1 line

1.6.3.3

Christoph Hellwig

2010-01-04 18:12 UTC #1 lore raw

Quoted 3 lines · Florian Fainelli

This patch adds the missing linux/irq.h header
which will trigger compilation errors on non-AR7
platforms (i.e: TI Davinci).

linux/irq.h should not be included by drivers. It's an internal handler for the generic hardirq code. All functions for use by drivers are in linux/interrupt.h

Florian Fainelli

author

2010-01-04 20:22 UTC #2 lore raw

Hi Christoph,

Quoted 8 lines · Christoph Hellwig

Quoted 3 lines · Florian Fainelli
This patch adds the missing linux/irq.h header
which will trigger compilation errors on non-AR7
platforms (i.e: TI Davinci).
linux/irq.h should not be included by drivers. It's an internal handler for the generic hardirq code. All functions for use by drivers are in linux/interrupt.h

vlynq.c references definitions that are in linux/irq.h and not in linux/interrupt.h (like IRQ_TYPE_*), thus the include.

Signature · 5 lines

Best regards, Florian Fainelli
Email: [email protected]
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------