Skip to contentSkip to conversation

hso: Fix for 5 sec timeouts with v2.x firmware

PATCH Applied Jan Dumon 2 participants 2 messages Jan 5, 2010 – Jan 7, 2010

Subsystems (4)
lore
Share & tools
lore

Jan Dumon

author
#0 lore raw

PATCH 5/6 hso: Fix for 5 sec timeouts with v2.x firmware

From: Jan Dumon <[email protected]>

Don't send flow control settings to any port other than the modem port. Older firmware ignored this request but did sent a reply. Newer firmware just ignores it without reply and causes a 5 second timeout every time a port (except for the modem port) is opened or if tiocm settings are changed.

drivers/net/usb/hso.c +4 -0
@@ -1723,6 +1723,10 @@ static int hso_serial_tiocmset(struct tt
 		D1("no tty structures");
 		return -EINVAL;
 	}
+
+	if ((serial->parent->port_spec & HSO_PORT_MASK) != HSO_PORT_MODEM)
+		return -EINVAL;
+
 	if_num = serial->parent->interface->altsetting->desc.bInterfaceNumber;
 
 	spin_lock_irqsave(&serial->serial_lock, flags);
#1 lore raw

From: Jan Dumon <[email protected]>
Date: Tue, 5 Jan 2010 15:52:42 +0100

Quoted 8 lines

From: Jan Dumon <[email protected]>

Don't send flow control settings to any port other than the modem port. Older firmware ignored this request but did sent a reply. Newer firmware just ignores it without reply and causes a 5 second timeout every time a port (except for the modem port) is opened or if tiocm settings are changed.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html