mfd: Fix test of unsigned in twl4030_configure_resource()
Subsystems (2)
PATCH 1/1 mfd: Fix test of unsigned in twl4030_configure_resource()
devgroup is unsigned so the test did not work.
Signed-off-by Roel Kluin <[email protected]>
---
Found using coccinelle: http://coccinelle.lip6.fr/
see
vi arch/arm/mach-omap2/board-rx51-peripherals.c +512
drivers/mfd/twl4030-power.c +1 -1
@@ -335,7 +335,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)return err; } -if (rconfig->devgroup >=0 ) { +if (rconfig->devgroup !=-1 ) { grp &= ~DEVGROUP_MASK ; grp |= rconfig->devgroup <<DEVGROUP_SHIFT ; err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
devgroup is unsigned so the test did not work.
Signed-off-by Roel Kluin <[email protected]>
---
Found using coccinelle: http://coccinelle.lip6.fr/
see
vi arch/arm/mach-omap2/board-rx51-peripherals.c +512
Oops, missed some in previous patch.
Roel
drivers/mfd/twl4030-power.c +3 -3
@@ -335,7 +335,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)return err; } -if (rconfig->devgroup >=0 ) { +if (rconfig->devgroup !=-1 ) { grp &= ~DEVGROUP_MASK ; grp |= rconfig->devgroup <<DEVGROUP_SHIFT ; err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
@@ -355,12 +355,12 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)return err; } -if (rconfig->type >=0 ) { +if (rconfig->type !=-1 ) { type &= ~TYPE_MASK ; type |= rconfig->type <<TYPE_SHIFT ; } -if (rconfig->type2 >=0 ) { +if (rconfig->type2 !=-1 ) { type &= ~TYPE2_MASK ; type |= rconfig->type2 <<TYPE2_SHIFT ; }
Hi Roel,
Quoted 1 line · Roel Kluin
devgroup is unsigned so the test did not work.
This one was fixed with commit 56baa667973e53d6d38af2ad3731d558566d818b.
Cheers,
Samuel.
Quoted 39 lines
Signed-off-by Roel Kluin <[email protected]>---
Found using coccinelle: http://coccinelle.lip6.fr/see
viarch/arm/mach-omap2/board-rx51-peripherals.c+512Oops, missed some in previous patch.
Roel
drivers/mfd/twl4030-power.c +3
-3@@ -335,7 +335,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)return err; } -if (rconfig->devgroup >=0 ) { +if (rconfig->devgroup !=-1 ) { grp &= ~DEVGROUP_MASK ; grp |= rconfig->devgroup <<DEVGROUP_SHIFT ; err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,@@ -355,12 +355,12 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)return err; } -if (rconfig->type >=0 ) { +if (rconfig->type !=-1 ) { type &= ~TYPE_MASK ; type |= rconfig->type <<TYPE_SHIFT ; } -if (rconfig->type2 >=0 ) { +if (rconfig->type2 !=-1 ) { type &= ~TYPE2_MASK ; type |= rconfig->type2 <<TYPE2_SHIFT ; }
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/