Skip to contentSkip to conversation

pca953x: Minor include cleanup

PATCH In review Olof Johansson 3 participants 5 messages Jan 5, 2010 – Jan 9, 2010 I2C subsystem host drivers

lore
Share & tools
lore

Olof Johansson

author
#0 lore raw

PATCH 1/1 pca953x: Minor include cleanup

linux/i2c/pca953x.h is a very bare include file. Fix check for multiple includes of linux/i2c/pca953x.h, and add dependent includes into the header file.

Signed-off-by Olof Johansson <[email protected]>
include/linux/i2c/pca953x.h +8 -0
index 81736d6..29699f8 100644
@@ -1,3 +1,9 @@
+#ifndef _LINUX_PCA953X_H
+#define _LINUX_PCA953X_H
+
+#include <linux/types.h>
+#include <linux/i2c.h>
+
 /* platform data for the PCA9539 16-bit I/O expander driver */
 
 struct pca953x_platform_data {

@@ -17,3 +23,5 @@ struct pca953x_platform_data {
 				void *context);
 	char		**names;
 };
+
+#endif /* _LINUX_PCA953X_H */
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Olof Johansson

linux/i2c/pca953x.h is a very bare include file. Fix check for multiple includes of linux/i2c/pca953x.h, and add dependent includes into the header file.

Signed-off-by Olof Johansson <[email protected]>
Acked-by Wolfram Sang <[email protected]>
Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Acked-by
#2 lore raw
Quoted 8 lines · Wolfram Sang
Quoted 5 lines · Olof Johansson

linux/i2c/pca953x.h is a very bare include file. Fix check for multiple includes of linux/i2c/pca953x.h, and add dependent includes into the header file.

Signed-off-by Olof Johansson <[email protected]>
Acked-by Wolfram Sang <[email protected]>

And also

Acked-by Jean Delvare <[email protected]>

Note though that this file is not part of the i2c subsystem. Your patch is something for the gpio people.

Signature · 1 line
Jean Delvare
author
#3 lore raw
Quoted 8 lines · Jean Delvare
Quoted 7 lines · Wolfram Sang
Quoted 5 lines · Olof Johansson

linux/i2c/pca953x.h is a very bare include file. Fix check for multiple includes of linux/i2c/pca953x.h, and add dependent includes into the header file.

Signed-off-by Olof Johansson <[email protected]>
Quoted 8 lines
Quoted 1 line
Acked-by Wolfram Sang <[email protected]>

And also

Acked-by Jean Delvare <[email protected]>

Note though that this file is not part of the i2c subsystem. Your patch is something for the gpio people.

Boggle. No GPIO maintianer (nor list) mentioned in MAINTAINERS. I don't see any common merge paths in the git log of drivers/gpio either, besides akpm.

So I guess I'll ask him to pick it up.

Andrew: Want a fresh copy of the patch?

-Olof

#4 lore raw

Hi Olof,

Quoted 3 lines · Olof Johansson

Boggle. No GPIO maintianer (nor list) mentioned in MAINTAINERS. I don't see any common merge paths in the git log of drivers/gpio either, besides akpm.

Correct. Feel free to step in ;)

Signature · 1 line
Jean Delvare