scsi: remove superfluous NULL pointer check from scsi_kill_request()
PATCH RESEND 1/1 scsi: remove superfluous NULL pointer check from scsi_kill_request()
Quoted 1 line
From Dan's list:
drivers/scsi/scsi_lib.c +1365 scsi_kill_request(9) warning: variable derefenced in initializer 'cmd' drivers/scsi/scsi_lib.c +1365 scsi_kill_request(9) warning: variable derefenced before check 'cmd'
We dereference cmd (and possible OOPS if cmd == NULL) before starting the request so just remove the superfluous debugging code altogether.
[ bart: the potential NULL pointer dereference was finally fixed in
(much later than mine) commit 03b1470 but my patch is still valid ]
Reported-by Dan Carpenter <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Eugene Teo <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
--- drivers/scsi/scsi_lib.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/scsi/scsi_lib.c +0 -6
@@ -1366,12 +1366,6 @@ static void scsi_kill_request(struct reqblk_start_request (req); -if (unlikely (cmd ==NULL )) { -printk (KERN_CRIT "impossible request in %s.\n" , - __func__); -BUG (); - } - sdev = cmd->device; starget =scsi_target (sdev); shost = sdev->host;