arm omap patches for next -rc

PATCH In review Felipe Balbi 4 participants 17 messages Dec 29, 2009 – Jan 5, 2010

Subsystems (7)

Arm (32-bit) Arm sub-architectures OMAP2+ support OMAP1 support +3 more subsystems

lore

Share & tools

lore

Felipe Balbi

author

2009-12-29 22:51 UTC #0 lore raw

cover arm omap patches for next -rc

Hi Tony,

there are the patches I have for you for the next -rc

as per your request, they are now being sent to LAKML and linux-usb.

Felipe Balbi (12):
arm: omap: musb: ioremap only what's ours
arm: omap: musb: fix board power budget by passing it to
usb_musb_init
arm: omap: musb: fix board mode by passing it to usb_musb_init
arm: omap1: mailbox: kill compile warning
arm: omap: gpmc: kill compile warning
arm: omap: kill compile warning in irq.c
arm: omap: remove unused variables
arm: omap: io: kill compile warning
arm: omap: kill compile warning on board-4430-sdp.c
arm: omap: gpio: kill compile warning in gpio.c
arm: omap: mailbox: kill compile warning in mailbox.c
arm: omap: perseus: kill compile warning on board-perseus2.c

 arch/arm/mach-omap1/devices.c                |    2 +-
 arch/arm/mach-omap1/mailbox.c                |    9 +++++++--
 arch/arm/mach-omap2/board-2430sdp.c          |    3 ++-
 arch/arm/mach-omap2/board-3430sdp.c          |    3 ++-
 arch/arm/mach-omap2/board-4430sdp.c          |    4 ----
 arch/arm/mach-omap2/board-cm-t35.c           |    3 ++-
 arch/arm/mach-omap2/board-igep0020.c         |    3 ++-
 arch/arm/mach-omap2/board-ldp.c              |    3 ++-
 arch/arm/mach-omap2/board-omap3beagle.c      |    3 ++-
 arch/arm/mach-omap2/board-omap3evm.c         |    3 ++-
 arch/arm/mach-omap2/board-omap3pandora.c     |    3 ++-
 arch/arm/mach-omap2/board-omap3touchbook.c   |    3 ++-
 arch/arm/mach-omap2/board-overo.c            |    3 ++-
 arch/arm/mach-omap2/board-rx51.c             |    3 ++-
 arch/arm/mach-omap2/board-zoom-peripherals.c |    3 ++-
 arch/arm/mach-omap2/gpmc.c                   |    6 ++++--
 arch/arm/mach-omap2/io.c                     |    2 ++
 arch/arm/mach-omap2/irq.c                    |    2 ++
 arch/arm/mach-omap2/mailbox.c                |    2 +-
 arch/arm/mach-omap2/omap_hwmod_2430.h        |    2 --
 arch/arm/mach-omap2/usb-musb.c               |   23 +++++++----------------
 arch/arm/plat-omap/gpio.c                    |    3 +++
 arch/arm/plat-omap/include/plat/fpga.h       |    4 ++--
 arch/arm/plat-omap/include/plat/usb.h        |    3 ++-
 24 files changed, 55 insertions(+), 43 deletions(-)

Felipe Balbi

author

2009-12-29 22:51 UTC #1 lore raw

PATCH 1/12 arm: omap: musb: ioremap only what's ours

omap3430 TRM says the OTG address space is 4k, not 8k.

Cc linux-usb at vger.kernel.org

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/usb-musb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/mach-omap2/usb-musb.c +1 -1

index a80441d..ba71f76 100644
@@ -152,7 +152,7 @@ void __init usb_musb_init(void)
 		musb_resources[0].start = OMAP243X_HS_BASE;
 	else
 		musb_resources[0].start = OMAP34XX_HSUSB_OTG_BASE;
-	musb_resources[0].end = musb_resources[0].start + SZ_8K - 1;
+	musb_resources[0].end = musb_resources[0].start + SZ_4K - 1;
 
 	/*
 	 * REVISIT: This line can be removed once all the platforms using

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

2009-12-29 23:51 UTC #2 lore raw

PATCH 1/12 arm: omap: musb: ioremap only what's ours

Quoted 1 line · Felipe Balbi

omap3430 TRM says the OTG address space is 4k, not 8k.

further explanation is that the address space for musb module is 4k and the extra 4k is for L4 interconnect. I'll change the description on the branch Tony will pull from.

Signature · 1 line

balbi

Felipe Balbi

author

2009-12-29 22:51 UTC #3 lore raw

PATCH 2/12 arm: omap: musb: fix board power budget by passing it to usb_musb_init

In reply to Felipe Balbi

each board might have a different charge pump and thus able to source more or less current on vbus so let power be easily configurable.

Cc linux-usb at vger.kernel.org

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/board-2430sdp.c          |    2 +-
 arch/arm/mach-omap2/board-3430sdp.c          |    2 +-
 arch/arm/mach-omap2/board-cm-t35.c           |    2 +-
 arch/arm/mach-omap2/board-igep0020.c         |    2 +-
 arch/arm/mach-omap2/board-ldp.c              |    2 +-
 arch/arm/mach-omap2/board-omap3beagle.c      |    2 +-
 arch/arm/mach-omap2/board-omap3evm.c         |    2 +-
 arch/arm/mach-omap2/board-omap3pandora.c     |    2 +-
 arch/arm/mach-omap2/board-omap3touchbook.c   |    2 +-
 arch/arm/mach-omap2/board-overo.c            |    2 +-
 arch/arm/mach-omap2/board-rx51.c             |    2 +-
 arch/arm/mach-omap2/board-zoom-peripherals.c |    2 +-
 arch/arm/mach-omap2/usb-musb.c               |   12 ++++--------
 arch/arm/plat-omap/include/plat/usb.h        |    2 +-
 14 files changed, 17 insertions(+), 21 deletions(-)

arch/arm/mach-omap2/board-2430sdp.c +1 -1

index e508904..d3857d6 100644
@@ -203,7 +203,7 @@ static void __init omap_2430sdp_init(void)
 	platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
 	omap_serial_init();
 	twl4030_mmc_init(mmc);
-	usb_musb_init();
+	usb_musb_init(100);
 	board_smc91x_init();
 
 	/* Turn off secondary LCD backlight */

arch/arm/mach-omap2/board-3430sdp.c +1 -1

index c90b0d0..1d52fd1 100644
@@ -664,7 +664,7 @@ static void __init omap_3430sdp_init(void)
 				ARRAY_SIZE(sdp3430_spi_board_info));
 	ads7846_dev_init();
 	omap_serial_init();
-	usb_musb_init();
+	usb_musb_init(100);
 	board_smc91x_init();
 	sdp3430_display_init();
 	enable_board_wakeup_source();

arch/arm/mach-omap2/board-cm-t35.c +1 -1

index 2626a9f..56922f4 100644
@@ -585,7 +585,7 @@ static void __init cm_t35_init(void)
 	cm_t35_init_ethernet();
 	cm_t35_init_led();
 
-	usb_musb_init();
+	usb_musb_init(100);
 }
 
 MACHINE_START(CM_T35, "Compulab CM-T35")

arch/arm/mach-omap2/board-igep0020.c +1 -1

index 117b8fd..16be1d5 100644
@@ -216,7 +216,7 @@ static void __init igep2_init(void)
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
 	igep2_i2c_init();
 	omap_serial_init();
-	usb_musb_init();
+	usb_musb_init(100);
 
 	igep2_init_smsc911x();

arch/arm/mach-omap2/board-ldp.c +1 -1

index 995d4a2..ca2acd2 100644
@@ -394,7 +394,7 @@ static void __init omap_ldp_init(void)
 				ARRAY_SIZE(ldp_spi_board_info));
 	ads7846_dev_init();
 	omap_serial_init();
-	usb_musb_init();
+	usb_musb_init(100);
 
 	twl4030_mmc_init(mmc);
 	/* link regulators to MMC adapters */

arch/arm/mach-omap2/board-omap3beagle.c +1 -1

index 231cb4e..52f65e6 100644
@@ -443,7 +443,7 @@ static void __init omap3_beagle_init(void)
 	/* REVISIT leave DVI powered down until it's needed ... */
 	gpio_direction_output(170, true);
 
-	usb_musb_init();
+	usb_musb_init(100);
 	usb_ehci_init(&ehci_pdata);
 	omap3beagle_flash_init();

arch/arm/mach-omap2/board-omap3evm.c +1 -1

index 34de178..c5fd85d 100644
@@ -469,7 +469,7 @@ static void __init omap3_evm_init(void)
 		omap_mux_init_gpio(135, OMAP_PIN_OUTPUT);
 		ehci_pdata.reset_gpio_port[1] = 135;
 	}
-	usb_musb_init();
+	usb_musb_init(100);
 	usb_ehci_init(&ehci_pdata);
 	ads7846_dev_init();
 	omap3evm_init_smsc911x();

arch/arm/mach-omap2/board-omap3pandora.c +1 -1

index ef17cf1..b0cdf77 100644
@@ -413,7 +413,7 @@ static void __init omap3pandora_init(void)
 	omap3pandora_ads7846_init();
 	usb_ehci_init(&ehci_pdata);
 	pandora_keys_gpio_init();
-	usb_musb_init();
+	usb_musb_init(100);
 
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);

arch/arm/mach-omap2/board-omap3touchbook.c +1 -1

index fe3d22c..f7f7670 100644
@@ -545,7 +545,7 @@ static void __init omap3_touchbook_init(void)
 	spi_register_board_info(omap3_ads7846_spi_board_info,
 				ARRAY_SIZE(omap3_ads7846_spi_board_info));
 	omap3_ads7846_init();
-	usb_musb_init();
+	usb_musb_init(100);
 	usb_ehci_init(&ehci_pdata);
 	omap3touchbook_flash_init();

arch/arm/mach-omap2/board-overo.c +1 -1

index d192dd9..4e07a08 100644
@@ -420,7 +420,7 @@ static void __init overo_init(void)
 	platform_add_devices(overo_devices, ARRAY_SIZE(overo_devices));
 	omap_serial_init();
 	overo_flash_init();
-	usb_musb_init();
+	usb_musb_init(100);
 	usb_ehci_init(&ehci_pdata);
 	overo_ads7846_init();
 	overo_init_smsc911x();

arch/arm/mach-omap2/board-rx51.c +1 -1

index 67bb347..0e19316 100644
@@ -82,7 +82,7 @@ static void __init rx51_init(void)
 {
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
 	omap_serial_init();
-	usb_musb_init();
+	usb_musb_init(0);
 	rx51_peripherals_init();
 
 	/* Ensure SDRC pins are mux'd for self-refresh */

arch/arm/mach-omap2/board-zoom-peripherals.c +1 -1

index 8dd277c..abb5fc2 100755
@@ -267,5 +267,5 @@ void __init zoom_peripherals_init(void)
 {
 	omap_i2c_init();
 	omap_serial_init();
-	usb_musb_init();
+	usb_musb_init(100);
 }

arch/arm/mach-omap2/usb-musb.c +4 -8

index ba71f76..b4b8ccc 100644
@@ -124,12 +124,7 @@ static struct musb_hdrc_platform_data musb_plat = {
 	/* .clock is set dynamically */
 	.set_clock	= musb_set_clock,
 	.config		= &musb_config,
-
-	/* REVISIT charge pump on TWL4030 can supply up to
-	 * 100 mA ... but this value is board-specific, like
-	 * "mode", and should be passed to usb_musb_init().
-	 */
-	.power		= 50,			/* up to 100 mA */
+	/* .power	= DYNAMIC, */
 };
 
 static u64 musb_dmamask = DMA_BIT_MASK(32);

@@ -146,7 +141,7 @@ static struct platform_device musb_device = {
 	.resource	= musb_resources,
 };
 
-void __init usb_musb_init(void)
+void __init usb_musb_init(unsigned power)
 {
 	if (cpu_is_omap243x())
 		musb_resources[0].start = OMAP243X_HS_BASE;

@@ -159,6 +154,7 @@ void __init usb_musb_init(void)
 	 * musb_core.c have been converted to use use clkdev.
 	 */
 	musb_plat.clock = "ick";
+	musb_plat.power = power >> 1;
 
 	if (platform_device_register(&musb_device) < 0) {
 		printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");

@@ -167,7 +163,7 @@ void __init usb_musb_init(void)
 }
 
 #else
-void __init usb_musb_init(void)
+void __init usb_musb_init(unsigned power)
 {
 }
 #endif /* CONFIG_USB_MUSB_SOC */

arch/arm/plat-omap/include/plat/usb.h +1 -1

index 33a500e..1b779a1 100644
@@ -42,7 +42,7 @@ struct ehci_hcd_omap_platform_data {
 #define UDC_BASE			OMAP2_UDC_BASE
 #define OMAP_OHCI_BASE			OMAP2_OHCI_BASE
 
-extern void usb_musb_init(void);
+extern void usb_musb_init(unsigned power);
 
 extern void usb_ehci_init(struct ehci_hcd_omap_platform_data *pdata);

Signature · 1 line

1.6.6.35.g1d85d

Sergei Shtylyov

2009-12-30 11:13 UTC #4 lore raw

Re: [patch-v2.6.33-rc2+ 02/12] arm: omap: musb: fix board power budget by passing it to usb_musb_init

Hello.

Quoted 6 lines · Felipe Balbi

each board might have a different charge pump and
thus able to source more or less current on vbus
so let power be easily configurable.
Cc [email protected]
Signed-off-by Felipe Balbi <[email protected]>

[...]

Quoted 28 lines

arch/arm/mach-omap2/usb-musb.c +2 -7

index ba71f76..b4b8ccc 100644
@@ -124,12 +124,7 @@ static struct musb_hdrc_platform_data musb_plat = {
 	/* .clock is set dynamically */
 	.set_clock	= musb_set_clock,
 	.config		= &musb_config,
-
-	/* REVISIT charge pump on TWL4030 can supply up to
-	 * 100 mA ... but this value is board-specific, like
-	 * "mode", and should be passed to usb_musb_init().
-	 */
-	.power		= 50,			/* up to 100 mA */
+	/* .power	= DYNAMIC, */
 };
 
 static u64 musb_dmamask = DMA_BIT_MASK(32);

@@ -146,7 +141,7 @@ static struct platform_device musb_device = {
 	.resource	= musb_resources,
 };
 
-void __init usb_musb_init(void)
+void __init usb_musb_init(unsigned power)
 {
 	if (cpu_is_omap243x())
 		musb_resources[0].start = OMAP243X_HS_BASE;

arch/arm/mach-omap2/usb-musb.c void __init usb_musb_init(void) · line 158

Quoted 5 lines

arch/arm/mach-omap2/usb-musb.c +1 -0

@@ -159,6 +154,7 @@ void __init usb_musb_init(void)
 	 * musb_core.c have been converted to use use clkdev.
 	 */
 	musb_plat.clock = "ick";
+	musb_plat.power = power >> 1;

Probably OMAP boards never supply much current, but otherwise capping
the value of 'power' at 510 seems a good idea.

WBR, Sergei

Felipe Balbi

author

2009-12-29 22:51 UTC #5 lore raw

PATCH 3/12 arm: omap: musb: fix board mode by passing it to usb_musb_init

In reply to Felipe Balbi

each board will have a different mode which is peculiar to that board.

Cc linux-usb at vger.kernel.org

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/board-2430sdp.c          |    3 ++-
 arch/arm/mach-omap2/board-3430sdp.c          |    3 ++-
 arch/arm/mach-omap2/board-cm-t35.c           |    3 ++-
 arch/arm/mach-omap2/board-igep0020.c         |    3 ++-
 arch/arm/mach-omap2/board-ldp.c              |    3 ++-
 arch/arm/mach-omap2/board-omap3beagle.c      |    3 ++-
 arch/arm/mach-omap2/board-omap3evm.c         |    3 ++-
 arch/arm/mach-omap2/board-omap3pandora.c     |    3 ++-
 arch/arm/mach-omap2/board-omap3touchbook.c   |    3 ++-
 arch/arm/mach-omap2/board-overo.c            |    3 ++-
 arch/arm/mach-omap2/board-rx51.c             |    3 ++-
 arch/arm/mach-omap2/board-zoom-peripherals.c |    3 ++-
 arch/arm/mach-omap2/usb-musb.c               |   13 ++++---------
 arch/arm/plat-omap/include/plat/usb.h        |    3 ++-
 14 files changed, 30 insertions(+), 22 deletions(-)

arch/arm/mach-omap2/board-2430sdp.c +2 -1

index d3857d6..45d3197 100644
@@ -23,6 +23,7 @@
 #include <linux/err.h>
 #include <linux/clk.h>
 #include <linux/io.h>
+#include <linux/usb/musb.h>
 
 #include <mach/hardware.h>
 #include <asm/mach-types.h>

@@ -203,7 +204,7 @@ static void __init omap_2430sdp_init(void)
 	platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
 	omap_serial_init();
 	twl4030_mmc_init(mmc);
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 	board_smc91x_init();
 
 	/* Turn off secondary LCD backlight */

arch/arm/mach-omap2/board-3430sdp.c +2 -1

index 1d52fd1..37e7328 100644
@@ -24,6 +24,7 @@
 #include <linux/regulator/machine.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
+#include <linux/usb/musb.h>
 
 #include <mach/hardware.h>
 #include <asm/mach-types.h>

@@ -664,7 +665,7 @@ static void __init omap_3430sdp_init(void)
 				ARRAY_SIZE(sdp3430_spi_board_info));
 	ads7846_dev_init();
 	omap_serial_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 	board_smc91x_init();
 	sdp3430_display_init();
 	enable_board_wakeup_source();

arch/arm/mach-omap2/board-cm-t35.c +2 -1

index 56922f4..9d5db6b 100644
@@ -27,6 +27,7 @@
 #include <linux/input/matrix_keypad.h>
 #include <linux/delay.h>
 #include <linux/gpio.h>
+#include <linux/usb/musb.h>
 
 #include <linux/i2c/at24.h>
 #include <linux/i2c/twl.h>

@@ -585,7 +586,7 @@ static void __init cm_t35_init(void)
 	cm_t35_init_ethernet();
 	cm_t35_init_led();
 
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 }
 
 MACHINE_START(CM_T35, "Compulab CM-T35")

arch/arm/mach-omap2/board-igep0020.c +2 -1

index 16be1d5..6fc0608 100644
@@ -17,6 +17,7 @@
 #include <linux/io.h>
 #include <linux/gpio.h>
 #include <linux/interrupt.h>
+#include <linux/usb/musb.h>
 
 #include <linux/regulator/machine.h>
 #include <linux/i2c/twl.h>

@@ -216,7 +217,7 @@ static void __init igep2_init(void)
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
 	igep2_i2c_init();
 	omap_serial_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 
 	igep2_init_smsc911x();

arch/arm/mach-omap2/board-ldp.c +2 -1

index ca2acd2..7e8c8a8 100644
@@ -27,6 +27,7 @@
 #include <linux/i2c/twl.h>
 #include <linux/io.h>
 #include <linux/smsc911x.h>
+#include <linux/usb/musb.h>
 
 #include <mach/hardware.h>
 #include <asm/mach-types.h>

@@ -394,7 +395,7 @@ static void __init omap_ldp_init(void)
 				ARRAY_SIZE(ldp_spi_board_info));
 	ads7846_dev_init();
 	omap_serial_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 
 	twl4030_mmc_init(mmc);
 	/* link regulators to MMC adapters */

arch/arm/mach-omap2/board-omap3beagle.c +2 -1

index 52f65e6..17f6381 100644
@@ -23,6 +23,7 @@
 #include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
+#include <linux/usb/musb.h>
 
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/partitions.h>

@@ -443,7 +444,7 @@ static void __init omap3_beagle_init(void)
 	/* REVISIT leave DVI powered down until it's needed ... */
 	gpio_direction_output(170, true);
 
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 	usb_ehci_init(&ehci_pdata);
 	omap3beagle_flash_init();

arch/arm/mach-omap2/board-omap3evm.c +2 -1

index c5fd85d..1160004 100644
@@ -23,6 +23,7 @@
 #include <linux/input/matrix_keypad.h>
 #include <linux/leds.h>
 #include <linux/interrupt.h>
+#include <linux/usb/musb.h>
 
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>

@@ -469,7 +470,7 @@ static void __init omap3_evm_init(void)
 		omap_mux_init_gpio(135, OMAP_PIN_OUTPUT);
 		ehci_pdata.reset_gpio_port[1] = 135;
 	}
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 	usb_ehci_init(&ehci_pdata);
 	ads7846_dev_init();
 	omap3evm_init_smsc911x();

arch/arm/mach-omap2/board-omap3pandora.c +2 -1

index b0cdf77..191b75c 100644
@@ -29,6 +29,7 @@
 #include <linux/input.h>
 #include <linux/input/matrix_keypad.h>
 #include <linux/gpio_keys.h>
+#include <linux/usb/musb.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -413,7 +414,7 @@ static void __init omap3pandora_init(void)
 	omap3pandora_ads7846_init();
 	usb_ehci_init(&ehci_pdata);
 	pandora_keys_gpio_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);

arch/arm/mach-omap2/board-omap3touchbook.c +2 -1

index f7f7670..287b914 100644
@@ -23,6 +23,7 @@
 #include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
+#include <linux/usb/musb.h>
 
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/partitions.h>

@@ -545,7 +546,7 @@ static void __init omap3_touchbook_init(void)
 	spi_register_board_info(omap3_ads7846_spi_board_info,
 				ARRAY_SIZE(omap3_ads7846_spi_board_info));
 	omap3_ads7846_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 	usb_ehci_init(&ehci_pdata);
 	omap3touchbook_flash_init();

arch/arm/mach-omap2/board-overo.c +2 -1

index 4e07a08..df04029 100644
@@ -28,6 +28,7 @@
 #include <linux/platform_device.h>
 #include <linux/i2c/twl.h>
 #include <linux/regulator/machine.h>
+#include <linux/usb/musb.h>
 
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/nand.h>

@@ -420,7 +421,7 @@ static void __init overo_init(void)
 	platform_add_devices(overo_devices, ARRAY_SIZE(overo_devices));
 	omap_serial_init();
 	overo_flash_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 	usb_ehci_init(&ehci_pdata);
 	overo_ads7846_init();
 	overo_init_smsc911x();

arch/arm/mach-omap2/board-rx51.c +2 -1

index 0e19316..2480870 100644
@@ -16,6 +16,7 @@
 #include <linux/clk.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
+#include <linux/usb/musb.h>
 
 #include <mach/hardware.h>
 #include <asm/mach-types.h>

@@ -82,7 +83,7 @@ static void __init rx51_init(void)
 {
 	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
 	omap_serial_init();
-	usb_musb_init(0);
+	usb_musb_init(MUSB_PERIPHERAL, 0);
 	rx51_peripherals_init();
 
 	/* Ensure SDRC pins are mux'd for self-refresh */

arch/arm/mach-omap2/board-zoom-peripherals.c +2 -1

index abb5fc2..f157733 100755
@@ -16,6 +16,7 @@
 #include <linux/gpio.h>
 #include <linux/i2c/twl.h>
 #include <linux/regulator/machine.h>
+#include <linux/usb/musb.h>
 
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>

@@ -267,5 +268,5 @@ void __init zoom_peripherals_init(void)
 {
 	omap_i2c_init();
 	omap_serial_init();
-	usb_musb_init(100);
+	usb_musb_init(MUSB_OTG, 100);
 }

arch/arm/mach-omap2/usb-musb.c +4 -9

index b4b8ccc..884336f 100644
@@ -114,17 +114,11 @@ static struct musb_hdrc_config musb_config = {
 };
 
 static struct musb_hdrc_platform_data musb_plat = {
-#ifdef CONFIG_USB_MUSB_OTG
-	.mode		= MUSB_OTG,
-#elif defined(CONFIG_USB_MUSB_HDRC_HCD)
-	.mode		= MUSB_HOST,
-#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)
-	.mode		= MUSB_PERIPHERAL,
-#endif
 	/* .clock is set dynamically */
 	.set_clock	= musb_set_clock,
 	.config		= &musb_config,
 	/* .power	= DYNAMIC, */
+	/* .mode	= DYNAMIC, */
 };
 
 static u64 musb_dmamask = DMA_BIT_MASK(32);

@@ -141,7 +135,7 @@ static struct platform_device musb_device = {
 	.resource	= musb_resources,
 };
 
-void __init usb_musb_init(unsigned power)
+void __init usb_musb_init(enum musb_mode mode, unsigned power)
 {
 	if (cpu_is_omap243x())
 		musb_resources[0].start = OMAP243X_HS_BASE;

@@ -155,6 +149,7 @@ void __init usb_musb_init(unsigned power)
 	 */
 	musb_plat.clock = "ick";
 	musb_plat.power = power >> 1;
+	musb_plat.mode = mode;
 
 	if (platform_device_register(&musb_device) < 0) {
 		printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");

@@ -163,7 +158,7 @@ void __init usb_musb_init(unsigned power)
 }
 
 #else
-void __init usb_musb_init(unsigned power)
+void __init usb_musb_init(enum musb_mode mode, unsigned power)
 {
 }
 #endif /* CONFIG_USB_MUSB_SOC */

arch/arm/plat-omap/include/plat/usb.h +2 -1

index 1b779a1..1e03105 100644
@@ -3,6 +3,7 @@
 #ifndef	__ASM_ARCH_OMAP_USB_H
 #define	__ASM_ARCH_OMAP_USB_H
 
+#include <linux/usb/musb.h>
 #include <plat/board.h>
 
 #define OMAP3_HS_USB_PORTS	3

@@ -42,7 +43,7 @@ struct ehci_hcd_omap_platform_data {
 #define UDC_BASE			OMAP2_UDC_BASE
 #define OMAP_OHCI_BASE			OMAP2_OHCI_BASE
 
-extern void usb_musb_init(unsigned power);
+extern void usb_musb_init(enum musb_mode mode, unsigned power);
 
 extern void usb_ehci_init(struct ehci_hcd_omap_platform_data *pdata);

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #6 lore raw

PATCH 4/12 arm: omap1: mailbox: kill compile warning

In reply to Felipe Balbi

use ioremap and remove unused variable to get rid
of compile warnings.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap1/devices.c |    2 +-
 arch/arm/mach-omap1/mailbox.c |    9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

arch/arm/mach-omap1/devices.c +1 -1

index 23ded2d..9caf51b 100644
@@ -71,7 +71,7 @@ static inline void omap_init_rtc(void) {}
 #  define INT_DSP_MAILBOX1	INT_1610_DSP_MAILBOX1
 #endif
 
-#define OMAP1_MBOX_BASE		OMAP1_IO_ADDRESS(OMAP16XX_MAILBOX_BASE)
+#define OMAP1_MBOX_BASE		OMAP16XX_MAILBOX_BASE
 
 static struct resource mbox_resources[] = {
 	{

arch/arm/mach-omap1/mailbox.c +7 -2

index caf889a..4f5b3da 100644
@@ -146,7 +146,6 @@ EXPORT_SYMBOL(mbox_dsp_info);
 static int __devinit omap1_mbox_probe(struct platform_device *pdev)
 {
 	struct resource *res;
-	int ret = 0;
 
 	if (pdev->num_resources != 2) {
 		dev_err(&pdev->dev, "invalid number of resources: %d\n",

@@ -160,12 +159,18 @@ static int __devinit omap1_mbox_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "invalid mem resource\n");
 		return -ENODEV;
 	}
-	mbox_base = res->start;
+
+	mbox_base = ioremap(res->start, resource_size(res));
+	if (!mbox_base) {
+		dev_err(&pdev->dev, "ioremap failed\n");
+		return -ENODEV;
+	}
 
 	/* DSP IRQ */
 	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	if (unlikely(!res)) {
 		dev_err(&pdev->dev, "invalid irq resource\n");
+		iounmap(mbox_base);
 		return -ENODEV;
 	}
 	mbox_dsp_info.irq = res->start;

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #7 lore raw

PATCH 5/12 arm: omap: gpmc: kill compile warning

In reply to Felipe Balbi

Get rid of the following warnings:

arch/arm/mach-omap2/gpmc.c:550:30: warning: non-ANSI function declaration of function 'omap3_gpmc_save_context'

arch/arm/mach-omap2/gpmc.c:581:33: warning: non-ANSI function declaration of function 'omap3_gpmc_restore_context'

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/gpmc.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/gpmc.c +4 -2

index bd8cb59..32f2c51 100644
@@ -547,9 +547,10 @@ void __init gpmc_init(void)
 #ifdef CONFIG_ARCH_OMAP3
 static struct omap3_gpmc_regs gpmc_context;
 
-void omap3_gpmc_save_context()
+void omap3_gpmc_save_context(void)
 {
 	int i;
+
 	gpmc_context.sysconfig = gpmc_read_reg(GPMC_SYSCONFIG);
 	gpmc_context.irqenable = gpmc_read_reg(GPMC_IRQENABLE);
 	gpmc_context.timeout_ctrl = gpmc_read_reg(GPMC_TIMEOUT_CONTROL);

@@ -578,9 +579,10 @@ void omap3_gpmc_save_context()
 	}
 }
 
-void omap3_gpmc_restore_context()
+void omap3_gpmc_restore_context(void)
 {
 	int i;
+
 	gpmc_write_reg(GPMC_SYSCONFIG, gpmc_context.sysconfig);
 	gpmc_write_reg(GPMC_IRQENABLE, gpmc_context.irqenable);
 	gpmc_write_reg(GPMC_TIMEOUT_CONTROL, gpmc_context.timeout_ctrl);

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #8 lore raw

PATCH 6/12 arm: omap: kill compile warning in irq.c

In reply to Felipe Balbi

intc_context is only used when omap3 is to be built, so also put it under ifdef CONFIG_ARM_OMAP3 to avoid the compile warning.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/irq.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/irq.c +2 -0

index e9bc782..d370052 100644
@@ -62,7 +62,9 @@ struct omap3_intc_regs {
 	u32 mir[INTCPS_NR_MIR_REGS];
 };
 
+#ifdef CONFIG_ARCH_OMAP3
 static struct omap3_intc_regs intc_context[ARRAY_SIZE(irq_banks)];
+#endif
 
 /* INTC bank register get/set */

Signature · 1 line

1.6.6.35.g1d85d

Tony Lindgren

maintainer

2010-01-05 20:20 UTC #9 lore raw

PATCH 6/12 arm: omap: kill compile warning in irq.c

Quoted 14 lines · Felipe Balbi

intc_context is only used when omap3 is to be built, so also put it under ifdef CONFIG_ARM_OMAP3 to avoid the compile warning.
Signed-off-by Felipe Balbi <[email protected]>
---
 arch/arm/mach-omap2/irq.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/irq.c +0 -0
index e9bc782..d370052 100644

arch/arm/mach-omap2/irq.c struct omap3_intc_regs { · line 69

Quoted 8 lines

arch/arm/mach-omap2/irq.c +2 -0

@@ -62,7 +62,9 @@ struct omap3_intc_regs {
 	u32 mir[INTCPS_NR_MIR_REGS];
 };
 
+#ifdef CONFIG_ARCH_OMAP3
 static struct omap3_intc_regs intc_context[ARRAY_SIZE(irq_banks)];
+#endif
 
 /* INTC bank register get/set */

Can you please move the struct omap3_intc_regs intc_context into to right above save_context function where we have the a block already for ifdef CONFIG_ARCH_OMAP3?

That avoids adding a new ifdef block.

Regards,

Tony

Felipe Balbi

author

2009-12-29 22:51 UTC #10 lore raw

PATCH 7/12 arm: omap: remove unused variables

In reply to Felipe Balbi

those are never used, remove it until we need to
actually use them to avoid the compile warning.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/omap_hwmod_2430.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/omap_hwmod_2430.h +0 -2

index 59a208b..49139ad 100644
@@ -62,8 +62,6 @@ static struct omap_hwmod omap2430_l3_hwmod = {
 };
 
 static struct omap_hwmod omap2430_l4_wkup_hwmod;
-static struct omap_hwmod omap2430_mmc1_hwmod;
-static struct omap_hwmod omap2430_mmc2_hwmod;
 
 /* L4_CORE -> L4_WKUP interface */
 static struct omap_hwmod_ocp_if omap2430_l4_core__l4_wkup = {

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #11 lore raw

PATCH 8/12 arm: omap: io: kill compile warning

In reply to Felipe Balbi

when building omap4 defconfigs, io.c will warn about unused _omap2_init_reprogram_sdrc, that's because that functio is only used ifndef CONFIG_ARCH_OMAP4, so add the missing ifndef CONFIG_ARCH_OMAP4 to _omap2_init_reprogram_sdrc definition.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/io.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/mach-omap2/io.c +2 -0

index 5a79964..9e868fa 100644
@@ -276,6 +276,7 @@ void __init omap2_map_common_io(void)
  * -EINVAL if the dpll3_m2_ck cannot be found, 0 if called on OMAP2,
  * or passes along the return value of clk_set_rate().
  */
+#ifndef CONFIG_ARCH_OMAP4
 static int __init _omap2_init_reprogram_sdrc(void)
 {
 	struct clk *dpll3_m2_ck;

@@ -299,6 +300,7 @@ static int __init _omap2_init_reprogram_sdrc(void)
 
 	return v;
 }
+#endif
 
 void __init omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
 				 struct omap_sdrc_params *sdrc_cs1)

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #12 lore raw

PATCH 9/12 arm: omap: kill compile warning on board-4430-sdp.c

In reply to Felipe Balbi

sdp4430_uart_config isn't used anywhere, so remove it.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/board-4430sdp.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

arch/arm/mach-omap2/board-4430sdp.c +0 -4

index 0c6be6b..a7788b4 100644
@@ -38,10 +38,6 @@ static struct platform_device *sdp4430_devices[] __initdata = {
 	&sdp4430_lcd_device,
 };
 
-static struct omap_uart_config sdp4430_uart_config __initdata = {
-	.enabled_uarts	= (1 << 0) | (1 << 1) | (1 << 2) | (1 << 3),
-};
-
 static struct omap_lcd_config sdp4430_lcd_config __initdata = {
 	.ctrl_name	= "internal",
 };

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #13 lore raw

PATCH 10/12 arm: omap: gpio: kill compile warning in gpio.c

In reply to Felipe Balbi

when building linux-omap for omap1510, there will be a compile warning about the unused flags variable which is only used on 16xx and onwards.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/plat-omap/gpio.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

arch/arm/plat-omap/gpio.c +3 -0

index 0484681..8c34b81 100644
@@ -1072,7 +1072,10 @@ static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int ena
  */
 static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable)
 {
+#if defined(CONFIG_ARCH_OMAP16XX) || defined(CONFIG_ARCH_OMAP24XX) || \
+	defined(CONFIG_ARCH_OMAP34XX) || defined(CONFIG_ARCH_OMAP4)
 	unsigned long flags;
+#endif
 
 	switch (bank->method) {
 #ifdef CONFIG_ARCH_OMAP16XX

Signature · 1 line

1.6.6.35.g1d85d

Tony Lindgren

maintainer

2010-01-05 20:20 UTC #14 lore raw

PATCH 10/12 arm: omap: gpio: kill compile warning in gpio.c

Quoted 14 lines · Felipe Balbi

when building linux-omap for omap1510, there will be a compile warning about the unused flags variable which is only used on 16xx and onwards.
Signed-off-by Felipe Balbi <[email protected]>
---
 arch/arm/plat-omap/gpio.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/plat-omap/gpio.c +0 -0
index 0484681..8c34b81 100644

arch/arm/plat-omap/gpio.c static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int ena · line 1079

Quoted 8 lines

arch/arm/plat-omap/gpio.c +3 -0

@@ -1072,7 +1072,10 @@ static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int ena
  */
 static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable)
 {
+#if defined(CONFIG_ARCH_OMAP16XX) || defined(CONFIG_ARCH_OMAP24XX) || \
+	defined(CONFIG_ARCH_OMAP34XX) || defined(CONFIG_ARCH_OMAP4)
 	unsigned long flags;
+#endif

Let's not add more ifdeffery to gpio.c.. How about let's use uninitialized_var() instead? See the patch below.

Regards,

Tony

Felipe Balbi

author

2009-12-29 22:51 UTC #15 lore raw

PATCH 11/12 arm: omap: mailbox: kill compile warning in mailbox.c

In reply to Felipe Balbi

Change %d to %ld to avoid the compile warning.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-omap2/mailbox.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/mach-omap2/mailbox.c +1 -1

index 281ab63..2c9fd1c 100644
@@ -93,7 +93,7 @@ static int omap2_mbox_startup(struct omap_mbox *mbox)
 
 	mbox_ick_handle = clk_get(NULL, "mailboxes_ick");
 	if (IS_ERR(mbox_ick_handle)) {
-		printk(KERN_ERR "Could not get mailboxes_ick: %d\n",
+		printk(KERN_ERR "Could not get mailboxes_ick: %ld\n",
 			PTR_ERR(mbox_ick_handle));
 		return PTR_ERR(mbox_ick_handle);
 	}

Signature · 1 line

1.6.6.35.g1d85d

Felipe Balbi

author

2009-12-29 22:51 UTC #16 lore raw

PATCH 12/12 arm: omap: perseus: kill compile warning on board-perseus2.c

In reply to Felipe Balbi

that address is used by struct map_desc, which expects an unsigned long instead of a void __iomem *. Fix it.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/plat-omap/include/plat/fpga.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/plat-omap/include/plat/fpga.h +2 -2

index f1864a6..023b3eb 100644
@@ -34,9 +34,9 @@ extern void omap1510_fpga_init_irq(void);
  * ---------------------------------------------------------------------------
  */
 /* maps in the FPGA registers and the ETHR registers */
-#define H2P2_DBG_FPGA_BASE		IOMEM(0xE8000000)	/* VA */
+#define H2P2_DBG_FPGA_BASE		0xE8000000		/* VA */
 #define H2P2_DBG_FPGA_SIZE		SZ_4K			/* SIZE */
-#define H2P2_DBG_FPGA_START		0x04000000		/* PA */
+#define H2P2_DBG_FPGA_START		IOMEM(0x04000000)	/* PA */
 
 #define H2P2_DBG_FPGA_ETHR_START	(H2P2_DBG_FPGA_START + 0x300)
 #define H2P2_DBG_FPGA_FPGA_REV		(H2P2_DBG_FPGA_BASE + 0x10)	/* FPGA Revision */

Signature · 1 line

1.6.6.35.g1d85d