Skip to contentSkip to conversation

OMAP3EVM: Choose OMAP_PACKAGE_CBB

PATCH In review [email protected] 2 participants 3 messages Dec 31, 2009 – Jan 6, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 OMAP3EVM: Choose OMAP_PACKAGE_CBB

From: Vaibhav Hiremath <[email protected]>

Without this the kernel doesn't boot, it craches in omap_mux_package_fixup(), since the package_subset becomes NULL.

Signed-off-by Vaibhav Hiremath <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +1 -0
index 10eafa7..606bf04 100644
@@ -80,6 +80,7 @@ config MACH_OVERO
 config MACH_OMAP3EVM
 	bool "OMAP 3530 EVM board"
 	depends on ARCH_OMAP3 && ARCH_OMAP34XX
+	select OMAP_PACKAGE_CBB
 
 config MACH_OMAP3517EVM
 	bool "OMAP3517/ AM3517 EVM board"
Signature · 1 line
1.6.2.4
maintainer
#1 lore raw

PATCH 1/1 OMAP3EVM: Choose OMAP_PACKAGE_CBB

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): a46b02659f8d2edff801441443ba85dec024d0f8

PatchWorks
http://patchwork.kernel.org/patch/70349/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=a46b02659f8d2edff801441443ba85dec024d0f8

maintainer
#2 lore raw
In reply to [email protected]
Quoted 15 lines · * [email protected] <[email protected]> [091230 22:22]:

From: Vaibhav Hiremath <[email protected]>

Without this the kernel doesn't boot, it craches in omap_mux_package_fixup(), since the package_subset becomes NULL.

Signed-off-by Vaibhav Hiremath <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +0 -0
index 10eafa7..606bf04 100644

arch/arm/mach-omap2/Kconfig config MACH_OVERO · line 86

Quoted 7 lines
arch/arm/mach-omap2/Kconfig +1 -0
@@ -80,6 +80,7 @@ config MACH_OVERO
 config MACH_OMAP3EVM
 	bool "OMAP 3530 EVM board"
 	depends on ARCH_OMAP3 && ARCH_OMAP34XX
+	select OMAP_PACKAGE_CBB
 
 config MACH_OMAP3517EVM
 	bool "OMAP3517/ AM3517 EVM board"

Also applying the following fix so uninitialized packages won't cause problems.

Regards,

Tony

Quoted 1 line

From a6f77c57a213d692ef61db8e7920390779960302 Mon Sep 17 00:00:00 2001

From: Tony Lindgren <[email protected]>
Date: Tue, 5 Jan 2010 15:54:58 -0800
Subject: [PATCH] omap: Fix booting if package is uninitialized

Otherwise bringing up new boards can be harder:

Unable to handle kernel NULL pointer dereference at virtual address 00000000
pgd = c0004000
[00000000] *pgd=00000000
Internal error: Oops: 5 [#1]
last sysfs file:
Modules linked in:
CPU: 0    Not tainted  (2.6.33-rc2-00015-g0bc9c93-dirty #37)
PC is at omap_mux_init+0xa4/0x3d8
LR is at omap_mux_init+0x3c/0x3d8

...

Signed-off-by Tony Lindgren <[email protected]>
arch/arm/mach-omap2/mux.c +4 -2
index e071b3f..459ef23 100644
@@ -994,8 +994,10 @@ int __init omap_mux_init(u32 mux_pbase, u32 mux_size,
 	}
 
 #ifdef CONFIG_OMAP_MUX
-	omap_mux_package_fixup(package_subset, superset);
-	omap_mux_package_init_balls(package_balls, superset);
+	if (package_subset)
+		omap_mux_package_fixup(package_subset, superset);
+	if (package_balls)
+		omap_mux_package_init_balls(package_balls, superset);
 	omap_mux_set_cmdline_signals();
 	omap_mux_set_board_signals(board_mux);
 #endif