Skip to contentSkip to conversation

Remove unneeded __init from s3c24xx_ts_set_platdata

PATCH New Nelson Castillo 2 participants 4 messages Jan 6, 2010

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Nelson Castillo

author
#0 lore raw

PATCH 1/2 Remove unneeded __init from s3c24xx_ts_set_platdata

Remove unneeded __init in function definition.

Signed-off-by Nelson Castillo <[email protected]>

---

 arch/arm/plat-s3c24xx/devs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c24xx/devs.c +1 -1
index 7f686a3..267f36a 100644
@@ -193,7 +193,7 @@ EXPORT_SYMBOL(s3c_device_ts);
 
 static struct s3c2410_ts_mach_info s3c2410ts_info;
 
-void __init s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *hard_s3c2410ts_info)
+void s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *hard_s3c2410ts_info)
 {
 	memcpy(&s3c2410ts_info, hard_s3c2410ts_info, sizeof(struct s3c2410_ts_mach_info));
 	s3c_device_ts.dev.platform_data = &s3c2410ts_info;
author
#1 lore raw

PATCH 2/2 Remove unneeded __init for s3c_nand_set_platdata

Remove unneeded __init in function definition.

Signed-off-by Nelson Castillo <[email protected]>

---

 arch/arm/plat-s3c/dev-nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c/dev-nand.c +1 -1
index 84808cc..a1137a7 100644
@@ -79,7 +79,7 @@ static int __init s3c_nand_copy_set(struct s3c2410_nand_set *set)
 	return 0;
 }
 
-void __init s3c_nand_set_platdata(struct s3c2410_platform_nand *nand)
+void s3c_nand_set_platdata(struct s3c2410_platform_nand *nand)
 {
 	struct s3c2410_platform_nand *npd;
 	int size;
#2 lore raw

PATCH 1/2 Remove unneeded __init from s3c24xx_ts_set_platdata

In reply to Nelson Castillo

Hello,

Quoted 1 line · Nelson Castillo

Remove unneeded __init in function definition.

you should only remove '__init's if they are wrong. And if these are wrong, you should point out why.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
author
#3 lore raw

PATCH 1/2 Remove unneeded __init from s3c24xx_ts_set_platdata

2010/1/6 Uwe Kleine-K?nig <[email protected]>:

Quoted 6 lines

Hello,

Quoted 1 line · Nelson Castillo

Remove unneeded __init in function definition.

you should only remove '__init's if they are wrong. ?And if these are wrong, you should point out why.

Sure.

It's because the functions are both marked as __init and they're exported and we get a warning at build time. I should have written this in the patch :-/ I'll resend them later if no mpre comments are received.