Skip to contentSkip to conversation

mtd/nand: Fix build failure caused by typo

PATCH In review Peter Hüwe 3 participants 3 messages Jan 7, 2010

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Peter Hüwe

author
#0 lore raw

PATCH 1/1 mtd/nand: Fix build failure caused by typo

From: Peter Huewe <[email protected]>
Date: Thu, 7 Jan 2010 02:51:13 +0100

This patch fixes a build failure[1] introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size() by H Hartley Sweeten [2]
The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.

This patch fixes this typo and thus removes the build failure.

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
[2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984

Patch against linux-next of Do 7. Jan 02:58:41 CET 2010

Signed-off-by Peter Huewe <[email protected]>
---
 drivers/mtd/nand/orion_nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/orion_nand.c +1 -1
index 9903460..f16050c 100644
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
-		err = -ENODEV;
+		ret = -ENODEV;
 		goto no_res;
 	}
Signature · 1 line
1.6.4.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Peter Hüwe

From: Peter Huewe <[email protected]>
Date: Thu, 7 Jan 2010 02:51:13 +0100

This patch fixes a build failure[1] introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size() by H Hartley Sweeten [2]
The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.

This patch fixes this typo and thus removes the build failure.

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/1983354/
[2] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=e99030609e27abff7e1a868cb56384c678b09984

Patch against linux-next of Do 7. Jan 02:58:41 CET 2010

Signed-off-by Peter Huewe <[email protected]>
---
 drivers/mtd/nand/orion_nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/orion_nand.c +0 -0
index 9903460..f16050c 100644

drivers/mtd/nand/orion_nand.c static int __init orion_nand_probe(struct platform_device *pdev) · line 97

Quoted 7 lines
drivers/mtd/nand/orion_nand.c +1 -1
@@ -92,7 +92,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {
-		err = -ENODEV;
+		ret = -ENODEV;
 		goto no_res;
 	}

Sorry about that.

Reviewed-by H Hartley Sweeten <[email protected]>
Acked-by
#2 lore raw

Hello,

Quoted 7 lines
Quoted 7 lines

This patch fixes a build failure[1] introduced by the patch
mtd: orion_nand.c: add error handling and use resource_size() by H Hartley Sweeten [2]
The patch assigns something to a undeclared variable 'err', whereas the rest of the code uses 'ret' for this task.

This patch fixes this typo and thus removes the build failure.

Acked-by Uwe Kleine-König <[email protected]>

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |