QMP: Don't free async event's 'data'
PATCH 1/1 QMP: Don't free async event's 'data'
The monitor_protocol_event() function will free the event's data, this is wrong as 'data' management is up to the caller.
Signed-off-by Luiz Capitulino <[email protected]>
--- monitor.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
monitor.c +3 -1
@@ -365,8 +365,10 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) qmp =qdict_new ();timestamp_put (qmp);qdict_put (qmp,"event" ,qstring_from_str (event_name)); -if (data) +if (data) { +qobject_incref (data);qdict_put_obj (qmp,"data" , data); + }monitor_json_emitter (mon,QOBJECT (qmp));QDECREF (qmp);
Signature · 1 line
1.6.6
Anthony Liguori
AppliedQuoted 6 lines · Luiz Capitulino
The
monitor_protocol_event()function will free the event's data, this is wrong as 'data' management is up to the caller.Signed-off-by Luiz Capitulino<[email protected]>
Applied. Thanks.
Regards,
Anthony Liguori
Quoted 21 lines
--- monitor.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)monitor.c +3
-1@@ -365,8 +365,10 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) qmp =qdict_new ();timestamp_put (qmp);qdict_put (qmp,"event" ,qstring_from_str (event_name)); -if (data) +if (data) { +qobject_incref (data);qdict_put_obj (qmp,"data" , data); + }monitor_json_emitter (mon,QOBJECT (qmp));QDECREF (qmp);