Skip to contentSkip to conversation

HTC Dream camera, not need sizeof

PATCH In review Pavel Vasilyev 2 participants 2 messages Jan 11, 2010 Staging

lore
Share & tools
lore

Pavel Vasilyev

author
#0 lore raw

PATCH 1/1 HTC Dream camera, not need sizeof

http://bugzilla.kernel.org/show_bug.cgi?id=14825

Kernel version: git master (2.6.33-rc3-git3)

Description:

sizeof(extlen), always will be sizeof( unit32_t) or 4 It seems that something is wrong?!?!

-------

(quoted diff) +0 -0

b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644

drivers/staging/dream/camera/msm_vfe7x.c +1 -1
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
        extlen = sizeof(struct vfe_frame_extra);
 
        extdata =
-               kmalloc(sizeof(extlen), GFP_ATOMIC);
+              kmalloc(extlen, GFP_ATOMIC);
        if (!extdata) {
                rc = -ENOMEM;
                goto init_fail;

----

#1 lore raw
Quoted 9 lines · Pavel Vasilyev

http://bugzilla.kernel.org/show_bug.cgi?id=14825

Kernel version: git master (2.6.33-rc3-git3)

Description:

sizeof(extlen), always will be sizeof( unit32_t) or 4 It seems that something is wrong?!?!

Can I get a "Signed-off-by:" for this patch so that I can apply it to the tree?

thanks,

greg k-h