nv50: fix 2 off by one memory leaks (nv50_miptree_level->image_offset)

PATCH New Marcin Slusarz 1 participant 1 message Jan 12, 2010

Share & tools

Marcin Slusarz

author

2010-01-12 14:43 UTC #0 lore raw

PATCH 1/1 nv50: fix 2 off by one memory leaks (nv50_miptree_level->image_offset)

From: Marcin Slusarz <[email protected]>
Subject: [mesa PATCH] nv50: fix 2 off by one memory leaks (nv50_miptree_level->image_offset)

---
 src/gallium/drivers/nv50/nv50_miptree.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

src/gallium/drivers/nv50/nv50_miptree.c +2 -2

index 3f1edf0..cecb1ef 100644
@@ -145,7 +145,7 @@ nv50_miptree_create(struct pipe_screen *pscreen, const struct pipe_texture *tmp)
 				  mt->level[0].tile_mode, tile_flags,
 				  &mt->base.bo);
 	if (ret) {
-		for (l = 0; l < pt->last_level; ++l)
+		for (l = 0; l <= pt->last_level; ++l)
 			FREE(mt->level[l].image_offset);
 		FREE(mt);
 		return NULL;

@@ -188,7 +188,7 @@ nv50_miptree_destroy(struct pipe_texture *pt)
 	struct nv50_miptree *mt = nv50_miptree(pt);
 	unsigned l;
 
-	for (l = 0; l < pt->last_level; ++l)
+	for (l = 0; l <= pt->last_level; ++l)
 		FREE(mt->level[l].image_offset);
 
 	nouveau_bo_ref(NULL, &mt->base.bo);

Signature · 1 line

1.6.6.rc3