Skip to contentSkip to conversation

init/main.c: make setup_max_cpus static for !SMP

PATCH New H Hartley Sweeten 1 participant 1 message Jan 13, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 init/main.c: make setup_max_cpus static for !SMP

init/main.c: make setup_max_cpus static for !SMP

The only in tree external users of the symbol setup_max_cpus are in arch/x86/. The files ./kernel/alternative.c, ./kernel/visws_quirks.c, and ./mm/kmemcheck/kmemcheck.c are all guarded by CONFIG_SMP being defined. For this case the symbol is an unsigned int and declared as an extern in include/linux/smp.h.

When CONFIG_SMP is not defined the symbol setup_max_cpus is a constant value that is only used in init/main.c. Make the symbol static for this case.

---

init/main.c +1 -1
index dac44a9..7110851 100644
@@ -160,7 +160,7 @@ static int __init maxcpus(char *str)
 
 early_param("maxcpus", maxcpus);
 #else
-const unsigned int setup_max_cpus = NR_CPUS;
+static const unsigned int setup_max_cpus = NR_CPUS;
 #endif
 
 /*