Skip to contentSkip to conversation

rdma_cm.h: Fix SCTP protocol ID

PATCH In review Hal Rosenstock 3 participants 6 messages Jan 13, 2010 4 messages not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 rdma_cm.h: Fix SCTP protocol ID

Should be 132 rather than 131 according to IANA IP protocol IDs

Signed-off-by Hal Rosenstock <[email protected]>

---

include/rdma/rdma_cm.h +1 -1
index c6b2962..1c5e589 100644
@@ -67,7 +67,7 @@ enum rdma_port_space {
 	RDMA_PS_IPOIB = 0x0002,
 	RDMA_PS_TCP   = 0x0106,
 	RDMA_PS_UDP   = 0x0111,
-	RDMA_PS_SCTP  = 0x0183
+	RDMA_PS_SCTP  = 0x0184
 };
 
 struct rdma_addr {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 3 lines

Should be 132 rather than 131 according to IANA IP protocol IDs

Signed-off-by Hal Rosenstock <[email protected]>
Acked-by Sean Hefty <[email protected]>
Quoted 1 line

---

Thanks. I just noticed this this morning after reviewing the luster patches. You beat me to the patch.

include/rdma/rdma_cm.h enum rdma_port_space { · line 73

Quoted 13 lines
include/rdma/rdma_cm.h +1 -1
index c6b2962..1c5e589 100644
@@ -67,7 +67,7 @@ enum rdma_port_space {
 	RDMA_PS_IPOIB = 0x0002,
 	RDMA_PS_TCP   = 0x0106,
 	RDMA_PS_UDP   = 0x0111,
-	RDMA_PS_SCTP  = 0x0183
+	RDMA_PS_SCTP  = 0x0184
 };
 
 struct rdma_addr {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to a message not in the archive

include/rdma/rdma_cm.h enum rdma_port_space { · line 70

Quoted 3 lines
include/rdma/rdma_cm.h +1 -1
-	RDMA_PS_SCTP  = 0x0183
+	RDMA_PS_SCTP  = 0x0184

The old wrong value has been there since we first merged this. So changing it means anything using this in userspace would be broken. But is PS_SCTP exported to userspace? And as far as I can tell PS_SCTP is not implemented (this line is the only reference to RDMA_PS_SCTP in the whole kernel). So would it make more sense to delete this enum value entirely? --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): adaska9n2d3.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org

#5 lore raw
Quoted 5 lines

The old wrong value has been there since we first merged this. So changing it means anything using this in userspace would be broken. But is PS_SCTP exported to userspace? And as far as I can tell PS_SCTP is not implemented (this line is the only reference to RDMA_PS_SCTP in the whole kernel). So would it make more sense to delete this enum value entirely?

Technically, I believe it's available to userspace, though the librdmacm doesn't define it. I'd be surprised if anything uses it.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 7E10F17E68C24836BE68F8F22B64862B-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org

#7 lore raw
Quoted 3 lines

Technically, I believe it's available to userspace, though the librdmacm doesn't define it. I'd be surprised if anything uses it.

Wouldn't trying to use RDMA_PS_SCTP hit the

	default:
		return -EPROTONOSUPPORT;

case in cma_get_port()? So one couldn't actually do anything with RDMA_PS_SCTP? Or is there some way to avoid binding?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): adak4vln1ks.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org

#9 lore raw
Quoted 7 lines

Wouldn't trying to use RDMA_PS_SCTP hit the

	default:
		return -EPROTONOSUPPORT;

case in cma_get_port()? So one couldn't actually do anything with RDMA_PS_SCTP? Or is there some way to avoid binding?

You're right. There isn't any way to actually do anything with it. All code paths go through rdma_bind_addr.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html