Section mismatch fixes

hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with __init. Since hugetlb_register_node is only called by hugetlb_register_all_nodes, which in turn is only called by hugetlb_init, it's safe to mark both of them as __init.

Signed-off-by Jeff Mahoney <[email protected]>

---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Quoted 10 lines · Jeff Mahoney

hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with __init. Since hugetlb_register_node is only called by hugetlb_register_all_nodes, which in turn is only called by hugetlb_init, it's safe to mark both of them as __init.

Signed-off-by Jeff Mahoney <[email protected]>

---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

mm/hugetlb.c void hugetlb_unregister_node(struct node · line 1636

Quoted 11 lines

mm/hugetlb.c +1 -1

@@ -1630,7 +1630,7 @@ void hugetlb_unregister_node(struct node
  * hugetlb module exit:  unregister hstate attributes from node sysdevs
  * that have them.
  */
-static void hugetlb_unregister_all_nodes(void)
+static void __init hugetlb_unregister_all_nodes(void)
 {
 	int nid;
 

This is wrong, you want to move hugetlb_register_all_nodes() to .init.text, not hugetlb_unregister_all_nodes().

mm/hugetlb.c static void hugetlb_unregister_all_nodes · line 1656

Quoted 9 lines

mm/hugetlb.c +1 -1

@@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes
  * Register hstate attributes for a single node sysdev.
  * No-op if attributes already registered.
  */
-void hugetlb_register_node(struct node *node)
+void __init hugetlb_register_node(struct node *node)
 {
 	struct hstate *h;
 	struct node_hstate *nhs = &node_hstates[node->sysdev.id];

hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with __init. Since hugetlb_register_node is only called by hugetlb_register_all_nodes, which in turn is only called by hugetlb_init, it's safe to mark both of them as __init.

Signed-off-by Jeff Mahoney <[email protected]>

plain text document attachment (patches.rpmify) hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with
__init. Since hugetlb_register_node is only called by hugetlb_register_all_nodes, which in turn is only called by hugetlb_init, it's safe to mark both of them as __init.

Signed-off-by Jeff Mahoney <[email protected]>

---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

mm/hugetlb.c +2 -3

@@ -1630,7 +1630,7 @@ void hugetlb_unregister_node(struct node
  * hugetlb module exit:  unregister hstate attributes from node sysdevs
  * that have them.
  */
-static void hugetlb_unregister_all_nodes(void)
+static void __init hugetlb_unregister_all_nodes(void)
 {
 	int nid;
 

@@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes
  * Register hstate attributes for a single node sysdev.
  * No-op if attributes already registered.
  */
-void hugetlb_register_node(struct node *node)
+void __init hugetlb_register_node(struct node *node)
 {
 	struct hstate *h;
 	struct node_hstate *nhs = &node_hstates[node->sysdev.id];
 
 
--

To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Quoted 5 lines · Jeff Mahoney

plain text document attachment (patches.rpmify) hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with
__init. Since hugetlb_register_node is only called by hugetlb_register_all_nodes, which in turn is only called by hugetlb_init, it's safe to mark both of them as __init.

Actually, hugetlb_register_node() also called, via a function pointer that hugetlb registers with the sysfs node driver, when a node is hot plugged. So, I think the correct approach is to remove the '__init' from hugetlb_sysfs_add_hstate() as this is also used at runtime. I missed this in the original submittal.

Regards,
Lee Schermerhorn

Quoted 28 lines

Signed-off-by Jeff Mahoney <[email protected]>

---
 mm/hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

mm/hugetlb.c +2 -2

@@ -1630,7 +1630,7 @@ void hugetlb_unregister_node(struct node
  * hugetlb module exit:  unregister hstate attributes from node sysdevs
  * that have them.
  */
-static void hugetlb_unregister_all_nodes(void)
+static void __init hugetlb_unregister_all_nodes(void)
 {
 	int nid;
 

@@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes
  * Register hstate attributes for a single node sysdev.
  * No-op if attributes already registered.
  */
-void hugetlb_register_node(struct node *node)
+void __init hugetlb_register_node(struct node *node)
 {
 	struct hstate *h;
 	struct node_hstate *nhs = &node_hstates[node->sysdev.id];

Quoted 5 lines

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

acpi_early_processor_set_pdc uses processor_idle_dmi_table, which is marked __cpuinitdata. It's only called by acpi_bus_init, which is __init. We mark it __cpuinit.

Signed-off-by Jeff Mahoney <[email protected]>

---
 drivers/acpi/processor_pdc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/acpi/processor_pdc.c +1 -1

@@ -151,7 +151,7 @@ early_init_pdc(acpi_handle handle, u32 l
 	return AE_OK;
 }
 
-void acpi_early_processor_set_pdc(void)
+void __cpuinit acpi_early_processor_set_pdc(void)
 {
 	/*
 	 * Check whether the system is DMI table. If yes, OSPM

This patch fixes the following warnings by renaming the driver structures to be suffixed with _driver.

WARNING: drivers/virtio/virtio_balloon.o(.data+0x88): Section mismatch in reference from the variable virtio_balloon to the function .devexit.text:virtballoon_remove()

WARNING: drivers/char/hw_random/virtio-rng.o(.data+0x88): Section mismatch in reference from the variable virtio_rng to the function .devexit.text:virtrng_remove()

Signed-off-by Jeff Mahoney <[email protected]>

Quoted 5 lines · Jeff Mahoney

This patch fixes the following warnings by renaming the driver structures to be suffixed with _driver.

WARNING: drivers/virtio/virtio_balloon.o(.data+0x88): Section mismatch in reference from the variable virtio_balloon to the function .devexit.text:virtballoon_remove()

Quoted 3 lines

WARNING: drivers/char/hw_random/virtio-rng.o(.data+0x88): Section mismatch in reference from the variable virtio_rng to the function .devexit.text:virtrng_remove()

Signed-off-by Jeff Mahoney <[email protected]>

Acked-by Rusty Russell <[email protected]>

Andrew, will you take these?

Quoted 12 lines · On Wed, 13 Jan 2010 21:27:26 +1030 Rusty Russell <[email protected]> wrote:

Quoted 8 lines · Jeff Mahoney

This patch fixes the following warnings by renaming the driver structures to be suffixed with _driver.

WARNING: drivers/virtio/virtio_balloon.o(.data+0x88): Section mismatch in reference from the variable virtio_balloon to the function .devexit.text:virtballoon_remove()

WARNING: drivers/char/hw_random/virtio-rng.o(.data+0x88): Section mismatch in reference from the variable virtio_rng to the function .devexit.text:virtrng_remove()

Signed-off-by Jeff Mahoney <[email protected]>

Acked-by Rusty Russell <[email protected]>

Quoted 2 lines

Andrew, will you take these?

umm, sure. But I wish I knew how the patch worked. Is there some magic sauce which moves a variable called foo_driver into a different section or what?

And if so, what was I doing when that got done :(