Skip to contentSkip to conversation

ARM: SAMSUNG: Add system.h file

PATCH New Kukjin Kim 2 participants 4 messages Jan 14, 2010

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: Add system.h file

This patch adds system.h file into plat-samsung.

Signed-off-by Kukjin Kim <[email protected]>
---
 arch/arm/plat-samsung/include/mach/system.h |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-samsung/include/mach/system.h
arch/arm/plat-samsung/include/mach/system.h new file +26 -0
new file mode 100644
index 0000000..596fe8d
@@ -0,0 +1,26 @@
+/* linux/arch/arm/plat-samsung/include/mach/system.h
+ *
+ * Copyright (c) 2009 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com/
+ *
+ * Idle support
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __ASM_PLAT_SYSTEM_H
+#define __ASM_PLAT_SYSTEM_H __FILE__
+
+static void arch_idle(void)
+{
+	/* nothing here yet */
+}
+
+static void arch_reset(char mode, const char *cmd)
+{
+	/* nothing here yet */
+}
+
+#endif /* __ASM_PLAT_SYSTEM_H */
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/1 ARM: SAMSUNG: Add system.h file

Quoted 30 lines · Kukjin Kim

This patch adds system.h file into plat-samsung.

Signed-off-by Kukjin Kim <[email protected]>
---
 arch/arm/plat-samsung/include/mach/system.h |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-samsung/include/mach/system.h
arch/arm/plat-samsung/include/mach/system.h new file +16 -0
new file mode 100644
index 0000000..596fe8d
@@ -0,0 +1,26 @@
+/* linux/arch/arm/plat-samsung/include/mach/system.h
+ *
+ * Copyright (c) 2009 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com/
+ *
+ * Idle support
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __ASM_PLAT_SYSTEM_H
+#define __ASM_PLAT_SYSTEM_H __FILE__
+
+static void arch_idle(void)

arch/arm/plat-samsung/include/mach/system.h line 26

Quoted 10 lines
arch/arm/plat-samsung/include/mach/system.h new file +10 -0
+{
+	/* nothing here yet */
+}
+
+static void arch_reset(char mode, const char *cmd)
+{
+	/* nothing here yet */
+}
+
+#endif /* __ASM_PLAT_SYSTEM_H */

ok, but at the moment this is only useful for the s5p6440,all the other <mach/system.h> implementations have something in them even it is just for arch_reset().

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/1 ARM: SAMSUNG: Add system.h file

In reply to Kukjin Kim
Quoted 1 line · Kukjin Kim

This patch adds system.h file into plat-samsung.

My worries here are that this is an empty file that is not currently useful for any of the extant Samsung SoC in-kernel implementations (they all have something in their own system.h files) and that if any of the new architectures decide they need arch_reset() then they may end up overriding this anyway.

Quoted 41 lines
Signed-off-by Kukjin Kim <[email protected]>
---
 arch/arm/plat-samsung/include/mach/system.h |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-samsung/include/mach/system.h
arch/arm/plat-samsung/include/mach/system.h new file +26 -0
new file mode 100644
index 0000000..596fe8d
@@ -0,0 +1,26 @@
+/* linux/arch/arm/plat-samsung/include/mach/system.h
+ *
+ * Copyright (c) 2009 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com/
+ *
+ * Idle support
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __ASM_PLAT_SYSTEM_H
+#define __ASM_PLAT_SYSTEM_H __FILE__
+
+static void arch_idle(void)
+{
+	/* nothing here yet */
+}
+
+static void arch_reset(char mode, const char *cmd)
+{
+	/* nothing here yet */
+}
+
+#endif /* __ASM_PLAT_SYSTEM_H */
Signature · 1 line
1.6.2.5
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
author
#3 lore raw

PATCH 1/1 ARM: SAMSUNG: Add system.h file

Quoted 8 lines · Ben Dooks
Quoted 1 line · Kukjin Kim

This patch adds system.h file into plat-samsung.

My worries here are that this is an empty file that is not currently useful for any of the extant Samsung SoC in-kernel implementations (they all have something in their own system.h files) and that if any of the new architectures decide they need arch_reset() then they may end up overriding this anyway.

Hi Ben,

Thanks for your comments.
The system.h file is moved to mach-s5p6440/include/mach, in my [PATCH v5 1/8 RE-SEND] patch.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, System LSI Division, SAMSUNG ELECTRONICS CO., LTD.