Skip to contentSkip to conversation

hwmon/amc6821: double unlock bug

PATCH In review Dan Carpenter 2 participants 2 messages Jan 14, 2010 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon/amc6821: double unlock bug

The mutex gets unlocked after we goto EXIT.

drivers/hwmon/amc6821.c +0 -1
@@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
 		data->fan1_div = 4;
 		break;
 	default:
-		mutex_unlock(&data->update_lock);
 		count = -EINVAL;
 		goto EXIT;
 	}

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw
Quoted 7 lines · Dan Carpenter

The mutex gets unlocked after we goto EXIT.

drivers/hwmon/amc6821.c static ssize_t set_fan1_div( · line 691

Quoted 7 lines
drivers/hwmon/amc6821.c +0 -1
@@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
 		data->fan1_div = 4;
 		break;
 	default:
-		mutex_unlock(&data->update_lock);
 		count = -EINVAL;
 		goto EXIT;
 	}

Good catch. Applied, thanks.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors