Skip to contentSkip to conversation

prio_tree.c: quiet sparse noise

PATCH In review H Hartley Sweeten 2 participants 3 messages Jan 14, 2010 – Jan 15, 2010 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 prio_tree.c: quiet sparse noise

prio_tree.c: quiet sparse noise

The function prio_tree_init is called during start_kernel. Since it is an __init function it is not exposed as an exported symbol. A sparse build produces the following warning because of this:

warning: symbol 'prio_tree_init' was not declared. Should it be static?

Quiet the warning by declaring the function as an extern before it's definition.

---

lib/prio_tree.c +3 -0
index ccfd850..a677200 100644
@@ -68,6 +68,9 @@ static void get_index(const struct prio_tree_root *root,
 
 static unsigned long index_bits_to_maxindex[BITS_PER_LONG];
 
+/* Keep sparse happy since this is not an EXPORT_SYMBOL */
+extern void prio_tree_init(void);
+
 void __init prio_tree_init(void)
 {
 	unsigned int i;
#1 lore raw
Quoted 11 lines · H Hartley Sweeten

prio_tree.c: quiet sparse noise

The function prio_tree_init is called during start_kernel. Since it is an __init function it is not exposed as an exported symbol. A sparse build produces the following warning because of this:

warning: symbol 'prio_tree_init' was not declared. Should it be static?

Quiet the warning by declaring the function as an extern before it's definition.

Why don't you add a declaration of prio_tree_init() to prio_tree.h, and let kernel/main.c include it?

Quoted 19 lines

---

lib/prio_tree.c +3 -1
index ccfd850..a677200 100644
@@ -68,6 +68,9 @@ static void get_index(const struct prio_tree_root *root,
 
 static unsigned long index_bits_to_maxindex[BITS_PER_LONG];
 
+/* Keep sparse happy since this is not an EXPORT_SYMBOL */
+extern void prio_tree_init(void);
+
 void __init prio_tree_init(void)
 {
 	unsigned int i;
--
#2 lore raw
Quoted 7 lines · Li Zefan
Quoted 6 lines · H Hartley Sweeten

prio_tree.c: quiet sparse noise

The function prio_tree_init is called during start_kernel. Since it is an __init function it is not exposed as an exported symbol. A sparse build produces the following warning because of this:

Quoted 8 lines
Quoted 5 lines

warning: symbol 'prio_tree_init' was not declared. Should it be static?

Quiet the warning by declaring the function as an extern before it's definition.

Why don't you add a declaration of prio_tree_init() to prio_tree.h, and let kernel/main.c include it?

I don't think that's a good idea.

Since the function is __init it will be reaped by free_initmem in init_post. If the function is exposed in the header someone might try to call it after than happens. My guess is that's a bad thing...

Maybe a new <linux/init_funcs.h> could be created that has a big fat warning about free_initmem? Then all the various init's could be declared to remove all the sparse warnings. These are the main ones I see in init/main.c but there are probably others:

extern void init_IRQ(void); <- arch specific
extern void fork_init(unsigned long); <- kernel/fork.c
extern void prio_tree_init(void); <- lib/prio_tree.c
extern void radix_tree_init(void); <- lib/radix-tree.c
extern void free_initmem(void); <- arch specific
extern void time_init(void); <- arch specific
extern void softirq_init(void); <- kernel/softirq.c

Regards,
Hartley

Quoted 12 lines
Quoted 12 lines

---

lib/prio_tree.c +0 -0
index ccfd850..a677200 100644
@@ -68,6 +68,9 @@ static void get_index(const struct prio_tree_root *root,
 
 static unsigned long index_bits_to_maxindex[BITS_PER_LONG];
 
Quoted 7 lines

lib/prio_tree.c static void get_index(const struct prio_tree_root *root,

Quoted 7 lines
lib/prio_tree.c +3 -1
+/* Keep sparse happy since this is not an EXPORT_SYMBOL */
+extern void prio_tree_init(void);
+
 void __init prio_tree_init(void)
 {
 	unsigned int i;
--

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�