Skip to contentSkip to conversation

: da.s_net not copied but assigned to itself in aarp_rcv()

PATCH Applied Roel Kluin 4 participants 5 messages Jan 14, 2010 – Jun 9, 2012

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 : da.s_net not copied but assigned to itself in aarp_rcv()

da.s_net was not copied but assigned to itself.

Signed-off-by Roel Kluin <[email protected]>

---

net/appletalk/aarp.c +1 -1
index 9d4adfd..f2b3b56 100644
@@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
 				ma = &ifa->address;
 			else { /* We need to make a copy of the entry. */
 				da.s_node = sa.s_node;
-				da.s_net = da.s_net;
+				da.s_net = sa.s_net;
 				ma = &da;
 			}
Acked-by on v1 1/1
#1 lore raw

Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:

Quoted 3 lines

da.s_net was not copied but assigned to itself.

Signed-off-by Roel Kluin <[email protected]>

Looks right, must be there for ages...

Acked-by Arnaldo Carvalho de Melo <[email protected]>
Quoted 14 lines

---

net/appletalk/aarp.c +1 -1
index 9d4adfd..f2b3b56 100644
@@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
 				ma = &ifa->address;
 			else { /* We need to make a copy of the entry. */
 				da.s_node = sa.s_node;
-				da.s_net = da.s_net;
+				da.s_net = sa.s_net;
 				ma = &da;
 			}
#3 lore raw

Hi Dave,

Quoted 5 lines · David Miller
Quoted 5 lines

Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:

Quoted 3 lines

da.s_net was not copied but assigned to itself.

Signed-off-by Roel Kluin <[email protected]>

[...]

Quoted 1 line

Applied, please always CC: on networking patches.

Thanks.

Without this patch (commit 2a04cd4c7 aka v2.6.33-rc6~29^2~33), Mason (cc-ed) is not able to use appletalk[1]:

| With Linux 2.6.32 as supplied with Debian Squeeze, Netatalk is unable
| to thrive. Connections made to afpd will open, but attempting to transfer
| files will take a very long time and/or eventually time out.
|
| I've noted this with both Netatalk as supplied with Squeeze and with
| Netatalk 2.2.1 built from the Wheezy source package, which I evidently
| need for AFP 3 support.
|
| Installing Linux 3.2 from backports, with no other changes to the system,
| allows afpd to work correctly.

Ben sent a copy of this patch to try against 2.6.32.y and it worked. Would it be possible to include this in the 2.6.32.y-longterm tree?

Sincerely,
Jonathan

[1] http://bugs.debian.org/660902

Acked-by Arnaldo Carvalho de Melo
#4 lore raw

[2.6.32.y] Re: [PATCH] appletalk:: da.s_net not copied but assigned to itself in aarp_rcv()

From: Roel Kluin <[email protected]>
Date: Fri, 15 Jan 2010 01:49:28 -0800
Subject: appletalk:: da.s_net not copied but assigned to itself in aarp_rcv()

commit 2a04cd4c7d41c4549764734dcf5a883d304e3229 upstream.

da.s_net was not copied but assigned to itself.

Signed-off-by Roel Kluin <[email protected]>
Acked-by Arnaldo Carvalho de Melo <[email protected]>
Signed-off-by David S. Miller <[email protected]>
Signed-off-by Jonathan Nieder <[email protected]>

---
(culling cc list)
Hi Willy,

Please consider

2a04cd4c7d41 appletalk:: da.s_net not copied bu assigned to itself
in aarp_rcv()

for application to the 2.6.32.y tree.

Without this patch, Mason (cc-ed) is not able to use appletalk[1]:

| With Linux 2.6.32 as supplied with Debian Squeeze, Netatalk is unable
| to thrive. Connections made to afpd will open, but attempting to transfer
| files will take a very long time and/or eventually time out.
|
| I've noted this with both Netatalk as supplied with Squeeze and with
| Netatalk 2.2.1 built from the Wheezy source package, which I evidently
| need for AFP 3 support.

Though this bug is very old. Presumably no one noticed because no one was using proxy-AARP.

The patch was merged upstream in 2.6.33-rc6. Mason tested it against Debian's 2.6.32.y-based kernel in March and found it to work, and the patch has been part of Debian's stable kernel since then without triggering any complaints.

Hope that helps,
Jonathan

[1] http://bugs.debian.org/660902

 net/appletalk/aarp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/appletalk/aarp.c +1 -1
index 9d4adfd22757..f2b3b56aa779 100644
@@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
 				ma = &ifa->address;
 			else { /* We need to make a copy of the entry. */
 				da.s_node = sa.s_node;
-				da.s_net = da.s_net;
+				da.s_net = sa.s_net;
 				ma = &da;
 			}
Signature · 1 line
1.7.10