Skip to contentSkip to conversation

Add -static earlier to LDFLAGS for compile_prog()

PATCH New Loïc Minier 1 participant 1 message Jan 17, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add -static earlier to LDFLAGS for compile_prog()

Hi

When configure qemu with --static, it might autodetect support for some features by looking at available shared libraries instead of static libraries. e.g. if you have libbluetooth.so, bluez support will be turned on, but the build will fail at link stage.

Setting LDFLAGS earlier to include -static will cause the compile_prog() tests to try to link against static libs. This did disable bluetooth support properly on my system where libbluetooth.a isn't available. Tested by building qemu configured with:

    ./configure --static --target-list=arm-softmmu,i386-softmmu,x86_64-softmmu,arm-linux-user,i386-linux-user,x86_64-linux-user

and again without --static.

Thanks,

Signature · 1 line
Loïc Minier
Quoted 1 line

From 3df135de4babc35849578cde901ef9ffb04a2ab3 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <[email protected]>
Date: Sun, 17 Jan 2010 12:43:21 +0100
Subject: [PATCH] Add -static earlier to LDFLAGS for compile_prog()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add -static to LDFLAGS earlier as to run the compile_prog() tests with this flags, this will avoid turning on features for which a shared library is available but not a static one.

---
 configure |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
configure +3 -2
index 5631bbb..e094111 100755
@@ -451,7 +451,9 @@ for opt do
   ;;
   --enable-gprof) gprof="yes"
   ;;
-  --static) static="yes"
+  --static)
+    static="yes"
+    LDFLAGS="-static $LDFLAGS"
   ;;
   --disable-sdl) sdl="no"
   ;;
@@ -1968,7 +1970,6 @@ if test "$solaris" = "yes" ; then
 fi
 if test "$static" = "yes" ; then
   echo "CONFIG_STATIC=y" >> $config_host_mak
-  LDFLAGS="-static $LDFLAGS"
 fi
 if test $profiler = "yes" ; then
   echo "CONFIG_PROFILER=y" >> $config_host_mak
Signature · 1 line
1.6.5