hwmon: (coretemp) Fix TjMax for Atom N450/D410/D510 CPUs
Subsystems (2)
PATCH 1/1 hwmon: (coretemp) Fix TjMax for Atom N450/D410/D510 CPUs
The max junction temperature of Atom N450/D410/D510 CPUs is 100 degrees Celsius. Since these CPUs are always coupled with Intel NM10 chipset in one package, the best way to verify whether an Atom CPU is N450/D410/D510 is to check the host bridge device.
--- drivers/hwmon/coretemp.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/hwmon/coretemp.c +14 -2
@@ -33,6 +33,7 @@#include <linux/list.h> #include <linux/platform_device.h> #include <linux/cpu.h> +#include <linux/pci.h> #include <asm/msr.h> #include <asm/processor.h>
@@ -161,6 +162,7 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device *int usemsr_ee =1 ;int err;u32 eax, edx; +struct pci_dev *host_bridge;/* Early chips have no MSR for TjMax */
@@ -168,11 +170,21 @@ static int __devinit adjust_tjmax(struct cpuinfo_x86 *c, u32 id, struct device * usemsr_ee =0 ; } -/* Atoms seems to have TjMax at 90C */ +/* Atoms CPUs */ if (c->x86_model ==0x1c ) { usemsr_ee =0 ; - tjmax =90000 ; + + host_bridge =pci_get_bus_and_slot (0 ,PCI_DEVFN (0 ,0 )); + +if (host_bridge && host_bridge->vendor ==PCI_VENDOR_ID_INTEL + && (host_bridge->device ==0xa000 /* NM10 based nettop */ + || host_bridge->device ==0xa010 ))/* NM10 based netbook */ + tjmax =100000 ; +else + tjmax =90000 ; + +pci_dev_put (host_bridge); }if ((c->x86_model >0xe ) && (usemsr_ee)) {
Jean Delvare
AppliedHi Yong,
Quoted 7 lines · Yong Wang
The max junction temperature of Atom N450/D410/D510 CPUs is 100 degrees Celsius. Since these CPUs are always coupled with Intel NM10 chipset in one package, the best way to verify whether an Atom CPU is N450/D410/D510 is to check the host bridge device.
Signed-off-by Yong Wang <[email protected]>Acked-by Huaxu Wan <[email protected]>
Applied, thanks. I've also added a Kconfig dependency on CONFIG_PCI.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 8 lines · Jean Delvare
Hi Yong,
Quoted 5 lines · Yong Wang
The max junction temperature of Atom N450/D410/D510 CPUs is 100 degrees Celsius. Since these CPUs are always coupled with Intel NM10 chipset in one package, the best way to verify whether an Atom CPU is N450/D410/D510 is to check the host bridge device.
Quoted 4 lines
Quoted 2 lines
Signed-off-by Yong Wang <[email protected]>Acked-by Huaxu Wan <[email protected]>Applied, thanks. I've also added a
Kconfigdependency onCONFIG_PCI.
Hmm. Thinking about it some more... What about nVidia-based systems? Can't we have systems with an Atom N450/D410/D510 and a non-Intel chipset?
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 5 lines · Jean Delvare
Hmm. Thinking about it some more... What about nVidia-based systems? Can't we have systems with an Atom N450/D410/D510 and a non-Intel chipset?
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
Thanks
-Yong
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 4 lines
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
To be more precise, Pine Trail Atoms integrate the entire northbridge, including the integrated graphics and the memory controller into the CPU, and there is a DMI connection to the southbridge, which is the Intel NM10, that is NOT integrated. Yuhong Bao
_________________________________________________________________
Hotmail: Free, trusted and rich email service.
http://clk.atdmt.com/GBL/go/196390708/direct/01/
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 5 lines · Yuhong Bao
Quoted 4 lines
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
To be more precise, Pine Trail Atoms integrate the entire northbridge, including the integrated graphics and the memory controller into the CPU, and there is a DMI connection to the southbridge, which is the Intel NM10, that is NOT integrated.
What prevents another vendor from selling a compatible south bridge then?
I start believing that we'd rather identify these Atom models using CPUID rather than a PCI device.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 9 lines · Jean Delvare
Quoted 5 lines · Yuhong Bao
Quoted 4 lines
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
To be more precise, Pine Trail Atoms integrate the entire northbridge, including the integrated graphics and the memory controller into the CPU, and there is a DMI connection to the southbridge, which is the Intel NM10, that is NOT integrated.
What prevents another vendor from selling a compatible south bridge then?
Nothing (other than licensing for the DMI bus, see NVIDIA and the problems this creates for their ION chipset). I'm assuming this patch is checking for the host bridge device though, that is integrated into the CPU and would always be present.
Quoted 4 lines
I start believing that we'd rather identify these Atom models using CPUID rather than a PCI device.
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 8 lines · Robert Hancock
Quoted 7 lines · Jean Delvare
Quoted 5 lines · Yuhong Bao
Quoted 4 lines
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
To be more precise, Pine Trail Atoms integrate the entire northbridge, including the integrated graphics and the memory controller into the CPU, and there is a DMI connection to the southbridge, which is the Intel NM10, that is NOT integrated.
Quoted 7 lines
Quoted 2 lines
What prevents another vendor from selling a compatible south bridge then?
Nothing (other than licensing for the DMI bus, see NVIDIA and the problems this creates for their ION chipset). I'm assuming this patch is checking for the host bridge device though, that is integrated into the CPU and would always be present.
That's where I am confused. The patch checks for the presence of the Intel NM10, which, reading its description looks much like a south bridge and not a memory controller (north bridge). So I think the patch is wrong (or at least incomplete).
Anyway, how difficult would it be to set TjMax based on the CPUID? I presume that the Intel Atom 400 and 500 series have their own CPUID value, haven't they? This would seem even easier that checking for a PCI device.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 8 lines · Jean Delvare
Quoted 7 lines · Robert Hancock
Quoted 6 lines · Jean Delvare
Quoted 5 lines · Yuhong Bao
Quoted 4 lines
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
To be more precise, Pine Trail Atoms integrate the entire northbridge, including the integrated graphics and the memory controller into the CPU, and there is a DMI connection to the southbridge, which is the Intel NM10, that is NOT integrated.
This is correct.
Quoted 9 lines
Quoted 8 lines
Quoted 3 lines
What prevents another vendor from selling a compatible south bridge then?
Nothing (other than licensing for the DMI bus, see NVIDIA and the problems this creates for their ION chipset). I'm assuming this patch is checking for the host bridge device though, that is integrated into the CPU and would always be present.
Quoted 5 lines
That's where I am confused. The patch checks for the presence of the Intel NM10, which, reading its description looks much like a south bridge and not a memory controller (north bridge). So I think the patch is wrong (or at least incomplete).
Sorry, I made a mistake in the patch description. The new Atom CPU is coupled with integrated gfx and memory controller in one package. NM10 chipset is another chip. This patch does check the presence of the integrated memory controller, i.e. 00:00.0 Host bridge device, which will always be present no matter whether NM10 chipset is used or not.
Quoted 5 lines
Anyway, how difficult would it be to set TjMax based on the CPUID? I presume that the Intel Atom 400 and 500 series have their own CPUID value, haven't they? This would seem even easier that checking for a PCI device.
CPUID value (family and model number) remains the same for all Atom CPUs thus far. That is why we check the new Atom CPU this way.
Thanks
-Yong
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 11 lines · Yong Wang
Quoted 4 lines · Jean Delvare
That's where I am confused. The patch checks for the presence of the Intel NM10, which, reading its description looks much like a south bridge and not a memory controller (north bridge). So I think the patch is wrong (or at least incomplete).
Sorry, I made a mistake in the patch description. The new Atom CPU is coupled with integrated gfx and memory controller in one package. NM10 chipset is another chip. This patch does check the presence of the integrated memory controller, i.e. 00:00.0 Host bridge device, which will always be present no matter whether NM10 chipset is used or not.
OK. Then indeed the patch description was rather bad. Even the comments in the code are misleading, they mention the NM10 when they don't really have to.
But at least if the code itself is OK... that's not that bad.
Quoted 7 lines
Quoted 4 lines
Anyway, how difficult would it be to set TjMax based on the CPUID? I presume that the Intel Atom 400 and 500 series have their own CPUID value, haven't they? This would seem even easier that checking for a PCI device.
CPUID value (family and model number) remains the same for all Atom CPUs thus far. That is why we check the new Atom CPU this way.
What about the stepping value? Don't these CPU models have their own?
Thanks,
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 24 lines · Jean Delvare
Quoted 11 lines · Yong Wang
Quoted 4 lines · Jean Delvare
That's where I am confused. The patch checks for the presence of the Intel NM10, which, reading its description looks much like a south bridge and not a memory controller (north bridge). So I think the patch is wrong (or at least incomplete).
Sorry, I made a mistake in the patch description. The new Atom CPU is coupled with integrated gfx and memory controller in one package. NM10 chipset is another chip. This patch does check the presence of the integrated memory controller, i.e. 00:00.0 Host bridge device, which will always be present no matter whether NM10 chipset is used or not.
OK. Then indeed the patch description was rather bad. Even the comments in the code are misleading, they mention the NM10 when they don't really have to.
But at least if the code itself is OK... that's not that bad.
Quoted 5 lines
Quoted 4 lines
Anyway, how difficult would it be to set TjMax based on the CPUID? I presume that the Intel Atom 400 and 500 series have their own CPUID value, haven't they? This would seem even easier that checking for a PCI device.
Quoted 5 lines
Quoted 2 lines
CPUID value (family and model number) remains the same for all Atom CPUs thus far. That is why we check the new Atom CPU this way.
What about the stepping value? Don't these CPU models have their own?
The stepping value is not architectually defined. Therefore, it is not the recommended way to detect CPU make and models.
Thanks
-Yong
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 22 lines · Jean Delvare
Quoted 8 lines · Robert Hancock
Quoted 7 lines · Jean Delvare
Quoted 5 lines · Yuhong Bao
Quoted 4 lines
No matter what chipset or gfx you use with the new Atom chip, the integrated memory controller (IMC) will always be used. This patch checks the presence of that IMC. Hope this clarifies.
To be more precise, Pine Trail Atoms integrate the entire northbridge, including the integrated graphics and the memory controller into the CPU, and there is a DMI connection to the southbridge, which is the Intel NM10, that is NOT integrated.
Quoted 7 lines
Quoted 2 lines
What prevents another vendor from selling a compatible south bridge then?
Nothing (other than licensing for the DMI bus, see NVIDIA and the problems this creates for their ION chipset). I'm assuming this patch is checking for the host bridge device though, that is integrated into the CPU and would always be present.
That's where I am confused. The patch checks for the presence of the Intel NM10, which, reading its description looks much like a south bridge and not a memory controller (north bridge). So I think the patch is wrong (or at least incomplete).
Quoted 4 lines
Anyway, how difficult would it be to set TjMax based on the CPUID? I presume that the Intel Atom 400 and 500 series have their own CPUID value, haven't they? This would seem even easier that checking for a PCI device.
Actually, all the Atom processors share the same CPUID(0x1C) and the worse is not all of them has the same TjMax. That's a big problem.
Thanks
Huaxu
Quoted 8 lines · Huaxu Wan
Quoted 4 lines · Jean Delvare
Anyway, how difficult would it be to set TjMax based on the CPUID? I presume that the Intel Atom 400 and 500 series have their own CPUID value, haven't they? This would seem even easier that checking for a PCI device.
Actually, all the Atom processors share the same CPUID(0x1C) and the worse is not all of them has the same TjMax. That's a big problem.
0x1C is the product value. The stepping value could be different. There could also be other identification methods based on cpuid() or rdmsr() commands. This is done quite frequently to identify specific CPU models.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors