Skip to contentSkip to conversation

NetStar: Remove debug junk leaked into eeprom utility

PATCH New Ladislav Michl 2 participants 4 messages Dec 30, 2009 – Jan 26, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NetStar: Remove debug junk leaked into eeprom utility

---
 board/netstar/eeprom.c       |    8 +--
 board/netstar/eeprom_start.S |  190 +++---------------------------------------
 2 files changed, 14 insertions(+), 184 deletions(-)

rewrite board/netstar/eeprom_start.S (94%)

board/netstar/eeprom.c +1 -7
index 1366457..adb01b9 100644
@@ -22,8 +22,6 @@
  * Some code shamelessly stolen back from Robin Getz.
  */
 
-#define DEBUG
-
 #include <common.h>
 #include <exports.h>
 #include <timestamp.h>
@@ -142,8 +140,6 @@ static int parse_element(char *s, unsigned char *buf, int len)
 	return cnt;
 }
 
-extern int crcek(void);
-
 int eeprom(int argc, char *argv[])
 {
 	int i, len, ret;
@@ -161,8 +157,6 @@ int eeprom(int argc, char *argv[])
 		return 1;
 	}
 
-	return crcek();
-
 	if ((SMC_inw (&dev, BANK_SELECT) & 0xFF00) != 0x3300) {
 		printf("SMSC91111 not found.\n");
 		return 2;
@@ -176,7 +170,7 @@ int eeprom(int argc, char *argv[])
 
 	/* Print help message */
 	if (argv[1][1] == 'h') {
-		printf("VoiceBlue EEPROM writer\n");
+		printf("NetStar EEPROM writer\n");
 		printf("Built: %s at %s\n", U_BOOT_DATE, U_BOOT_TIME);
 		printf("Usage:\n\t<mac_address> [<element_1>] [<...>]\n");
 		return 0;
board/netstar/eeprom_start.S +1 -165

171 lines not on this page · raw message

#1 lore raw

PATCH 1/1 NetStar: Remove debug junk leaked into eeprom utility

Dear Sandeep,

NetStar is OMAP based board and you are listed as OMAP maintainer, so one week before merge window closes I'd like to ask whenever there are any issues with patches I sent, which I should eventually resolve to get them merged.

Thank you,
ladis

#2 lore raw

PATCH 1/1 NetStar: Remove debug junk leaked into eeprom utility

In reply to Ladislav Michl

Dear u-boot custodians,

18 days since patches submission passed and there are less that 14 hrs till merge window closes. So this is yet another reminder for those pending patches. This board must be cursed, as I got silence only as reaction to every single patch posted. Interestingly enough, generic patches sent to this list are used to get merged. Perhaps it is time to come with some good conspiracy theory ;-)

Best regards,
ladis

#3 lore raw

PATCH 1/1 NetStar: Remove debug junk leaked into eeprom utility

In reply to Ladislav Michl
Quoted 10 lines

Subject: [PATCH] NetStar: Remove debug junk leaked into eeprom utility

---
 board/netstar/eeprom.c       |    8 +--
 board/netstar/eeprom_start.S |  190 +++----------------------------------

-----

Pushed to u-boot-ti.

Please give a patch description.

This time I copied the patch header.

Thanks,
Sandeep