b43: N-PHY: silence warnings, add missing call
PATCH v2 5/5 b43: N-PHY: silence warnings, add missing call
---
New patch I didn't include earlier.
--- drivers/net/wireless/b43/phy_n.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/b43/phy_n.c +3 -3
@@ -1624,7 +1624,7 @@ static void b43_nphy_tx_cal_phy_setup(struct b43_wldev *dev)b43_phy_write (dev,B43_NPHY_AFECTL_OVER , tmp |0x0600 ); regs[4 ] =b43_phy_read (dev,B43_NPHY_BBCFG ); -b43_phy_mask (dev,B43_NPHY_BBCFG , ~B43_NPHY_BBCFG_RSTRX ); +b43_phy_mask (dev,B43_NPHY_BBCFG , (u16 )~B43_NPHY_BBCFG_RSTRX ); tmp =b43_ntab_read (dev,B43_NTAB16 (8 ,3 )); regs[5 ] = tmp;
@@ -1970,7 +1970,7 @@ static int b43_nphy_rev2_cal_rx_iq(struct b43_wldev *dev,u16 lna[3 ] = {3 ,3 ,1 };u16 hpf1[3 ] = {7 ,2 ,0 };u16 hpf2[3 ] = {2 ,0 ,0 }; -u32 power[3 ]; +u32 power[3 ] = { };u16 gain_save[2 ];u16 cal_gain[2 ];struct nphy_iqcal_params cal_params[2 ];
@@ -2077,7 +2077,7 @@ static int b43_nphy_rev2_cal_rx_iq(struct b43_wldev *dev, (cur_lna << 2));/* TODO:Call N PHY RF Ctrl Override with 0x400, tmp[0], 3, 0 as arguments */ -/* TODO: Call N PHY Force RF Seq with 2 as argument */ +b43_nphy_force_rf_sequence (dev,B43_RFSEQ_RESET2RX );b43_nphy_stop_playback (dev);if (playtone) {
Signature · 1 line
1.6.4.2
Quoted 3 lines · Rafał Miłecki
Signed-off-by Rafał Miłecki <[email protected]>---
New patch I didn't include earlier.
Rafał,
I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using.
User-Agent: Opera Mail/10.10 (Linux)
The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually.
Learn to use "git send-email" or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this.
Thanks,
John
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
2010/1/19 John W. Linville <[email protected]>:
Quoted 18 lines · Rafał Miłecki
Quoted 3 lines
Signed-off-by Rafał Miłecki <[email protected]>---
New patch I didn't include earlier.Rafał,
I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using.
User-Agent: Opera Mail/10.10 (Linux)
The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually.
Quoted 5 lines
Learn to use "git send-email" or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this.
In case this helps:
http://wireless.kernel.org/en/developers/Documentation/git-guide#Sending_patches
Luis
W dniu 19 stycznia 2010 22:55 użytkownik John W. Linville
Quoted 18 lines · <[email protected]> napisał:
Quoted 3 lines · Rafał Miłecki
Signed-off-by Rafał Miłecki <[email protected]>---
New patch I didn't include earlier.Rafał,
I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using.
User-Agent: Opera Mail/10.10 (Linux)
The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually.
Quoted 5 lines
Learn to use "git send-email" or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this.
John, I strongly believe you know I'm new to whole kernel-related stuff. That just implies I make mistakes and ask simple questions but definitely I don't try to make your work harder on purpose. I already resend some of my first patches and after that no one hit issue you got with applying my patches.
I have all patches here locally, you could just ask me to resend them using other method. Didn't have to bother that effort you did and become angry.
Signature · 1 line
Rafał
W dniu 19 stycznia 2010 22:55 użytkownik John W. Linville
Quoted 18 lines · <[email protected]> napisał:
Quoted 3 lines · Rafał Miłecki
Signed-off-by Rafał Miłecki <[email protected]>---
New patch I didn't include earlier.Rafał,
I just applied this 5-patch series and the preceding 7-patch series, and I had to fixup every single one manually due to the apparently busted mailer you are using.
User-Agent: Opera Mail/10.10 (Linux)
The only reason I went to this trouble is because a) I want the N-phy stuff and b) you sent small, manageable patches. But don't misunderstand -- I have no intention of continuing to fix these manually.
Quoted 5 lines
Learn to use "git send-email" or find some other mailer to send your patches -- I recommend Mutt. In any case, do not expect your patches to get merged unless in the future unless you can rectify this situation at your end. I just don't have the bandwidth for dealing with crap like this.
Out of curiosity, could someone tell what Opera does incorrectly when sending patches?
Signature · 1 line
Rafał
Quoted 2 lines · On Tuesday 19 January 2010 23:59:32 Rafał Miłecki wrote:
Out of curiosity, could someone tell what Opera does incorrectly when sending patches?
They are base64 encoded.
We use a 7 or 8bit encoding for our mails.
I think that opera automatically switches to base64 encoding due to the special characters in your first and last name.
Signature · 1 line
Greetings, Michael.