vhost: fix TUN=m VHOST_NET=y
Subsystems (3)
Michael S. Tsirkin
maintainerPATCH 1/1 vhost: fix TUN=m VHOST_NET=y
drivers/built-in.o: In function `get_tun_socket':
net.c:(.text+0x15436e): undefined reference to `tun_get_socket'
If tun is a module, vhost must be a module, too. If tun is built-in or disabled, vhost can be built-in.
Note: TUN || !TUN might look a bit strange until you realize that boolean logic rules do not apply for tristate variables.
---
The above was already applied by Rusty, but got lost. The patch is on top of net-next.
drivers/vhost/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/vhost/Kconfig +1 -1
@@ -1,6 +1,6 @@ config VHOST_NET tristate "Host kernel accelerator for virtio net (EXPERIMENTAL)" - depends on NET && EVENTFD && EXPERIMENTAL + depends on NET && EVENTFD && (TUN || !TUN) && EXPERIMENTAL ---help--- This kernel module can be loaded in host kernel to accelerate guest networking with virtio_net. Not to be confused with virtio_net
Signature · 1 line
1.6.6.144.g5c3af
Quoted 11 lines · On Wed, 20 Jan 2010 13:30:38 +0200 Michael S. Tsirkin wrote:
drivers/built-in.o: In function `get_tun_socket':net.c:(.text+0x15436e): undefined reference to `tun_get_socket'If tun is a module, vhost must be a module, too. If tun is built-in or disabled, vhost can be built-in.
Note: TUN || !TUN might look a bit strange until you realize that boolean logic rules do not apply for tristate variables.
Reported-by Randy Dunlap <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>
Thanks.
Quoted 22 lines
---
The above was already applied by Rusty, but got lost. The patch is on top of net-next.
drivers/vhost/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/vhost/Kconfig +1
-1@@ -1,6 +1,6 @@ config VHOST_NET tristate "Host kernel accelerator for virtio net (EXPERIMENTAL)" - depends on NET && EVENTFD && EXPERIMENTAL + depends on NET && EVENTFD && (TUN || !TUN) && EXPERIMENTAL ---help--- This kernel module can be loaded in host kernel to accelerate guest networking with virtio_net. Not to be confused with virtio_netSignature · 1 line
1.6.6.144.g5c3af
---
~Randy
From: Randy Dunlap <[email protected]>
Date: Wed, 20 Jan 2010 08:49:10 -0800
Quoted 8 lines · On Wed, 20 Jan 2010 13:30:38 +0200 Michael S. Tsirkin wrote:
Quoted 7 lines
drivers/built-in.o: In function `get_tun_socket':net.c:(.text+0x15436e): undefined reference to `tun_get_socket'If tun is a module, vhost must be a module, too. If tun is built-in or disabled, vhost can be built-in.
Quoted 7 lines
Quoted 5 lines
Note: TUN || !TUN might look a bit strange until you realize that boolean logic rules do not apply for tristate variables.
Reported-by Randy Dunlap <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>Acked-by Randy Dunlap <[email protected]>
Applied to net-next-2.6, thanks!