omap: Enable GPMC clock in gpmc_init

Don't assume that gpmc_l3_clk is on, enable it before touching configuration registers.

index e86f5ca..dea72f3 100644
@@ -534,6 +534,8 @@ void __init gpmc_init(void)
 		BUG();
 	}
 
+	clk_enable(gpmc_l3_clk);
+
 	l = gpmc_read_reg(GPMC_REVISION);
 	printk(KERN_INFO "GPMC revision %d.%d\n", (l >> 4) & 0x0f, l & 0x0f);
 	/* Set smart idle mode and automatic L3 clock gating */

Seems like this is OK to do even though we do not disable it anywhere currently since we're setting smart idle and L3 autogating also in gpmc_init. So adding to omap-fixes.

Regards,

Tony

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): adbf7434abf0c710a5253438fd7a7d12db26272a

PatchWorks
http://patchwork.kernel.org/patch/74138/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=adbf7434abf0c710a5253438fd7a7d12db26272a

Hello Olof,

From: Paul Walmsley <[email protected]>
Date: Wed, 20 Jan 2010 18:16:18 -0700
Subject: [PATCH] OMAP GPMC: add fine-grained clock control

OMAP4 GPMC has a software-controllable GPMC clock gate, so, take advantage of it by only enabling the GPMC clock when needed. Since OMAP2xxx/3 don't have a separate software-controllable GPMC clock, this change should not affect these platforms, aside from slowing some of the gpmc.c functions down slightly.

Also rename "gpmc_l3_clk" to the more generic "gpmc_clk".

Since the GPMC clock is now enabled and disabled on demand, the ENABLE_ON_INIT clock flag can be removed from the GPMC clocks; do so.

While here, add some to-do items to the initial comment block.

Finally, add a gpmc_ocp_barrier() function, intended to ensure that all register writes to the GPMC are complete before disabling the GPMC clock. Barriers are added where they appear to be needed.

---
 arch/arm/mach-omap2/clock2xxx_data.c |    1 -
 arch/arm/mach-omap2/clock34xx_data.c |    1 -
 arch/arm/mach-omap2/gpmc.c           |   92 ++++++++++++++++++++++++++++------
 3 files changed, 76 insertions(+), 18 deletions(-)

index 97dc7cf..0997104 100644
@@ -1804,7 +1804,6 @@ static struct clk gpmc_fck = {
 	.name		= "gpmc_fck",
 	.ops		= &clkops_null, /* RMK: missing? */
 	.parent		= &core_l3_ck,
-	.flags		= ENABLE_ON_INIT,
 	.clkdm_name	= "core_l3_clkdm",
 	.recalc		= &followparent_recalc,
 };

index c6031d7..fab9e5b 100644
@@ -1654,7 +1654,6 @@ static struct clk gpmc_fck = {
 	.name		= "gpmc_fck",
 	.ops		= &clkops_null,
 	.parent		= &core_l3_ick,
-	.flags		= ENABLE_ON_INIT, /* huh? */
 	.clkdm_name	= "core_l3_clkdm",
 	.recalc		= &followparent_recalc,
 };

1.6.6.rc2.5.g49666

I forgot to mention, it applies on top of your patch.

- Paul