ARM: MX3: Fixed typo in declared enum type name.
Subsystems (3)
PATCH 1/1 ARM: MX3: Fixed typo in declared enum type name.
To distinguish between mx31lite and mx31lilly boards better to use different enum types.
--- arch/arm/plat-mxc/include/mach/board-mx31lite.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-mxc/include/mach/board-mx31lite.h +1 -1
@@ -25,7 +25,7 @@#ifndef __ASSEMBLY__ -enum mx31lilly_boards { +enum mx31lite_boards {MX31LITE_NOBOARD =0 ,MX31LITE_DB =1 , };
Signature · 1 line
1.6.5.4
PATCH 1/1 ARM: MX3: Fixed typo in declared enum type name.
Quoted 2 lines · Vladimir Zapolskiy
To distinguish between mx31lite and mx31lilly boards better to use different enum types.
True, even though it shouldn't have any impact unless you include both headers. I assume you didn't meet any real-life problem with that?
Quoted 1 line
Signed-off-by Vladimir Zapolskiy <[email protected]>
Quoted 20 lines
--- arch/arm/plat-mxc/include/mach/board-mx31lite.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-mxc/include/mach/board-mx31lite.h +1
-1@@ -25,7 +25,7 @@#ifndef __ASSEMBLY__ -enum mx31lilly_boards { +enum mx31lite_boards {MX31LITE_NOBOARD =0 ,MX31LITE_DB =1 , };Signature · 1 line
1.6.5.4
PATCH 1/1 ARM: MX3: Fixed typo in declared enum type name.
According to this issue I have not met problems with mx31lite board, surely that's just a typo. Anyway I plan to continue to work with this board setup for a while and make some tests of the recent changes found in 2.6.33.
Quoted 33 lines · Daniel Mack
Quoted 2 lines · Vladimir Zapolskiy
To distinguish between mx31lite and mx31lilly boards better to use different enum types.
True, even though it shouldn't have any impact unless you include both headers. I assume you didn't meet any real-life problem with that?
Quoted 1 line
Signed-off-by Vladimir Zapolskiy <[email protected]>Acked-by Daniel Mack <[email protected]>Quoted 20 lines
---
?arch/arm/plat-mxc/include/mach/board-mx31lite.h | ? ?2 +- ?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-mxc/include/mach/board-mx31lite.h +0
-0@@ -25,7 +25,7 @@?#ifndef
__ASSEMBLY__arch/arm/plat-mxc/include/mach/board-mx31lite.h +1
-1-enum mx31lilly_boards { +enum mx31lite_boards {? ? ?
MX31LITE_NOBOARD? ? ? ?= 0,
? ? ?MX31LITE_DB? ? ? ? ? ? = 1,
?};
--
1.6.5.4
PATCH 1/1 ARM: MX3: Fixed typo in declared enum type name.
Quoted 4 lines · Vladimir Zapolskiy
According to this issue I have not met problems with mx31lite board, surely that's just a typo. Anyway I plan to continue to work with this board setup for a while and make some tests of the recent changes found in 2.6.33.
Good to hear, more testing is certainly needed.
Thanks,
Daniel
Quoted 39 lines · Daniel Mack
Quoted 24 lines · Vladimir Zapolskiy
Quoted 2 lines
To distinguish between mx31lite and mx31lilly boards better to use different enum types.
True, even though it shouldn't have any impact unless you include both headers. I assume you didn't meet any real-life problem with that?
Quoted 1 line
Signed-off-by Vladimir Zapolskiy <[email protected]>Acked-by Daniel Mack <[email protected]>Quoted 12 lines
---
?arch/arm/plat-mxc/include/mach/board-mx31lite.h | ? ?2 +- ?1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-mxc/include/mach/board-mx31lite.h +0
-0@@ -25,7 +25,7 @@?#ifndef
__ASSEMBLY__Quoted 9 lines
Quoted 8 lines
arch/arm/plat-mxc/include/mach/board-mx31lite.h +1
-1-enum mx31lilly_boards { +enum mx31lite_boards {? ? ?
MX31LITE_NOBOARD? ? ? ?= 0,
? ? ?MX31LITE_DB? ? ? ? ? ? = 1,
?};
--
1.6.5.4_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sascha Hauer
maintainerPATCH 1/1 ARM: MX3: Fixed typo in declared enum type name.
In reply to Vladimir ZapolskiyQuoted 4 lines · Vladimir Zapolskiy
To distinguish between mx31lite and mx31lilly boards better to use different enum types.
Signed-off-by Vladimir Zapolskiy <[email protected]>
Ok, scheduled for -rc.
Sascha
Quoted 21 lines
--- arch/arm/plat-mxc/include/mach/board-mx31lite.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-mxc/include/mach/board-mx31lite.h +1
-1@@ -25,7 +25,7 @@#ifndef __ASSEMBLY__ -enum mx31lilly_boards { +enum mx31lite_boards {MX31LITE_NOBOARD =0 ,MX31LITE_DB =1 , };Signature · 1 line
1.6.5.4
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |