xfstests: fix format string warnings in locktest.c

Signed-off-by Christoph Hellwig <[email protected]>

Index: xfstests-dev/src/locktest.c
===================================================================

src/locktest.c +2 -2

@@ -741,7 +741,7 @@ send_ctl(void)
         if (nwrite < 0)
             perror("send_ctl: write");
         else
-            fprintf(stderr, "send_ctl[%d]: write() returns %d, not %lu as expected\n",
+            fprintf(stderr, "send_ctl[%d]: write() returns %d, not %zu as expected\n",
                     ctl.test, nwrite, sizeof(ctl));
         exit(1);
         /*NOTREACHED*/

@@ -756,7 +756,7 @@ void recv_ctl(void)
         if (nread < 0)
             perror("recv_ctl: read");
         else {
-            fprintf(stderr, "recv_ctl[%d]: read() returns %d, not %lu as expected\n",
+            fprintf(stderr, "recv_ctl[%d]: read() returns %d, not %zu as expected\n",
                     ctl.test, nread, sizeof(ctl));
 	    fprintf(stderr, "socket might has been closed by other locktest\n");
 	}

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Quoted 1 line · Christoph Hellwig

Signed-off-by Christoph Hellwig <[email protected]>

Looks good.

Reviewed-by Alex Elder <[email protected]>

Quoted 21 lines

Index: xfstests-dev/src/locktest.c
===================================================================

src/locktest.c +2 -2

@@ -741,7 +741,7 @@ send_ctl(void)
         if (nwrite < 0)
             perror("send_ctl: write");
         else
-            fprintf(stderr, "send_ctl[%d]: write() returns %d, not %lu as expected\n",
+            fprintf(stderr, "send_ctl[%d]: write() returns %d, not %zu as expected\n",
                     ctl.test, nwrite, sizeof(ctl));          exit(1);
         /*NOTREACHED*/

@@ -756,7 +756,7 @@ void recv_ctl(void)
         if (nread < 0)
             perror("recv_ctl: read");
         else {
-            fprintf(stderr, "recv_ctl[%d]: read() returns %d, not %lu as expected\n",
+            fprintf(stderr, "recv_ctl[%d]: read() returns %d, not %zu as expected\n",
                     ctl.test, nread, sizeof(ctl));
 	    fprintf(stderr, "socket might has been closed by other locktest\n");  	}
 

Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Quoted 6 lines · Alex Elder

Quoted 1 line · Christoph Hellwig

Signed-off-by Christoph Hellwig <[email protected]>

Looks good.

Reviewed-by Alex Elder <[email protected]>

By the way, the content of this patch is already incorporated in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c".
http://patchwork.xfs.org/patch/517/

Quoted 8 lines · Alex Elder

Quoted 6 lines · Alex Elder

Quoted 1 line · Christoph Hellwig

Signed-off-by Christoph Hellwig <[email protected]>

Looks good.

Reviewed-by Alex Elder <[email protected]>

Quoted 3 lines

By the way, the content of this patch is already incorporated in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c".
http://patchwork.xfs.org/patch/517/

Dave fixed the warnings not quite correctly, he switched from %d which was totally wrong to %lu which is only correct on some 64-bit architectures. %zd is the really correct format.

Ah, yes, you are correct. So the right fix is a combination of the two patches. All I noticed was that when I tried to apply your patch on top of Dave's it didn't work...