Skip to contentSkip to conversation

ppc4xx: Fix sending type 1 PCI transactions

PATCH New Felix Radensky 2 participants 3 messages Jan 22, 2010 – Jan 23, 2010 PCI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ppc4xx: Fix sending type 1 PCI transactions

The list of 4xx SoCs that should send type 1 PCI transactions is not defined correctly. As a result PCI-PCI bridges and devices behind them are not identified. The following 4xx variants should send type 1 transactions: 440GX, 440GP, 440SP, 440SPE, 460EX and 460GT.

---
v2: Removed 460SX from the list, it has no PCI controller.
Fixed commit message

 drivers/pci/pci_indirect.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/pci/pci_indirect.c +2 -1
index ab51f8d..2070d01 100644
@@ -59,7 +59,8 @@ indirect_##rw##_config_##size(struct pci_controller *hose,               \
 	cfg_##rw(val, hose->cfg_data + (offset & mask), type, op);       \
 	return 0;                                                        \
 }
-#elif defined(CONFIG_440GX) || defined(CONFIG_440EP) || defined(CONFIG_440GR) || defined(CONFIG_440SPE)
+#elif defined(CONFIG_440GX)  || defined(CONFIG_440GP) || defined(CONFIG_440SP) || \
+      defined(CONFIG_440SPE) || defined(CONFIG_460EX) || defined(CONFIG_460GT)
 #define INDIRECT_PCI_OP(rw, size, type, op, mask)			 \
 static int								 \
 indirect_##rw##_config_##size(struct pci_controller *hose,		 \
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH v2 1/1 ppc4xx: Fix sending type 1 PCI transactions

Quoted 9 lines · On Saturday 23 January 2010 00:35:24 Felix Radensky wrote:

The list of 4xx SoCs that should send type 1 PCI transactions is not defined correctly. As a result PCI-PCI bridges and devices behind them are not identified. The following 4xx variants should send type 1 transactions: 440GX, 440GP, 440SP, 440SPE, 460EX and 460GT.

---
v2: Removed 460SX from the list, it has no PCI controller.
Fixed commit message

Ups. I already applied the first version of this patch. Will remove this again and take this one instead. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#2 lore raw

PATCH v2 1/1 ppc4xx: Fix sending type 1 PCI transactions

In reply to Felix Radensky
Quoted 9 lines · On Saturday 23 January 2010 00:35:24 Felix Radensky wrote:

The list of 4xx SoCs that should send type 1 PCI transactions is not defined correctly. As a result PCI-PCI bridges and devices behind them are not identified. The following 4xx variants should send type 1 transactions: 440GX, 440GP, 440SP, 440SPE, 460EX and 460GT.

---
v2: Removed 460SX from the list, it has no PCI controller.
Fixed commit message

Applied to u-boot-ppc4xx/master. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de