Skip to contentSkip to conversation

sysfs_ops show vector: size of buffer not required?

DISCUSSION Himanshu Chauhan 3 participants 5 messages Jan 24, 2010 – Jan 26, 2010

lore
Share & tools
lore
#0 lore raw

Hi All,

The sysfs_ops's show vector doesn't have a size of the buffer given to the vector, while store on the other hand has. What is the rationale behind it?

I see most of the implementations doing strcpy in the show vectors. Ill behaved driver might overwrite the given buffer when size is not known. Should this be addressed by providing the buffer size along with the buffer pointer?

Thanks

Best Regards
Himanshu

#1 lore raw
Quoted 5 lines · Himanshu Chauhan

Hi All,

The sysfs_ops's show vector doesn't have a size of the buffer given to the vector, while store on the other hand has. What is the rationale behind it?

If you need to check the size, you are doing something wrong.

Seriously, that is the reason. A sysfs file should be a single value, which will never overflow the buffer.

Quoted 4 lines

I see most of the implementations doing strcpy in the show vectors. Ill behaved driver might overwrite the given buffer when size is not known. Should this be addressed by providing the buffer size along with the buffer pointer?

Nope.

Again, a single value only, it easily fits into the buffer size.

thanks,

greg k-h

#2 lore raw
Quoted 12 lines · Greg KH
Quoted 5 lines · Himanshu Chauhan

Hi All,

The sysfs_ops's show vector doesn't have a size of the buffer given to the vector, while store on the other hand has. What is the rationale behind it?

If you need to check the size, you are doing something wrong.

Seriously, that is the reason. A sysfs file should be a single value, which will never overflow the buffer.

I was talking in context of usb/ip's show_status. It writes a lot of data into this buffer. Which seems to over flow the buffer. But anyways, I will check if it can be reduced or at least be splitted into differnt device attributes.

BTW, Greg, Did you take a look at other patches I had sent? Are are worth or I need rework?

Regards
Himanshu

#3 lore raw
Quoted 8 lines · Himanshu Chauhan
Quoted 7 lines · Greg KH
Quoted 5 lines · Himanshu Chauhan

Hi All,

The sysfs_ops's show vector doesn't have a size of the buffer given to the vector, while store on the other hand has. What is the rationale behind it?

Quoted 7 lines
Quoted 5 lines

If you need to check the size, you are doing something wrong.

Seriously, that is the reason. A sysfs file should be a single value, which will never overflow the buffer.

I was talking in context of usb/ip's show_status. It writes a lot of data into this buffer.

Then it needs to be fixed. Again, it must be, one value per file, that is the sysfs rule.

Quoted 3 lines

Which seems to over flow the buffer. But anyways, I will check if it can be reduced or at least be splitted into differnt device attributes.

That would be great.

Quoted 2 lines

BTW, Greg, Did you take a look at other patches I had sent? Are are worth or I need rework?

They are in my "to-apply" queue that I will be flushing out in the next few days.

thanks,

greg k-h

#4 lore raw
Quoted 17 lines · Greg KH
Quoted 8 lines · Himanshu Chauhan
Quoted 7 lines · Greg KH
Quoted 5 lines · Himanshu Chauhan

Hi All,

The sysfs_ops's show vector doesn't have a size of the buffer given to the vector, while store on the other hand has. What is the rationale behind it?

Quoted 7 lines
Quoted 5 lines

If you need to check the size, you are doing something wrong.

Seriously, that is the reason. A sysfs file should be a single value, which will never overflow the buffer.

I was talking in context of usb/ip's show_status. It writes a lot of data into this buffer.

Quoted 8 lines

Then it needs to be fixed. Again, it must be, one value per file, that is the sysfs rule.

Quoted 3 lines

Which seems to over flow the buffer. But anyways, I will check if it can be reduced or at least be splitted into differnt device attributes.

That would be great.

Okay, I will do that.

Quoted 6 lines
Quoted 3 lines

BTW, Greg, Did you take a look at other patches I had sent? Are are worth or I need rework?

They are in my "to-apply" queue that I will be flushing out in the next few days.

Thanks Greg.

Regards
Himanshu