Skip to contentSkip to conversation

ARM: SAMSUNG: Fix null pointer dereference in ADC driver

PATCH New Maurus Cuelenaere 2 participants 2 messages Jan 22, 2010 – Jan 25, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Maurus Cuelenaere

author
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix null pointer dereference in ADC driver

ARM: SAMSUNG: Fix null pointer dereference in ADC driver

Use struct adc_device instead of relying on client (which could be NULL) when checking for SoC type.

Signed-off-by Maurus Cuelenaere <[email protected]>
---
 arch/arm/plat-samsung/adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-samsung/adc.c +1 -1
index 120b790..c7659b7 100644
@@ -295,7 +295,7 @@ static irqreturn_t s3c_adc_irq(int irq, void *pw)
 	}
 
 exit:
-	if (platform_get_device_id(client->pdev)->driver_data == TYPE_S3C64XX) {
+	if (platform_get_device_id(adc->pdev)->driver_data == TYPE_S3C64XX) {
 		/* Clear ADC interrupt */
 		writel(0, adc->regs + S3C64XX_ADCCLRINT);
 	}
Signature · 1 line
1.6.6.1
#1 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix null pointer dereference in ADC driver

Quoted 4 lines · Maurus Cuelenaere

ARM: SAMSUNG: Fix null pointer dereference in ADC driver

Use struct adc_device instead of relying on client (which could be NULL) when checking for SoC type.

ok, will apply this to next-samsung tree.

Quoted 25 lines
Signed-off-by Maurus Cuelenaere <[email protected]>
---
 arch/arm/plat-samsung/adc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-samsung/adc.c +1 -1
index 120b790..c7659b7 100644
@@ -295,7 +295,7 @@ static irqreturn_t s3c_adc_irq(int irq, void *pw)
 	}
 
 exit:
-	if (platform_get_device_id(client->pdev)->driver_data == TYPE_S3C64XX) {
+	if (platform_get_device_id(adc->pdev)->driver_data == TYPE_S3C64XX) {
 		/* Clear ADC interrupt */
 		writel(0, adc->regs + S3C64XX_ADCCLRINT);
 	}
Signature · 6 lines
1.6.6.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.