Skip to contentSkip to conversation

opensm/osm_qos.c: Eliminate unneeded endport SL to VL setup

PATCH Superseded Hal Rosenstock 3 participants 3 messages Jan 25, 2010 1 message not in the archive InfiniBand

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 opensm/osm_qos.c: Eliminate unneeded endport SL to VL setup

when using optimized programming and it's supported by the switch

Signed-off-by Hal Rosenstock <[email protected]>

---

opensm/opensm/osm_qos.c +6 -0
index 6bbbfa2..afa454f 100644
@@ -305,6 +305,12 @@ int osm_qos_setup(osm_opensm_t * p_osm)
 			    (&p_node->sw->switch_info))
 				continue;
 
+			if (ib_switch_info_get_opt_sl2vlmapping(&p_node->sw->switch_info) &&
+			    p_osm->sm.p_subn->opt.use_optimized_slvl &&
+			    !memcmp(&swe_config.sl2vl, &sw0_config.sl2vl,
+				    sizeof(swe_config.sl2vl)))
+				continue;
+
 			cfg = &sw0_config;
 		} else if (osm_node_get_type(p_node) == IB_NODE_TYPE_ROUTER)
 			cfg = &rtr_config;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi Hal,

Quoted 10 lines · Hal Rosenstock

when using optimized programming and it's supported by the switch

Signed-off-by Hal Rosenstock <[email protected]>

---

opensm/opensm/osm_qos.c +0 -0
index 6bbbfa2..afa454f 100644

opensm/opensm/osm_qos.c int osm_qos_setup(osm_opensm_t * p_osm) · line 313

Quoted 9 lines
opensm/opensm/osm_qos.c +6 -0
@@ -305,6 +305,12 @@ int osm_qos_setup(osm_opensm_t * p_osm)
 			    (&p_node->sw->switch_info))
 				continue;
 
+			if (ib_switch_info_get_opt_sl2vlmapping(&p_node->sw->switch_info) &&
+			    p_osm->sm.p_subn->opt.use_optimized_slvl &&
+			    !memcmp(&swe_config.sl2vl, &sw0_config.sl2vl,
+				    sizeof(swe_config.sl2vl)))
+				continue;
+

But then exports sl2vl tables setup loop should be changed starting from port '0' (not '1'), right?

Sasha

opensm/opensm/osm_qos.c int osm_qos_setup(osm_opensm_t * p_osm) · line 316

Quoted 4 lines
opensm/opensm/osm_qos.c +0 -0
 			cfg = &sw0_config;
 		} else if (osm_node_get_type(p_node) == IB_NODE_TYPE_ROUTER)
 			cfg = &rtr_config;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Hi Sasha,

Quoted 16 lines · Sasha Khapyorsky

Hi Hal,

Quoted 13 lines · Hal Rosenstock

when using optimized programming and it's supported by the switch

Signed-off-by Hal Rosenstock <[email protected]>

---

opensm/opensm/osm_qos.c +0 -0
index 6bbbfa2..afa454f 100644
@@ -305,6 +305,12 @@ int osm_qos_setup(osm_opensm_t * p_osm)
                           (&p_node->sw->switch_info))
                                continue;
Quoted 9 lines

opensm/opensm/osm_qos.c int osm_qos_setup(osm_opensm_t * p_osm) · line 313

Quoted 6 lines
opensm/opensm/osm_qos.c +6 -0
+                     if (ib_switch_info_get_opt_sl2vlmapping(&p_node->sw->switch_info) &&
+                         p_osm->sm.p_subn->opt.use_optimized_slvl &&
+                         !memcmp(&swe_config.sl2vl, &sw0_config.sl2vl,
+                                 sizeof(swe_config.sl2vl)))
+                             continue;
+

But then exports sl2vl tables setup loop should be changed starting from port '0' (not '1'), right?

Isn't it just that vlarb needs to be pushed for port 0 in that case (and not the sl2vl) ? Patch to follow.

-- Hal

Quoted 11 lines

Sasha

opensm/opensm/osm_qos.c int osm_qos_setup(osm_opensm_t * p_osm) · line 316

Quoted 4 lines
opensm/opensm/osm_qos.c +0 -0
                       cfg = &sw0_config;
               } else if (osm_node_get_type(p_node) == IB_NODE_TYPE_ROUTER)
                       cfg = &rtr_config;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html