x86, msr/cpuid: Pass the number of minors when unregistering MSR and CPUID drivers.
Subsystems (2)
Pass the number of minors when unregistering MSR and CPUID drivers.
Reported-by Dean Nelson <[email protected]>
Signed-off-by Dean Nelson <[email protected]>
Signed-off-by Russ Anderson <[email protected]>
---
While code reviewing the patch "x86, msr/cpuid: Register enough minors for the MSR and CPUID drivers", Dean noticed the number of minors not being passed when unregistering in the *_exit functions.
arch/x86/kernel/cpuid.c | 2 +- arch/x86/kernel/msr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpuid.c +1 -1
@@ -234,7 +234,7 @@ static void __exit cpuid_exit(void)for_each_online_cpu (cpu)cpuid_device_destroy (cpu);class_destroy (cpuid_class); -unregister_chrdev (CPUID_MAJOR ,"cpu/cpuid" ); +__unregister_chrdev (CPUID_MAJOR ,0 ,NR_CPUS ,"cpu/cpuid" );unregister_hotcpu_notifier (&cpuid_class_cpu_notifier); }
arch/x86/kernel/msr.c +1 -1
@@ -290,7 +290,7 @@ static void __exit msr_exit(void)for_each_online_cpu (cpu)msr_device_destroy (cpu);class_destroy (msr_class); -unregister_chrdev (MSR_MAJOR ,"cpu/msr" ); +__unregister_chrdev (MSR_MAJOR ,0 ,NR_CPUS ,"cpu/msr" );unregister_hotcpu_notifier (&msr_class_cpu_notifier); }
Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc [email protected]
Commit-ID: da482474b8396e1a099c37ffc6541b78775aedb4 Gitweb: http://git.kernel.org/tip/da482474b8396e1a099c37ffc6541b78775aedb4 Author: Russ Anderson <[email protected]> AuthorDate: Tue, 26 Jan 2010 20:37:22 -0600 Committer: H. Peter Anvin <[email protected]> CommitDate: Tue, 26 Jan 2010 23:52:38 -0800
x86, msr/cpuid: Pass the number of minors when unregistering MSR and CPUID drivers.
Pass the number of minors when unregistering MSR and CPUID drivers.
Reported-by Dean Nelson <[email protected]>
Signed-off-by Dean Nelson <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Russ Anderson <[email protected]>
Signed-off-by H. Peter Anvin <[email protected]>
--- arch/x86/kernel/cpuid.c | 2 +- arch/x86/kernel/msr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpuid.c +1 -1
@@ -229,7 +229,7 @@ static void __exit cpuid_exit(void)for_each_online_cpu (cpu)cpuid_device_destroy (cpu);class_destroy (cpuid_class); -unregister_chrdev (CPUID_MAJOR ,"cpu/cpuid" ); +__unregister_chrdev (CPUID_MAJOR ,0 ,NR_CPUS ,"cpu/cpuid" );unregister_hotcpu_notifier (&cpuid_class_cpu_notifier); }
arch/x86/kernel/msr.c +1 -1
@@ -285,7 +285,7 @@ static void __exit msr_exit(void)for_each_online_cpu (cpu)msr_device_destroy (cpu);class_destroy (msr_class); -unregister_chrdev (MSR_MAJOR ,"cpu/msr" ); +__unregister_chrdev (MSR_MAJOR ,0 ,NR_CPUS ,"cpu/msr" );unregister_hotcpu_notifier (&msr_class_cpu_notifier); }