ARM: S3C2443: GPIO: Correct AC97 pin defines
Subsystems (3)
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
--- arch/arm/mach-s3c2410/include/mach/regs-gpio.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-s3c2410/include/mach/regs-gpio.h +5 -5
@@ -406,31 +406,31 @@#define S3C2443_GPE5_SD1_CLK (0x02 << 10)#define S3C2400_GPE5_EINT5 (0x02 << 10)#define S3C2400_GPE5_TCLK1 (0x03 << 10) +#define S3C2443_GPE5_AC_BITCLK (0x03 << 10)#define S3C2410_GPE6_SDCMD (0x02 << 12)#define S3C2443_GPE6_SD1_CMD (0x02 << 12) -#define S3C2443_GPE6_AC_BITCLK (0x03 << 12) +#define S3C2443_GPE6_AC_SDI (0x03 << 12)#define S3C2400_GPE6_EINT6 (0x02 << 12)#define S3C2410_GPE7_SDDAT0 (0x02 << 14)#define S3C2443_GPE5_SD1_DAT0 (0x02 << 14) -#define S3C2443_GPE7_AC_SDI (0x03 << 14) +#define S3C2443_GPE7_AC_SDO (0x03 << 14)#define S3C2400_GPE7_EINT7 (0x02 << 14)#define S3C2410_GPE8_SDDAT1 (0x02 << 16)#define S3C2443_GPE8_SD1_DAT1 (0x02 << 16) -#define S3C2443_GPE8_AC_SDO (0x03 << 16) +#define S3C2443_GPE8_AC_SYNC (0x03 << 16)#define S3C2400_GPE8_nXDACK0 (0x02 << 16)#define S3C2410_GPE9_SDDAT2 (0x02 << 18)#define S3C2443_GPE9_SD1_DAT2 (0x02 << 18) -#define S3C2443_GPE9_AC_SYNC (0x03 << 18) +#define S3C2443_GPE9_AC_nRESET (0x03 << 18)#define S3C2400_GPE9_nXDACK1 (0x02 << 18)#define S3C2400_GPE9_nXBACK (0x03 << 18)#define S3C2410_GPE10_SDDAT3 (0x02 << 20)#define S3C2443_GPE10_SD1_DAT3 (0x02 << 20) -#define S3C2443_GPE10_AC_nRESET (0x03 << 20)#define S3C2400_GPE10_nXDREQ0 (0x02 << 20)#define S3C2410_GPE11_SPIMISO0 (0x02 << 22)
Signature · 1 line
1.6.2.5
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
Quoted 4 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
Ok, should I apply this to the fixes tree and send to linus?
Quoted 54 lines
Signed-off-by Jassi Brar <[email protected]>--- arch/arm/mach-s3c2410/include/mach/regs-gpio.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)arch/arm/mach-s3c2410/include/mach/regs-gpio.h +5
-5@@ -406,31 +406,31 @@#define S3C2443_GPE5_SD1_CLK (0x02 << 10)#define S3C2400_GPE5_EINT5 (0x02 << 10)#define S3C2400_GPE5_TCLK1 (0x03 << 10) +#define S3C2443_GPE5_AC_BITCLK (0x03 << 10)#define S3C2410_GPE6_SDCMD (0x02 << 12)#define S3C2443_GPE6_SD1_CMD (0x02 << 12) -#define S3C2443_GPE6_AC_BITCLK (0x03 << 12) +#define S3C2443_GPE6_AC_SDI (0x03 << 12)#define S3C2400_GPE6_EINT6 (0x02 << 12)#define S3C2410_GPE7_SDDAT0 (0x02 << 14)#define S3C2443_GPE5_SD1_DAT0 (0x02 << 14) -#define S3C2443_GPE7_AC_SDI (0x03 << 14) +#define S3C2443_GPE7_AC_SDO (0x03 << 14)#define S3C2400_GPE7_EINT7 (0x02 << 14)#define S3C2410_GPE8_SDDAT1 (0x02 << 16)#define S3C2443_GPE8_SD1_DAT1 (0x02 << 16) -#define S3C2443_GPE8_AC_SDO (0x03 << 16) +#define S3C2443_GPE8_AC_SYNC (0x03 << 16)#define S3C2400_GPE8_nXDACK0 (0x02 << 16)#define S3C2410_GPE9_SDDAT2 (0x02 << 18)#define S3C2443_GPE9_SD1_DAT2 (0x02 << 18) -#define S3C2443_GPE9_AC_SYNC (0x03 << 18) +#define S3C2443_GPE9_AC_nRESET (0x03 << 18)#define S3C2400_GPE9_nXDACK1 (0x02 << 18)#define S3C2400_GPE9_nXBACK (0x03 << 18)#define S3C2410_GPE10_SDDAT3 (0x02 << 20)#define S3C2443_GPE10_SD1_DAT3 (0x02 << 20) -#define S3C2443_GPE10_AC_nRESET (0x03 << 20)#define S3C2400_GPE10_nXDREQ0 (0x02 << 20)#define S3C2410_GPE11_SPIMISO0 (0x02 << 22)Signature · 7 lines
1.6.2.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
Quoted 7 lines · Ben Dooks
Quoted 4 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
Ok, should I apply this to the fixes tree and send to linus?
Honestly speaking, I don't know. Please do as you see due. Maybe Mark Brown, as an affected maintainer, has some opinion? thanks
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
Quoted 11 lines · jassi brar
Quoted 7 lines · Ben Dooks
Quoted 4 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
Ok, should I apply this to the fixes tree and send to linus?
Honestly speaking, I don't know. Please do as you see due. Maybe Mark Brown, as an affected maintainer, has some opinion? thanks
Ok, couple of questions:
1) Is it currently causing an working driver to fail?
2) Will it break anything currently in the kernel if merged now?
I'll await Mark's comments.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
Quoted 8 lines · Ben Dooks
Quoted 7 lines · jassi brar
Quoted 6 lines · Ben Dooks
Quoted 4 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Ok, should I apply this to the fixes tree and send to linus?
Honestly speaking, I don't know. Please do as you see due. Maybe Mark Brown, as an affected maintainer, has some opinion? thanks
Ok, couple of questions:
1) Is it currently causing an working driver to fail?
No.
Quoted 1 line
2) Will it break anything currently in the kernel if merged now?
No.
It is needed for the patch "ARM: S3C24XX: Update AC97 platform resources".
Quoted 1 line
I'll await Mark's comments.
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
In reply to jassi brarQuoted 10 lines · jassi brar
Quoted 7 lines · Ben Dooks
Quoted 4 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
Ok, should I apply this to the fixes tree and send to linus?
Honestly speaking, I don't know. Please do as you see due. Maybe Mark Brown, as an affected maintainer, has some opinion?
Might've wanted to CC me there... :) If they're just plain wrong then it should probably go to Linus, though equally well nobody's been complaining about it.
PATCH v2 1/10 ARM: S3C2443: GPIO: Correct AC97 pin defines
Quoted 8 lines · Mark Brown
Quoted 7 lines · jassi brar
Quoted 6 lines · Ben Dooks
Quoted 4 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
GPIO_E-[5,9] pin functionality was defined incorrectly. The patch corrects and adds missing pins.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Ok, should I apply this to the fixes tree and send to linus?
Honestly speaking, I don't know. Please do as you see due. Maybe Mark Brown, as an affected maintainer, has some opinion?
Might've wanted to CC me there... :) ?If they're just plain wrong then it should probably go to Linus, though equally well nobody's been complaining about it.
yes, I missed to cc u on the first patch by mistake.