ARM: S3C64XX: SPI: Make platform device compilation selectable
Subsystems (3)
PATCH v2 1/1 ARM: S3C64XX: SPI: Make platform device compilation selectable
From: Jassi Brar <[email protected]>
The SPI controller platform devices should be compiled in independent of the driver support, otherwise we might end up with dev-spi built as kernel module.
Change this to make every machine select if it has some SPI device and wants to build device definitions.
--- arch/arm/plat-s3c64xx/Makefile | 4 +++- arch/arm/plat-samsung/Kconfig | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletions(-)
arch/arm/plat-s3c64xx/Makefile +3 -1
@@ -40,6 +40,9 @@ obj-$(CONFIG_S3C64XX_DMA) += dma.o obj-$(CONFIG_S3C_ADC) += dev-adc.o +# SPI support +obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o + # Device setup obj-$(CONFIG_S3C64XX_SETUP_I2C0) += setup-i2c0.o
@@ -47,4 +50,3 @@ obj-$(CONFIG_S3C64XX_SETUP_I2C1) += setup-i2c1.o obj-$(CONFIG_S3C64XX_SETUP_FB_24BPP) += setup-fb-24bpp.o obj-$(CONFIG_S3C64XX_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o obj-$(CONFIG_SND_S3C24XX_SOC) += dev-audio.o -obj-$(CONFIG_SPI_S3C64XX) += dev-spi.o
arch/arm/plat-samsung/Kconfig +6 -0
@@ -132,6 +132,12 @@ config S3C_DEV_NAND help Compile in platform device definition for NAND controller +config S3C64XX_DEV_SPI + bool + help + Compile in platform device definitions for S3C64XX's type + SPI controllers. + comment "Power management" config SAMSUNG_PM_DEBUG
Signature · 1 line
1.6.2.5
PATCH v2 1/1 ARM: S3C64XX: SPI: Make platform device compilation selectable
Quoted 7 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
The SPI controller platform devices should be compiled in independent of the driver support, otherwise we might end up with dev-spi built as kernel module.
Change this to make every machine select if it has some SPI device and wants to build device definitions.
Ok, will look at applying either otnight or tomorrow.
Quoted 45 lines
Signed-off-by Jassi Brar <[email protected]>--- arch/arm/plat-s3c64xx/Makefile | 4 +++- arch/arm/plat-samsung/Kconfig | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletions(-)arch/arm/plat-s3c64xx/Makefile +3
-1@@ -40,6 +40,9 @@ obj-$(CONFIG_S3C64XX_DMA) += dma.o obj-$(CONFIG_S3C_ADC) += dev-adc.o +# SPI support +obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o + # Device setup obj-$(CONFIG_S3C64XX_SETUP_I2C0) += setup-i2c0.o@@ -47,4 +50,3 @@ obj-$(CONFIG_S3C64XX_SETUP_I2C1) += setup-i2c1.o obj-$(CONFIG_S3C64XX_SETUP_FB_24BPP) += setup-fb-24bpp.o obj-$(CONFIG_S3C64XX_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o obj-$(CONFIG_SND_S3C24XX_SOC) += dev-audio.o -obj-$(CONFIG_SPI_S3C64XX) += dev-spi.oarch/arm/plat-samsung/Kconfig +6
-0@@ -132,6 +132,12 @@ config S3C_DEV_NAND help Compile in platform device definition for NAND controller +config S3C64XX_DEV_SPI + bool + help + Compile in platform device definitions for S3C64XX's type + SPI controllers. + comment "Power management" config SAMSUNG_PM_DEBUGSignature · 1 line
1.6.2.5
Signature · 5 lines
-- Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH v2 1/1 ARM: S3C64XX: SPI: Make platform device compilation selectable
In reply to jassisinghbrar at gmail.comHello,
Quoted 40 lines · jassisinghbrar at gmail.com
From: Jassi Brar <[email protected]>
The SPI controller platform devices should be compiled in independent of the driver support, otherwise we might end up with dev-spi built as kernel module.
Change this to make every machine select if it has some SPI device and wants to build device definitions.Signed-off-by Jassi Brar <[email protected]>--- arch/arm/plat-s3c64xx/Makefile | 4 +++- arch/arm/plat-samsung/Kconfig | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletions(-)arch/arm/plat-s3c64xx/Makefile +3
-1@@ -40,6 +40,9 @@ obj-$(CONFIG_S3C64XX_DMA) += dma.o obj-$(CONFIG_S3C_ADC) += dev-adc.o +# SPI support +obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o + # Device setup obj-$(CONFIG_S3C64XX_SETUP_I2C0) += setup-i2c0.o@@ -47,4 +50,3 @@ obj-$(CONFIG_S3C64XX_SETUP_I2C1) += setup-i2c1.o obj-$(CONFIG_S3C64XX_SETUP_FB_24BPP) += setup-fb-24bpp.o obj-$(CONFIG_S3C64XX_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o obj-$(CONFIG_SND_S3C24XX_SOC) += dev-audio.o -obj-$(CONFIG_SPI_S3C64XX) += dev-spi.oarch/arm/plat-samsung/Kconfig +0
-0@@ -132,6 +132,12 @@ config S3C_DEV_NAND help Compile in platform device definition for NAND controller
arch/arm/plat-samsung/Kconfig config S3C_DEV_NAND · line 143
Quoted 10 lines
arch/arm/plat-samsung/Kconfig +6
-0+config S3C64XX_DEV_SPI + bool + help + Compile in platform device definitions for S3C64XX's type + SPI controllers. + comment "Power management" config SAMSUNG_PM_DEBUG
Is it correct that S3C64XX_DEV_SPI for now is always unselected and so dev-spi.o is never compiled? Assuming there are already machines using it the corresponding symbols should select S3C64XX_DEV_SPI, don't they?
If that's wrong the last sentence in your commit log is confusing.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH v2 1/1 ARM: S3C64XX: SPI: Make platform device compilation selectable
2010/1/28 Uwe Kleine-K?nig <[email protected]>:
Quoted 8 lines · jassisinghbrar at gmail.com
Quoted 7 lines
From: Jassi Brar <[email protected]>
The SPI controller platform devices should be compiled in independent of the driver support, otherwise we might end up with dev-spi built as kernel module.
Change this to make every machine select if it has some SPI device and wants to build device definitions.
Quoted 5 lines
Is it correct that
S3C64XX_DEV_SPIfor now is always unselected and so dev-spi.o is never compiled? ?Assuming there are already machines using it the corresponding symbols should selectS3C64XX_DEV_SPI, don't they?If that's wrong the last sentence in your commit log is confusing.
Hello,
No machine currently uses s3c64xx-spi, so it's ok.
In future a s3c64xx based machine has to select S3C64XX_DEV_SPI
if it has some device attached to the SPI bus.
PATCH v2 1/1 ARM: S3C64XX: SPI: Make platform device compilation selectable
Quoted 13 lines · jassi brar
2010/1/28 Uwe Kleine-K?nig <[email protected]>:
Quoted 12 lines · jassisinghbrar at gmail.com
Quoted 7 lines
From: Jassi Brar <[email protected]>
The SPI controller platform devices should be compiled in independent of the driver support, otherwise we might end up with dev-spi built as kernel module.
Change this to make every machine select if it has some SPI device and wants to build device definitions.Is it correct that
S3C64XX_DEV_SPIfor now is always unselected and so dev-spi.o is never compiled? ?Assuming there are already machines using it the corresponding symbols should selectS3C64XX_DEV_SPI, don't they?
Quoted 5 lines
Quoted 1 line
If that's wrong the last sentence in your commit log is confusing.
Hello,
No machine currently uses s3c64xx-spi, so it's ok.
In future a s3c64xx based machine has to selectS3C64XX_DEV_SPI
if it has some device attached to the SPI bus.
OK, then maybe change the commit log to:
The SPI controller platform devices should be compiled in independent of the driver support, otherwise we might end up with dev-spi built as kernel module.
So now every machine that has some SPI device should select S3C64XX_DEV_SPI. Currently there is no such machine in mainline yet.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |