Skip to contentSkip to conversation

New: Sending a 48bit ATA-Command with "CheckCondition" through SG_IO does not return correct 48bit sense descriptor

Bug 15185 [email protected] 2 participants 7 messages Jan 31, 2010 – Feb 9, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Summary: Sending a 48bit ATA-Command with "CheckCondition"
through SG_IO does not return correct 48bit sense descriptor
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.31
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Example: sending a correct "READ_NATIVE_MAX_ADDRESS_EXT" to /dev/sdd (opened O_RDWR | O_NONBLOCK) via ATA_PASSTHROUGH_16 (SCSI-Command 0x85) with the EXTEND and the CHECK_CONDITION bits set to 1 yields sense data in descriptor-format. Unfortunately, the descriptor does not have EXTEND set, and by that only returns 24 Bits of LBA.

This obviously is a bug, as the SAT-2 Draft says: "If the sense data is for an ATA PASS-THROUGH (16) command with the EXTEND bit set to one, then the SATL shall return the 48-bit extended status and shall set the EXTEND bit to one."

Contents of important data-structures for SG_IO:
sg_io_hdr.cmdlen = 16
*sg_io_hdr.cmdp = {0x85 0x07 0x20 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x27 0x00}

sense-data after command:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x00 0x00 0x00 0x00 0x00 0xaf 0x00 0x6d 0x00 0x70 0x00 0x50
meaning: descriptor-sense, no error
descriptor:
code=0x09 -> ATA-Return descriptor
length=0x0c
EXTEND=0
Error = 0x00
SectorCount = 0x00
LBA_Low = 0xaf
LBA_Mid = 0x6d
LBA_High= 0x70
Device = 0
Status = DeviceReady | DeferredWriteError

The drive used should be reporting a native max lba of 0x74706daf (1.02TB), so the expected sense data should look like:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x01 0x00 0x00 0x00 0x6d 0xaf 0x74 0x70 0x00 0x00 0x00 0x50

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#1 lore raw
Quoted 50 lines · [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Summary: Sending a 48bit ATA-Command with "CheckCondition"
through SG_IO does not return correct 48bit sense descriptor
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.31
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Example: sending a correct "READ_NATIVE_MAX_ADDRESS_EXT" to /dev/sdd (opened
O_RDWR | O_NONBLOCK) via ATA_PASSTHROUGH_16 (SCSI-Command 0x85) with the EXTEND
and the CHECK_CONDITION bits set to 1 yields sense data in descriptor-format. Unfortunately, the descriptor does not have EXTEND set, and by that only returns 24 Bits of LBA.

This obviously is a bug, as the SAT-2 Draft says: "If the sense data is for an ATA PASS-THROUGH (16) command with the EXTEND bit set to one, then the SATL shall return the 48-bit extended status and shall set the EXTEND bit to one."

Contents of important data-structures for SG_IO:
sg_io_hdr.cmdlen = 16
*sg_io_hdr.cmdp = {0x85 0x07 0x20 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x27 0x00}

sense-data after command:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x00 0x00 0x00 0x00 0x00 0xaf 0x00 0x6d 0x00 0x70 0x00 0x50
meaning: descriptor-sense, no error
descriptor:
code=0x09 -> ATA-Return descriptor
length=0x0c
EXTEND=0
Error = 0x00
SectorCount = 0x00
LBA_Low = 0xaf
LBA_Mid = 0x6d
LBA_High= 0x70
Device = 0
Status = DeviceReady | DeferredWriteError

Quoted 4 lines

The drive used should be reporting a native max lba of 0x74706daf (1.02TB), so the expected sense data should look like:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x01 0x00 0x00 0x00 0x6d 0xaf 0x74 0x70 0x00 0x00 0x00 0x50

This bug does not occur in lk 2.6.30 but does in lk 2.6.32 . There was a pretty large rework of libata in that period and there is obvious bug in drivers/ata/libata-scsi.c that causes this.

The attached patch fixes this problem in lk 2.6.32 in my test.

drivers/ata/libata-scsi.c2632dpg1 renamed from drivers/ata/libata-scsi.c +1 -1
@@ -2825,7 +2825,7 @@
 	 * write indication (used for PIO/DMA setup), result TF is
 	 * copied back and we don't whine too much about its failure.
 	 */
-	tf->flags = ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
+	tf->flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
 	if (scmd->sc_data_direction == DMA_TO_DEVICE)
 		tf->flags |= ATA_TFLAG_WRITE;
 
#2 lore raw
Quoted 61 lines · Douglas Gilbert
Quoted 50 lines · [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Summary: Sending a 48bit ATA-Command with "CheckCondition"
through SG_IO does not return correct 48bit sense descriptor
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.31
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Example: sending a correct "READ_NATIVE_MAX_ADDRESS_EXT" to /dev/sdd (opened
O_RDWR | O_NONBLOCK) via ATA_PASSTHROUGH_16 (SCSI-Command 0x85) with the EXTEND
and the CHECK_CONDITION bits set to 1 yields sense data in descriptor-format. Unfortunately, the descriptor does not have EXTEND set, and by that only returns 24 Bits of LBA.

This obviously is a bug, as the SAT-2 Draft says: "If the sense data is for an ATA PASS-THROUGH (16) command with the EXTEND bit set to one, then the SATL shall return the 48-bit extended status and shall set the EXTEND bit to one."

Contents of important data-structures for SG_IO:
sg_io_hdr.cmdlen = 16
*sg_io_hdr.cmdp = {0x85 0x07 0x20 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x27 0x00}

sense-data after command:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x00 0x00 0x00 0x00 0x00 0xaf 0x00 0x6d 0x00 0x70 0x00 0x50
meaning: descriptor-sense, no error
descriptor:
code=0x09 -> ATA-Return descriptor
length=0x0c
EXTEND=0
Error = 0x00
SectorCount = 0x00
LBA_Low = 0xaf
LBA_Mid = 0x6d
LBA_High= 0x70
Device = 0
Status = DeviceReady | DeferredWriteError

Quoted 4 lines

The drive used should be reporting a native max lba of 0x74706daf (1.02TB), so the expected sense data should look like:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x01 0x00 0x00 0x00 0x6d 0xaf 0x74 0x70 0x00 0x00 0x00 0x50

This bug does not occur in lk 2.6.30 but does in lk 2.6.32 . There was a pretty large rework of libata in that period and there is obvious bug in drivers/ata/libata-scsi.c that causes this.

Quoted 4 lines

The attached patch fixes this problem in lk 2.6.32 in my test.

Changelog:
- Fix assignment which overwrote SAT ATA PASS-THROUGH command EXTEND bit setting (ATA_TFLAG_LBA48)

#3 lore raw

[Bug 15185] Sending a 48bit ATA-Command with "CheckCondition" through SG_IO does not return correct 48bit sense descriptor

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=15185

--- Comment #1 from Anonymous Emailer <[email protected]> 2010-02-01 19:01:55 ---
Reply-To: [email protected]

Quoted 72 lines · Douglas Gilbert
Quoted 59 lines · [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Summary: Sending a 48bit ATA-Command with "CheckCondition"
through SG_IO does not return correct 48bit sense descriptor
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.31
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Example: sending a correct "READ_NATIVE_MAX_ADDRESS_EXT" to /dev/sdd (opened
O_RDWR | O_NONBLOCK) via ATA_PASSTHROUGH_16 (SCSI-Command 0x85) with the EXTEND
and the CHECK_CONDITION bits set to 1 yields sense data in descriptor-format. Unfortunately, the descriptor does not have EXTEND set, and by that only
returns 24 Bits of LBA.

This obviously is a bug, as the SAT-2 Draft says: "If the sense data is for an
ATA PASS-THROUGH (16) command with the EXTEND bit set to one, then the SATL
shall return the 48-bit extended status and shall set the EXTEND bit to one."

Contents of important data-structures for SG_IO:
sg_io_hdr.cmdlen = 16
*sg_io_hdr.cmdp = {0x85 0x07 0x20 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
0x00 0x00 0x27 0x00}

sense-data after command:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x00 0x00 0x00 0x00 0x00 0xaf
0x00 0x6d 0x00 0x70 0x00 0x50
meaning: descriptor-sense, no error
descriptor:
code=0x09 -> ATA-Return descriptor
length=0x0c
EXTEND=0
Error = 0x00
SectorCount = 0x00
LBA_Low = 0xaf
LBA_Mid = 0x6d
LBA_High= 0x70
Device = 0
Status = DeviceReady | DeferredWriteError

Quoted 6 lines

The drive used should be reporting a native max lba of 0x74706daf (1.02TB), so
the expected sense data should look like:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x01 0x00 0x00 0x00 0x6d 0xaf
0x74 0x70 0x00 0x00 0x00 0x50

This bug does not occur in lk 2.6.30 but does in lk 2.6.32 . There was a pretty large rework of libata in that period and there is obvious bug in drivers/ata/libata-scsi.c that causes this.

Quoted 4 lines

The attached patch fixes this problem in lk 2.6.32 in my test.

Changelog:
- Fix assignment which overwrote SAT ATA PASS-THROUGH command EXTEND bit setting (ATA_TFLAG_LBA48)

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#4 lore raw

[Bug 15185] Sending a 48bit ATA-Command with "CheckCondition" through SG_IO does not return correct 48bit sense descriptor

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=15185

--- Comment #2 from Anonymous Emailer <[email protected]> 2010-02-01 19:06:55 ---
Reply-To: [email protected]

Quoted 51 lines · [email protected] wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Summary: Sending a 48bit ATA-Command with "CheckCondition"
through SG_IO does not return correct 48bit sense descriptor
Product: SCSI Drivers
Version: 2.5
Kernel Version: 2.6.31
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [email protected]
ReportedBy: [email protected]
Regression: No

Example: sending a correct "READ_NATIVE_MAX_ADDRESS_EXT" to /dev/sdd (opened O_RDWR | O_NONBLOCK) via ATA_PASSTHROUGH_16 (SCSI-Command 0x85) with the EXTEND and the CHECK_CONDITION bits set to 1 yields sense data in descriptor-format. Unfortunately, the descriptor does not have EXTEND set, and by that only returns 24 Bits of LBA.

This obviously is a bug, as the SAT-2 Draft says: "If the sense data is for an ATA PASS-THROUGH (16) command with the EXTEND bit set to one, then the SATL shall return the 48-bit extended status and shall set the EXTEND bit to one."

Contents of important data-structures for SG_IO:
sg_io_hdr.cmdlen = 16
*sg_io_hdr.cmdp = {0x85 0x07 0x20 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x27 0x00}

sense-data after command:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x00 0x00 0x00 0x00 0x00 0xaf 0x00 0x6d 0x00 0x70 0x00 0x50
meaning: descriptor-sense, no error
descriptor:
code=0x09 -> ATA-Return descriptor
length=0x0c
EXTEND=0
Error = 0x00
SectorCount = 0x00
LBA_Low = 0xaf
LBA_Mid = 0x6d
LBA_High= 0x70
Device = 0
Status = DeviceReady | DeferredWriteError

Quoted 4 lines

The drive used should be reporting a native max lba of 0x74706daf (1.02TB), so the expected sense data should look like:
0x72 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x09 0x0c 0x01 0x00 0x00 0x00 0x6d 0xaf 0x74 0x70 0x00 0x00 0x00 0x50

This bug does not occur in lk 2.6.30 but does in lk 2.6.32 . There was a pretty large rework of libata in that period and there is obvious bug in drivers/ata/libata-scsi.c that causes this.

The attached patch fixes this problem in lk 2.6.32 in my test.

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
#5 lore raw

[Bug 15185] Sending a 48bit ATA-Command with "CheckCondition" through SG_IO does not return correct 48bit sense descriptor

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Stefan Hübner <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

     Kernel Version|2.6.31                      |2.6.32

--- Comment #3 from Stefan Hübner <[email protected]> 2010-02-01 21:22:04 --- Just to clear up: sorry, I forgot I recently updated to 2.6.32. Changed bug-description accordingly.

Signature · 6 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#6 lore raw

[Bug 15185] Sending a 48bit ATA-Command with "CheckCondition" through SG_IO does not return correct 48bit sense descriptor

In reply to [email protected]

http://bugzilla.kernel.org/show_bug.cgi?id=15185

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
          Component|Other                       |Serial ATA
         Resolution|                            |CODE_FIX
         AssignedTo|scsi_drivers-other@kernel-b |[email protected]
                   |ugs.osdl.org                |
            Product|SCSI Drivers                |IO/Storage

--- Comment #4 from Alan <[email protected]> 2010-02-09 16:13:13 --- commit bc496ed00ab1411d3efaf295b72e0c9eb343e1a3

Signature · 3 lines
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.