drivers/gpu/vga/vgaarb.c: fix userspace pointer dereference
Subsystems (2)
PATCH 1/2 drivers/gpu/vga/vgaarb.c: fix userspace pointer dereference
From: Andy Getzendanner <[email protected]>
This patch corrects a userspace pointer dereference in the VGA arbiter in 2.6.32.1.
copy_from_user() is used at line 822 to copy the contents of buf into kbuf, but a call to strncmp() on line 964 uses buf rather than kbuf. This problem led to a GPF in strncmp() when X was started on my x86_32 systems.
X triggered the behavior with a write of "target PCI:0000:01:00.0" to/dev/vga_arbiter.
The patch has been tested against 2.6.32.1 and observed to correct the GPF observed when starting X or manually writing the string "target PCI:0000:01:00.0" to /dev/vga_arbiter.
---
drivers/gpu/vga/vgaarb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/vga/vgaarb.c renamed from drivers/gpu/vga/vgaarb.c~drivers-gpu-vga-vgaarbc-fix-userspace-pointer-dereference +1 -1
@@ -961,7 +961,7 @@ static ssize_t vga_arb_write(struct file remaining -=7 ;pr_devel ("client 0x%p called 'target'\n" , priv);/* if target is default */ -if (!strncmp (buf,"default" ,7 )) +if (!strncmp (kbuf,"default" ,7 )) pdev =pci_dev_get (vga_default_device ()); else { if (!vga_pci_str_to_vars(curr_pos, remaining,
_
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--