dell_laptop: when the "hardware" switch is disabled, don't actually allow changing the softblock status.
Subsystems (2)
PATCH 1/7 dell_laptop: when the "hardware" switch is disabled, don't actually allow changing the softblock status.
From: Mario Limonciello <[email protected]>
The "hardware" switch is tied directly to a BIOS interface that will connect and disconnect the hardware from the bus.
If you use the software interface to request the BIOS to make these changes, the HW switch will be in an inconsistent state and LEDs may not reflect the state of the HW.
Signed-off-by Mario Limonciello <[email protected]>
Cc Matthew Garrett <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/platform/x86/dell-laptop.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/platform/x86/dell-laptop.c renamed from drivers/platform/x86/dell-laptop.c~dell_laptop-when-the-hardware-switch-is-disabled-dont-actually-allow-changing-the-softblock-status +4 -0
@@ -189,6 +189,10 @@ static int dell_rfkill_set(void *data, bunsigned long radio = (unsigned long )data;memset (&buffer,0 ,sizeof (struct calling_interface_buffer )); +dell_send_request (&buffer,17 ,11 ); +if (!(buffer.output[1 ] &BIT (16 ))) +return -EINVAL ; + buffer.input[0 ] = (1 | (radio<<8 ) | (disable <<16 ));dell_send_request (&buffer,17 ,11 );
_