powerpc: Sky CPU: redundant or incorrect tests on unsigned
PATCH 1/2 powerpc: Sky CPU: redundant or incorrect tests on unsigned
From: Roel Kluin <[email protected]>
count is unsigned and cannot be less than 0.
---
drivers/misc/hdpuftrs/hdpu_cpustate.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/misc/hdpuftrs/hdpu_cpustate.c renamed from drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned +0 -5
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file {unsigned char data; -if (count <0 ) -return -EFAULT ;if (count ==0 )return 0 ;
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil {unsigned char data; -if (count <0 ) -return -EFAULT ; -if (count ==0 )return 0 ;
_
Quoted 11 lines · On Tue, 2010-02-02 at 14:40 -0800, [email protected] wrote:
From: Roel Kluin <[email protected]>
count is unsigned and cannot be less than 0.
Signed-off-by Roel Kluin <[email protected]>Acked-by Cyrill Gorcunov <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Kumar Gala <[email protected]>Cc Brian Waite <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
I still have a hard time figuring out what this sky CPU actually is :-)
The whole drivers/misc/hdpuftrs is only built when CONFIG_HDPU_FEATURES is set and git grep HDPU_FEATURES doesn't show anybody ever setting it :-)
Is that just dead code ? I'm happy to carry it in powerpc.git if you wish so but you it would be nice to figure out what's going on there...
Cheers,
Ben.
Quoted 26 lines
drivers/misc/hdpuftrs/hdpu_cpustate.c | 5 ----- 1 file changed, 5 deletions(-)diff -puN
drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigneddrivers/misc/hdpuftrs/hdpu_cpustate.cdrivers/misc/hdpuftrs/hdpu_cpustate.c renamed from drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned +0
-5@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file {unsigned char data; -if (count <0 ) -return -EFAULT ;if (count ==0 )return 0 ;@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil {unsigned char data; -if (count <0 ) -return -EFAULT ; -if (count ==0 )return 0 ;_
To All:
The sky cpu is a PPC7448.
I'm actually amazed that you guys are still working on a problem for a product that was finished a number of years ago, at the request of someone who hasn't worked here for years. I sorry you, seem to have been wasting your time.
I think, but am NOT sure, that our HAA function sets it off.
http://www.skycomputers.com/Systems/HAA_HMM.php
Still, we have finished the product some time ago, and as far as reported have no problems. Again, I'm sorry you have wasted any time on this, we just recently found these emails.
Dave Bushee
Director OEM Sales and Services
SKY Computers Inc.
27 Industrial Ave.
978-250-2420 x232
www.skycomputers.com
----- Original Message ----- From: "Benjamin Herrenschmidt" <[email protected]>
To: <[email protected]>
Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Wednesday, February 03, 2010 6:21 PM
Subject: Re: [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests on unsigned
Quoted 55 lines · On Tue, 2010-02-02 at 14:40 -0800, [email protected] wrote:
Quoted 11 lines
From: Roel Kluin <[email protected]>
count is unsigned and cannot be less than 0.
Signed-off-by Roel Kluin <[email protected]>Acked-by Cyrill Gorcunov <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Kumar Gala <[email protected]>Cc Brian Waite <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
I still have a hard time figuring out what this sky CPU actually is :-)
The whole
drivers/misc/hdpuftrsis only built whenCONFIG_HDPU_FEATURESis set and git grepHDPU_FEATURESdoesn't show anybody ever setting it :-)Is that just dead code ? I'm happy to carry it in powerpc.git if you wish so but you it would be nice to figure out what's going on there...
Cheers,
Ben.Quoted 27 lines
drivers/misc/hdpuftrs/hdpu_cpustate.c | 5 ----- 1 file changed, 5 deletions(-)diff -puN
drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigneddrivers/misc/hdpuftrs/hdpu_cpustate.c
---
a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++a/drivers/misc/hdpuftrs/hdpu_cpustate.cdrivers/misc/hdpuftrs/hdpu_cpustate.c renamed from drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned +0
-5@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file {unsigned char data; -if (count <0 ) -return -EFAULT ;if (count ==0 )return 0 ;@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil {unsigned char data; -if (count <0 ) -return -EFAULT ; -if (count ==0 )return 0 ;_
Quoted 10 lines · support
The sky cpu is a PPC7448.
I'm actually amazed that you guys are still working on a problem for a
product that was finished a number of years ago, at the request of someone
who hasn't worked here for years.
I sorry you, seem to have been wasting your time.
I think, but am NOT sure, that our HAA function sets it off.
http://www.skycomputers.com/Systems/HAA_HMM.php
Quoted 6 lines
Still, we have finished the product some time ago, and as far as reported
have no problems.
Again, I'm sorry you have wasted any time on this, we just recently found
these emails.
Well, there seem to be some code in the Linux kernel related to that CPU that is either dead or incomplete. So if you guys have no interest in it, we might just rip it out completely.
Cheers,
Ben.
I doubt we'll be going to be using 7448's any more for future product lines.
Dave Bushee
Director OEM Sales and Services
SKY Computers Inc.
27 Industrial Ave.
978-250-2420 x232
www.skycomputers.com
----- Original Message ----- From: "Benjamin Herrenschmidt" <[email protected]>
To: "support" <[email protected]>
Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Wednesday, February 03, 2010 7:18 PM
Subject: Re: [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests on unsigned
Quoted 27 lines · support
Quoted 10 lines
The sky cpu is a PPC7448.
I'm actually amazed that you guys are still working on a problem for a
product that was finished a number of years ago, at the request of someone
who hasn't worked here for years.
I sorry you, seem to have been wasting your time.
I think, but am NOT sure, that our HAA function sets it off.
http://www.skycomputers.com/Systems/HAA_HMM.phpQuoted 6 lines
Still, we have finished the product some time ago, and as far as reported
have no problems.
Again, I'm sorry you have wasted any time on this, we just recently found
these emails.Well, there seem to be some code in the Linux kernel related to that CPU that is either dead or incomplete. So if you guys have no interest in it, we might just rip it out completely.
Cheers,
Ben.
Quoted 1 line · support
I doubt we'll be going to be using 7448's any more for future product lines.
Hi !
Well, that isn't really the question :-) Is there any interest in ensuring that your current Sky is supported by upstream linux kernels or not ? As I said, the current kernel seems to contain code relative to the Sky CPU that is never enabled and potentially has issue. Are you guys interested in fixing this so that upstream linux supports your existing products, or should we just rip the code out ?
Cheers,
Ben.
Quoted 46 lines
Dave Bushee
Director OEM Sales and Services
SKY Computers Inc.
27 Industrial Ave.
978-250-2420 x232
www.skycomputers.com----- Original Message -----
From: "Benjamin Herrenschmidt" <[email protected]>
To: "support" <[email protected]>
Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Wednesday, February 03, 2010 7:18 PM
Subject: Re: [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests on unsignedQuoted 27 lines · support
Quoted 10 lines
The sky cpu is a PPC7448.
I'm actually amazed that you guys are still working on a problem for a
product that was finished a number of years ago, at the request of someone
who hasn't worked here for years.
I sorry you, seem to have been wasting your time.
I think, but am NOT sure, that our HAA function sets it off.
http://www.skycomputers.com/Systems/HAA_HMM.phpQuoted 6 lines
Still, we have finished the product some time ago, and as far as reported
have no problems.
Again, I'm sorry you have wasted any time on this, we just recently found
these emails.Well, there seem to be some code in the Linux kernel related to that CPU that is either dead or incomplete. So if you guys have no interest in it, we might just rip it out completely.
Cheers,
Ben.
We don't plan on carrying it forward, so I assume that ripping it out will not affect us.
Anything new would be completely new development.
-----Original Message-----
From: Benjamin Herrenschmidt [mailto:[email protected]]
Sent: Wednesday, February 03, 2010 9:01 PM
To: support
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests on unsigned
Quoted 1 line · support
I doubt we'll be going to be using 7448's any more for future product
lines.
Hi !
Well, that isn't really the question :-) Is there any interest in ensuring that your current Sky is supported by upstream linux kernels or not ? As I said, the current kernel seems to contain code relative to the Sky CPU that is never enabled and potentially has issue. Are you guys interested in fixing this so that upstream linux supports your existing products, or should we just rip the code out ?
Cheers,
Ben.
Quoted 47 lines
Dave Bushee
Director OEM Sales and Services
SKY Computers Inc.
27 Industrial Ave.
978-250-2420 x232
www.skycomputers.com----- Original Message -----
From: "Benjamin Herrenschmidt" <[email protected]>
To: "support" <[email protected]>
Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Wednesday, February 03, 2010 7:18 PM
Subject: Re: [patch 1/2] powerpc: Sky CPU: redundant or incorrect tests onunsigned
Quoted 27 lines · support
Quoted 10 lines
The sky cpu is a PPC7448.
I'm actually amazed that you guys are still working on a problem for a
product that was finished a number of years ago, at the request of someone
who hasn't worked here for years.
I sorry you, seem to have been wasting your time.
I think, but am NOT sure, that our HAA function sets it off.
http://www.skycomputers.com/Systems/HAA_HMM.phpQuoted 6 lines
Still, we have finished the product some time ago, and as far as reported
have no problems.
Again, I'm sorry you have wasted any time on this, we just recently found
these emails.Well, there seem to be some code in the Linux kernel related to that CPU that is either dead or incomplete. So if you guys have no interest in it, we might just rip it out completely.
Cheers,
Ben.