Skip to contentSkip to conversation

drivers/media/dvb/frontends/stv090x.c: fix use-uninitialised

PATCH Applied [email protected] 2 participants 2 messages Feb 2, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 6/7 drivers/media/dvb/frontends/stv090x.c: fix use-uninitialised

From: Andrew Morton <[email protected]>

drivers/media/dvb/frontends/stv090x.c: In function 'stv090x_blind_search':
drivers/media/dvb/frontends/stv090x.c:1967: warning: 'coarse_fail' may be used uninitialized in this function

Cc Manu Abraham <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>

---

 drivers/media/dvb/frontends/stv090x.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/dvb/frontends/stv090x.c renamed from drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised +2 -1
diff -puN drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised drivers/media/dvb/frontends/stv090x.c
@@ -1964,7 +1964,8 @@ static int stv090x_blind_search(struct s
 	u32 agc2, reg, srate_coarse;
 	s32 cpt_fail, agc2_ovflw, i;
 	u8 k_ref, k_max, k_min;
-	int coarse_fail, lock;
+	int coarse_fail = 0;
+	int lock;
 
 	k_max = 110;
 	k_min = 10;

_

Reviewed-by Acked-by on v1 6/7
#1 lore raw
Quoted 26 lines · On Wed, Feb 3, 2010 at 2:40 AM, <[email protected]> wrote:

From: Andrew Morton <[email protected]>

drivers/media/dvb/frontends/stv090x.c: In function 'stv090x_blind_search':
drivers/media/dvb/frontends/stv090x.c:1967: warning: 'coarse_fail' may be used uninitialized in this function

Cc Manu Abraham <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>

---

 drivers/media/dvb/frontends/stv090x.c |    3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised drivers/media/dvb/frontends/stv090x.c

drivers/media/dvb/frontends/stv090x.c renamed from drivers/media/dvb/frontends/stv090x.c~drivers-media-dvb-frontends-stv090xc-fix-use-uninitialised +2 -1
@@ -1964,7 +1964,8 @@ static int stv090x_blind_search(struct s
        u32 agc2, reg, srate_coarse;
        s32 cpt_fail, agc2_ovflw, i;
        u8 k_ref, k_max, k_min;
-       int coarse_fail, lock;
+       int coarse_fail = 0;
+       int lock;
 
        k_max = 110;
        k_min = 10;
Quoted 2 lines

_

Looks good

Thanks,
Manu