mISDN: positive error return should be negative in mode_hfcmulti()
Subsystems (2)
PATCH 4/4 mISDN: positive error return should be negative in mode_hfcmulti()
From: Roel Kluin <[email protected]>
The error return should be negative. Its only caller that acts upon its return, handle_bmsg(), transmits the positive error but can also return negative errors.
Signed-off-by Roel Kluin <[email protected]>
Cc Karsten Keil <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/isdn/hardware/mISDN/hfcmulti.c renamed from drivers/isdn/hardware/mISDN/hfcmulti.c~misdn-positive-error-return-should-be-negative-in-mode_hfcmulti +1 -1
@@ -2846,7 +2846,7 @@ mode_hfcmulti(struct hfc_multi *hc, intint conf;if (ch <0 || ch >31 ) -return EINVAL ; +return -EINVAL ; oslot_tx = hc->chan[ch].slot_tx; oslot_rx = hc->chan[ch].slot_rx; conf = hc->chan[ch].conf;
_
From: [email protected]
Date: Tue, 02 Feb 2010 14:43:47 -0800
Quoted 9 lines
From: Roel Kluin <[email protected]>
The error return should be negative. Its only caller that acts upon its return,
handle_bmsg(), transmits the positive error but can also return negative errors.Signed-off-by Roel Kluin <[email protected]>Cc Karsten Keil <[email protected]>Signed-off-by Andrew Morton <[email protected]>
Applied.