Transparent Hugepage support #9
Subsystems (28)
PATCH 1/1 Transparent Hugepage support #9
Hello,
this release fixes a cosmetic problem in khugepaged.
If you want to test:
http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.33-rc6/transparent_hugepage-9/ http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.33-rc6/transparent_hugepage-9.gz
Thanks,
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 add pmd mmu_notifier helpers
From: Andrea Arcangeli <[email protected]>
Add mmu notifier helpers to handle pmd huge operations.
---
include/linux/mmu_notifier.h +40 -0
@@ -243,6 +243,32 @@ static inline void mmu_notifier_mm_destr __pte; \ }) +#define pmdp_clear_flush_notify (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + VM_BUG_ON(__address & ~HPAGE_PMD_MASK); \ + mmu_notifier_invalidate_range_start(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE);\ + __pmd = pmdp_clear_flush(___vma, ___address, __pmdp); \ + mmu_notifier_invalidate_range_end(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE); \ + __pmd; \ +}) + +#define pmdp_splitting_flush_notify (__vma, __address, __pmdp) \ +({ \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + VM_BUG_ON(__address & ~HPAGE_PMD_MASK); \ + mmu_notifier_invalidate_range_start(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE);\ + pmdp_splitting_flush(___vma, ___address, __pmdp); \ + mmu_notifier_invalidate_range_end(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE); \ +}) +#define ptep_clear_flush_young_notify (__vma, __address, __ptep) \ ({ \ int __young; \
@@ -254,6 +280,17 @@ static inline void mmu_notifier_mm_destr __young; \ }) +#define pmdp_clear_flush_young_notify (__vma, __address, __pmdp) \ +({ \ + int __young; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + __young = pmdp_clear_flush_young(___vma, ___address, __pmdp); \ + __young |= mmu_notifier_clear_flush_young(___vma->vm_mm, \ + ___address); \ + __young; \ +}) +#define set_pte_at_notify (__mm, __address, __ptep, __pte) \ ({ \ struct mm_struct *___mm = __mm; \
@@ -305,7 +342,10 @@ static inline void mmu_notifier_mm_destr }#define ptep_clear_flush_young_notify ptep_clear_flush_young +#define pmdp_clear_flush_young_notify pmdp_clear_flush_young#define ptep_clear_flush_notify ptep_clear_flush +#define pmdp_clear_flush_notify pmdp_clear_flush +#define pmdp_splitting_flush_notify pmdp_splitting_flush#define set_pte_at_notify set_pte_at#endif /* CONFIG_MMU_NOTIFIER */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 split_huge_page_mm/vma
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
split_huge_page_mm/vma compat code. Each one of those would need to be expanded to hundred of lines of complex code without a fully reliable split_huge_page_mm/vma functionality.
---
arch/x86/kernel/vm86_32.c +1 -0
@@ -179,6 +179,7 @@ static void mark_screen_rdonly(struct mmif (pud_none_or_clear_bad (pud)) goto out; pmd =pmd_offset (pud,0xA0000 ); +split_huge_page_mm (mm,0xA0000 , pmd);if (pmd_none_or_clear_bad (pmd)) goto out; pte =pte_offset_map_lock (mm, pmd,0xA0000 , &ptl);
mm/mempolicy.c +1 -0
@@ -446,6 +446,7 @@ static inline int check_pmd_range(struct pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + split_huge_page_vma(vma, pmd); if (pmd_none_or_clear_bad(pmd)) continue; if (check_pte_range(vma, pmd, addr, next, nodes,
mm/mincore.c +1 -0
@@ -132,6 +132,7 @@ static long do_mincore(unsigned long addif (pud_none_or_clear_bad (pud)) goto none_mapped; pmd =pmd_offset (pud, addr); +split_huge_page_vma (vma, pmd);if (pmd_none_or_clear_bad (pmd)) goto none_mapped;
mm/mprotect.c +1 -0
@@ -89,6 +89,7 @@ static inline void change_pmd_range(stru pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + split_huge_page_mm(mm, addr, pmd); if (pmd_none_or_clear_bad(pmd)) continue; change_pte_range(mm, pmd, addr, next, newprot, dirty_accountable);
mm/mremap.c +1 -0
@@ -42,6 +42,7 @@ static pmd_t *get_old_pmd(struct mm_strureturn NULL ; pmd =pmd_offset (pud, addr); +split_huge_page_mm (mm, addr, pmd);if (pmd_none_or_clear_bad (pmd))return NULL ;
mm/pagewalk.c +1 -0
@@ -34,6 +34,7 @@ static int walk_pmd_range(pud_t *pud, un pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + split_huge_page_mm(walk->mm, addr, pmd); if (pmd_none_or_clear_bad(pmd)) { if (walk->pte_hole) err = walk->pte_hole(addr, next, walk);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 clear_copy_huge_page
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Move the copy/clear_huge_page functions to common code to share between hugetlb.c and huge_memory.c.
---
include/linux/mm.h +9 -0
@@ -1386,5 +1386,14 @@ extern void shake_page(struct page *p, iextern atomic_long_t mce_bad_pages;extern int soft_offline_page (struct page *page,int flags); +#if defined(CONFIG_TRANSPARENT_HUGEPAGE ) || defined(CONFIG_HUGETLBFS ) +extern void clear_huge_page (struct page *page, +unsigned long addr, +unsigned int pages_per_huge_page); +extern void copy_huge_page (struct page *dst,struct page *src, +unsigned long addr,struct vm_area_struct *vma, +unsigned int pages_per_huge_page); +#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/hugetlb.c +2 -65
79 lines not on this page · raw message
mm/memory.c +70 -0
73 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 memcg compound
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Teach memcg to charge/uncharge compound pages.
---
Documentation/cgroups/memory.txt +4 -0
@@ -4,6 +4,10 @@ NOTE: The Memory Resource Controller has to as the memory controller in this document. Do not confuse memory controller used here with the memory controller that is used in hardware. +NOTE: When in this documentation we refer to PAGE_SIZE, we actually +mean the real page size of the page being accounted which is bigger than +PAGE_SIZE for compound pages. + Salient features a. Enable control of Anonymous, Page Cache (mapped and unmapped) and
mm/memcontrol.c +45 -31
227 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 madvise(MADV_HUGEPAGE)
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add madvise MADV_HUGEPAGE to mark regions that are important to be hugepage backed. Return -EINVAL if the vma is not of an anonymous type, or the feature isn't built into the kernel. Never silently return success.
---
include/linux/huge_mm.h +6 -0
@@ -107,6 +107,7 @@ extern int split_huge_page(struct page *#endif extern unsigned long vma_address (struct page *page,struct vm_area_struct *vma); +extern int hugepage_madvise (unsigned long *vm_flags);static inline int PageTransHuge (struct page *page) {VM_BUG_ON (PageTail (page));
@@ -133,6 +134,11 @@ static inline int split_huge_page(struct#define wait_split_huge_page (__anon_vma, __pmd) \ do { } while (0)#define PageTransHuge (page) 0 +static inline int hugepage_madvise (unsigned long *vm_flags) +{ +BUG_ON (0 ); +return 0 ; +}#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif /* _LINUX_HUGE_MM_H */
mm/huge_memory.c +22 -3
@@ -462,9 +462,11 @@ int do_huge_pmd_wp_page(struct mm_structput_page (new_page); new_page =NULL ; } -if (unlikely (!new_page)) -return do_huge_pmd_wp_page_fallback (mm, vma, address, - pmd, orig_pmd, page, haddr); +if (unlikely (!new_page)) { + ret =do_huge_pmd_wp_page_fallback (mm, vma, address, + pmd, orig_pmd, page, haddr); + goto out; + }copy_huge_page (new_page, page, haddr, vma,HPAGE_PMD_NR );__SetPageUptodate (new_page);
@@ -487,6 +489,7 @@ int do_huge_pmd_wp_page(struct mm_struct } out_unlock:spin_unlock (&mm->page_table_lock); +out:return ret; }
@@ -837,3 +840,19 @@ out_unlock: out:return ret; } + +int hugepage_madvise (unsigned long *vm_flags) +{ +/* +* Be somewhat over-protective like KSM for now! +*/ +if (*vm_flags & (VM_HUGEPAGE |VM_SHARED |VM_MAYSHARE | +VM_PFNMAP |VM_IO |VM_DONTEXPAND | +VM_RESERVED |VM_HUGETLB |VM_INSERTPAGE | +VM_MIXEDMAP |VM_SAO )) +return -EINVAL ; + + *vm_flags |=VM_HUGEPAGE ; + +return 0 ; +}
mm/madvise.c +8 -0
@@ -71,6 +71,11 @@ static long madvise_behavior(struct vm_aif (error) goto out;break ; +case MADV_HUGEPAGE : + error =hugepage_madvise (&new_flags); +if (error) + goto out; +break ; }if (new_flags == vma->vm_flags) {
@@ -283,6 +288,9 @@ madvise_behavior_valid(int behavior)case MADV_MERGEABLE :case MADV_UNMERGEABLE :#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +case MADV_HUGEPAGE : +#endif return 1 ;default :
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 bail out gup_fast on splitting pmd
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Force gup_fast to take the slow path and block if the pmd is splitting, not only if it's none.
---
arch/x86/mm/gup.c +12 -1
@@ -160,7 +160,18 @@ static int gup_pmd_range(pud_t pud, unsipmd_t pmd = *pmdp; next =pmd_addr_end (addr, end); -if (pmd_none (pmd)) +/* +* The pmd_trans_splitting() check below explains why +* pmdp_splitting_flush has to flush the tlb, to stop +* this gup-fast code from running while we set the +* splitting bit in the pmd. Returning zero will take +* the slow path that will call wait_split_huge_page() +* if the pmd is still in splitting state. gup-fast +* can't because it has irq disabled and +* wait_split_huge_page() would never return as the +* tlb flush IPI wouldn't run. +*/ +if (pmd_none (pmd) ||pmd_trans_splitting (pmd))return 0 ;if (unlikely (pmd_large (pmd))) {if (!gup_huge_pmd (pmd, addr, next, write, pages, nr))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 verify pmd_trans_huge isn't leaking
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
pte_trans_huge must not leak in certain vmas like the mmio special pfn or filebacked mappings.
---
mm/memory.c +6 -1
@@ -1333,6 +1333,7 @@ int __get_user_pages(struct task_struct pmd =pmd_offset (pud, pg);if (pmd_none (*pmd))return i ? : -EFAULT ; +VM_BUG_ON (pmd_trans_huge (*pmd)); pte =pte_offset_map (pmd, pg);if (pte_none (*pte)) {pte_unmap (pte);
@@ -1534,8 +1535,10 @@ pte_t *get_locked_pte(struct mm_struct *pud_t * pud =pud_alloc (mm, pgd, addr);if (pud) {pmd_t * pmd =pmd_alloc (mm, pud, addr); -if (pmd) +if (pmd) { +VM_BUG_ON (pmd_trans_huge (*pmd));return pte_alloc_map_lock (mm, pmd, addr, ptl); + } }return NULL ; }
@@ -1754,6 +1757,7 @@ static inline int remap_pmd_range(struct pmd =pmd_alloc (mm, pud, addr);if (!pmd)return -ENOMEM ; +VM_BUG_ON (pmd_trans_huge (*pmd)); do { next = pmd_addr_end(addr, end); if (remap_pte_range(mm, pmd, addr, next,
@@ -3218,6 +3222,7 @@ static int follow_pte(struct mm_struct * goto out; pmd =pmd_offset (pud, address); +VM_BUG_ON (pmd_trans_huge (*pmd));if (pmd_none (*pmd) ||unlikely (pmd_bad (*pmd))) goto out;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 split_huge_page paging
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Paging logic that splits the page before it is unmapped and added to swap to ensure backwards compatibility with the legacy swap code. Eventually swap should natively pageout the hugepages to increase performance and decrease seeking and fragmentation of swap space. swapoff can just skip over huge pmd as they cannot be part of swap yet. In add_to_swap be careful to split the page only if we got a valid swap entry so we don't split hugepages with a full swap.
In theory we could split pages before isolating them during the lru scan, but for khugepaged to be safe, I'm relying on either mmap_sem write mode, or PG_lock taken, so split_huge_page has to run either with mmap_sem read/write mode or PG_lock taken. Calling it from isolate_lru_page would make locking more complicated, in addition to that split_huge_page would deadlock if called by __isolate_lru_page because it has to take the lru lock to add the tail pages.
---
mm/memory-failure.c +2 -0
@@ -378,6 +378,8 @@ static void collect_procs_anon(struct pastruct task_struct *tsk;struct anon_vma *av; +if (unlikely (split_huge_page (page))) +return ;read_lock (&tasklist_lock); av =page_lock_anon_vma (page);if (av ==NULL )/* Not actually mapped anymore */
mm/rmap.c +1 -0
@@ -1174,6 +1174,7 @@ int try_to_unmap(struct page *page, enumint ret;BUG_ON (!PageLocked (page)); +BUG_ON (PageTransHuge (page));if (unlikely (PageKsm (page))) ret =try_to_unmap_ksm (page, flags);
mm/swap_state.c +6 -0
@@ -156,6 +156,12 @@ int add_to_swap(struct page *page)if (!entry.val)return 0 ; +if (unlikely (PageTransHuge (page))) +if (unlikely (split_huge_page (page))) { +swapcache_free (entry,NULL ); +return 0 ; + } +/* * Radix-tree node allocations from PF_MEMALLOC contexts could * completely exhaust the page allocator. __GFP_NOMEMALLOC
mm/swapfile.c +2 -0
@@ -905,6 +905,8 @@ static inline int unuse_pmd_range(struct pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + if (unlikely(pmd_trans_huge(*pmd))) + continue; if (pmd_none_or_clear_bad(pmd)) continue; ret = unuse_pte_range(vma, pmd, addr, next, entry, page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 transparent hugepage vmstat
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add hugepage stat information to /proc/vmstat and /proc/meminfo.
---
fs/proc/meminfo.c +7 -0
@@ -101,6 +101,9 @@ static int meminfo_proc_show(struct seq_#ifdef CONFIG_MEMORY_FAILURE "HardwareCorrupted: %5lu kB\n"#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +"AnonHugePages: %8lu kB\n" +#endif ,K (i.totalram), K(i.freeram),
@@ -151,6 +154,10 @@ static int meminfo_proc_show(struct seq_#ifdef CONFIG_MEMORY_FAILURE ,atomic_long_read(&mce_bad_pages) << (PAGE_SHIFT - 10)#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + ,K(global_page_state(NR_ANON_TRANSPARENT_HUGEPAGES) * +HPAGE_PMD_NR ) +#endif );hugetlb_report_meminfo (m);
include/linux/mmzone.h +1 -0
@@ -112,6 +112,7 @@ enum zone_stat_item {NUMA_LOCAL ,/* allocation from local node */ NUMA_OTHER ,/* allocation from other node */ #endif +NR_ANON_TRANSPARENT_HUGEPAGES , NR_VM_ZONE_STAT_ITEMS };/*
mm/huge_memory.c +3 -0
@@ -710,6 +710,9 @@ static void __split_huge_page_refcount(sput_page (page_tail); } +__dec_zone_page_state (page,NR_ANON_TRANSPARENT_HUGEPAGES ); +__mod_zone_page_state (zone,NR_ANON_PAGES ,HPAGE_PMD_NR ); +ClearPageCompound (page);compound_unlock (page);spin_unlock_irq (&zone->lru_lock);
mm/rmap.c +16 -4
@@ -687,8 +687,13 @@ void page_add_anon_rmap(struct page *pag struct vm_area_struct *vma, unsigned long address) { int first = atomic_inc_and_test(&page->_mapcount); -if (first) -__inc_zone_page_state (page,NR_ANON_PAGES ); +if (first) { +if (!PageTransHuge (page)) +__inc_zone_page_state (page,NR_ANON_PAGES ); +else +__inc_zone_page_state (page, +NR_ANON_TRANSPARENT_HUGEPAGES ); + }if (unlikely (PageKsm (page)))return ;
@@ -716,7 +721,10 @@ void page_add_new_anon_rmap(struct pageVM_BUG_ON (address < vma->vm_start || address >= vma->vm_end);SetPageSwapBacked (page);atomic_set (&page->_mapcount,0 );/* increment count (starts at -1) */ -__inc_zone_page_state (page,NR_ANON_PAGES ); +if (!PageTransHuge (page)) +__inc_zone_page_state (page,NR_ANON_PAGES ); +else +__inc_zone_page_state (page,NR_ANON_TRANSPARENT_HUGEPAGES );__page_set_anon_rmap (page, vma, address);if (page_evictable (page, vma))lru_cache_add_lru (page,LRU_ACTIVE_ANON );
@@ -763,7 +771,11 @@ void page_remove_rmap(struct page *page) }if (PageAnon (page)) {mem_cgroup_uncharge_page (page); -__dec_zone_page_state (page,NR_ANON_PAGES ); +if (!PageTransHuge (page)) +__dec_zone_page_state (page,NR_ANON_PAGES ); +else +__dec_zone_page_state (page, +NR_ANON_TRANSPARENT_HUGEPAGES ); }else {__dec_zone_page_state (page,NR_FILE_MAPPED );mem_cgroup_update_file_mapped (page,-1 );
mm/vmstat.c +3 -0
@@ -655,6 +655,9 @@ static const char * const vmstat_text[]"numa_local" ,"numa_other" , #endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +"nr_anon_transparent_hugepages" , +#endif #ifdef CONFIG_VM_EVENT_COUNTERS "pgpgin",
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 pmd_trans_huge migrate bugcheck
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
No pmd_trans_huge should ever materialize in migration ptes areas, because we split the hugepage before migration ptes are instantiated.
---
include/linux/huge_mm.h +5 -0
@@ -113,6 +113,10 @@ static inline int PageTransHuge(struct pVM_BUG_ON (PageTail (page)); return PageHead(page); } +static inline int PageTransCompound (struct page *page) +{ +return PageCompound (page); +}#else /* CONFIG_TRANSPARENT_HUGEPAGE */ #define HPAGE_PMD_SHIFT ({ BUG(); 0; })#define HPAGE_PMD_MASK ({ BUG(); 0; })
@@ -134,6 +138,7 @@ static inline int split_huge_page(struct#define wait_split_huge_page (__anon_vma, __pmd) \ do { } while (0)#define PageTransHuge (page) 0 +#define PageTransCompound (page) 0static inline int hugepage_madvise (unsigned long *vm_flags) {BUG_ON (0 );
mm/migrate.c +5 -0
@@ -99,6 +99,7 @@ static int remove_migration_pte(struct p goto out; pmd =pmd_offset (pud, addr); +VM_BUG_ON (pmd_trans_huge (*pmd));if (!pmd_present (*pmd)) goto out;
@@ -819,6 +820,10 @@ static int do_move_page_to_node_array(stif (PageReserved (page) ||PageKsm (page)) goto put_and_set; +if (unlikely (PageTransCompound (page))) +if (unlikely (split_huge_page (page))) + goto put_and_set; + pp->page = page; err =page_to_nid (page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 28 of 32] pmd_trans_huge migrate bugcheck
mm/migrate.c static int do_move_page_to_node_array(st · line 828
Quoted 13 lines · Andrea Arcangeli
mm/migrate.c +4
-0@@ -819,6 +820,10 @@ static int do_move_page_to_node_array(stif (PageReserved (page) ||PageKsm (page)) goto put_and_set; +if (unlikely (PageTransCompound (page))) +if (unlikely (split_huge_page (page))) + goto put_and_set; + pp->page = page; err =page_to_nid (page);
How does this work? do_move_page_to_node_array takes an array of page pointers in pp (struct page_to_node). Lets say one is a compound page.
Now we split this into 512 4k pages? and pp only points to the first of them?
The rest of the move_pages() logic will only see one 4k page and move it.
The remaining 511 pages are left dangling? With an increased refcount?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 28 of 32] pmd_trans_huge migrate bugcheck
Quoted 9 lines · Christoph Lameter
Quoted 7 lines · Andrea Arcangeli
mm/migrate.c +0
-0@@ -819,6 +820,10 @@ static int do_move_page_to_node_array(stif (PageReserved (page) ||PageKsm (page)) goto put_and_set;
Quoted 9 lines
mm/migrate.c static int do_move_page_to_node_array(st · line 828
Quoted 6 lines
mm/migrate.c +4
-0+if (unlikely (PageTransCompound (page))) +if (unlikely (split_huge_page (page))) + goto put_and_set; + pp->page = page; err =page_to_nid (page);How does this work?
do_move_page_to_node_arraytakes an array of page pointers in pp (structpage_to_node). Lets say one is a compound page.
yes, all it matters is that it's not an array of "struct page" pointers in input to that function.
Quoted 3 lines
Now we split this into 512 4k pages? and pp only points to the first of them?
page_to_node is only set in the "addr" field before split_huge_page runs, see pp[j].addr = ... That is the input of the syscall.
Quoted 1 line
The rest of the
move_pages()logic will only see one 4k page and move it.
Before follow_page is called, nobody could ever see any "struct page". And after we call it, we immediately call split_huge_page if it returned a tail/head page. (collapse_huge_page can't be collapsing it again under us because of the pin taken by follow_page(FOLL_GET)).
split_huge_page runs before isolate_lru_page is called, so the lru mangling isn't involved in the split (besides it would work anyway).
Quoted 1 line
The remaining 511 pages are left dangling? With an increased refcount?
The reamining 511 pages will be taken over by the next follow_page if userland asks for it, userland will have no way to know if ram is backed by hugepage or regular page so it has to submit one address per page as syscall api has to be backwards compatible or everything breaks. All other 511 pages have no increased refcount from the first follow_page (or more precisely nothing related to the follow_page on the 1st page, their page_count simply goes to match the head page mapcount plus any additional pin on tail pages previously taken by gup).
Only after the first follow_page for an address backed by an hugepage we will call split_huge_page, all other follow_page on that 2m naturally aligned virtual chunk will return regular pages like if no hugepage existed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 memcg huge memory
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add memcg charge/uncharge to hugepage faults in huge_memory.c.
---
mm/huge_memory.c +25 -5
@@ -211,6 +211,7 @@ static int __do_huge_pmd_anonymous_page(VM_BUG_ON (!PageCompound (page)); pgtable =pte_alloc_one (mm, haddr);if (unlikely (!pgtable)) { +mem_cgroup_uncharge_page (page);put_page (page);return VM_FAULT_OOM ; }
@@ -221,6 +222,7 @@ static int __do_huge_pmd_anonymous_page(spin_lock (&mm->page_table_lock);if (unlikely (!pmd_none (*pmd))) {spin_unlock (&mm->page_table_lock); +mem_cgroup_uncharge_page (page);put_page (page);pte_free (mm, pgtable); }else {
@@ -265,6 +267,10 @@ int do_huge_pmd_anonymous_page(struct mm page =alloc_hugepage (transparent_hugepage_defrag (vma));if (unlikely (!page)) goto out; +if (unlikely (mem_cgroup_newpage_charge (page, mm,GFP_KERNEL ))) { +put_page (page); + goto out; + }return __do_huge_pmd_anonymous_page (mm, vma, haddr, pmd, page); }
@@ -364,9 +370,15 @@ static int do_huge_pmd_wp_page_fallback(for (i =0 ; i <HPAGE_PMD_NR ; i++) { pages[i] =alloc_page_vma (GFP_HIGHUSER_MOVABLE , vma, address); -if (unlikely (!pages[i])) { -while (--i >=0 ) +if (unlikely (!pages[i] || +mem_cgroup_newpage_charge (pages[i], mm, +GFP_KERNEL ))) { +if (pages[i])put_page (pages[i]); +while (--i >=0 ) { +mem_cgroup_uncharge_page (pages[i]); +put_page (pages[i]); + }kfree (pages); ret |=VM_FAULT_OOM ; goto out;
@@ -425,8 +437,10 @@ out: out_free_pages:spin_unlock (&mm->page_table_lock); -for (i =0 ; i <HPAGE_PMD_NR ; i++) +for (i =0 ; i <HPAGE_PMD_NR ; i++) { +mem_cgroup_uncharge_page (pages[i]);put_page (pages[i]); + }kfree (pages); goto out; }
@@ -468,13 +482,19 @@ int do_huge_pmd_wp_page(struct mm_struct goto out; } +if (unlikely (mem_cgroup_newpage_charge (new_page, mm,GFP_KERNEL ))) { +put_page (new_page); + ret |=VM_FAULT_OOM ; + goto out; + }copy_huge_page (new_page, page, haddr, vma,HPAGE_PMD_NR );__SetPageUptodate (new_page);spin_lock (&mm->page_table_lock); -if (unlikely (!pmd_same (*pmd, orig_pmd))) +if (unlikely (!pmd_same (*pmd, orig_pmd))) { +mem_cgroup_uncharge_page (new_page);put_page (new_page); -else { + }else {pmd_t entry; entry =mk_pmd (new_page, vma->vm_page_prot); entry =maybe_pmd_mkwrite (pmd_mkdirty (entry), vma);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 alter compound get_page/put_page
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Alter compound get_page/put_page to keep references on subpages too, in order to allow __split_huge_page_refcount to split an hugepage even while subpages have been pinned by one of the get_user_pages() variants.
---
arch/powerpc/mm/gup.c +12 -0
@@ -16,6 +16,16 @@#ifdef __HAVE_ARCH_PTE_SPECIAL +static inline void pin_huge_page_tail (struct page *page) +{ +/* +* __split_huge_page_refcount() cannot run +* from under us. +*/ +VM_BUG_ON (atomic_read (&page->_count) <0 ); +atomic_inc (&page->_count); +} +/* * The performance critical leaf functions are made noinline otherwise gcc * inlines everything into a single function which results in too much
@@ -47,6 +57,8 @@ static noinline int gup_pte_range(pmd_tput_page (page);return 0 ; } +if (PageTail (page)) +pin_huge_page_tail (page); pages[*nr] = page; (*nr)++;
arch/x86/mm/gup.c +12 -0
@@ -105,6 +105,16 @@ static inline void get_head_page_multiplatomic_add (nr, &page->_count); } +static inline void pin_huge_page_tail (struct page *page) +{ +/* +* __split_huge_page_refcount() cannot run +* from under us. +*/ +VM_BUG_ON (atomic_read (&page->_count) <0 ); +atomic_inc (&page->_count); +} + static noinline int gup_huge_pmd(pmd_t pmd, unsigned long addr,unsigned long end,int write,struct page **pages,int *nr) {
@@ -128,6 +138,8 @@ static noinline int gup_huge_pmd(pmd_t p do { VM_BUG_ON(compound_head(page) != head); pages[*nr] = page; + if (PageTail(page)) + pin_huge_page_tail(page); (*nr)++; page++; refs++;
include/linux/mm.h +10 -2
@@ -323,9 +323,17 @@ static inline int page_count(struct pagestatic inline void get_page (struct page *page) { - page =compound_head (page); -VM_BUG_ON (atomic_read (&page->_count) ==0 ); +VM_BUG_ON (atomic_read (&page->_count) < !PageTail (page));atomic_inc (&page->_count); +if (unlikely (PageTail (page))) { +/* +* This is safe only because +* __split_huge_page_refcount can't run under +* get_page(). +*/ +VM_BUG_ON (atomic_read (&page->first_page->_count) <=0 ); +atomic_inc (&page->first_page->_count); + } }static inline struct page *virt_to_head_page (const void *x)
mm/swap.c +72 -7
96 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 add native_set_pmd_at
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Used by paravirt and not paravirt set_pmd_at.
---
arch/x86/include/asm/pgtable.h +6 -0
@@ -528,6 +528,12 @@ static inline void native_set_pte_at(strnative_set_pte (ptep, pte); } +static inline void native_set_pmd_at (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp ,pmd_t pmd) +{ +native_set_pmd (pmdp, pmd); +} +#ifndef CONFIG_PARAVIRT /* * Rules for using pte_update - it must be called after any PTE update which
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 define MADV_HUGEPAGE
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Define MADV_HUGEPAGE.
---
arch/alpha/include/asm/mman.h +2 -0
@@ -53,6 +53,8 @@#define MADV_MERGEABLE 12/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
arch/mips/include/asm/mman.h +2 -0
@@ -77,6 +77,8 @@#define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ #define MADV_HWPOISON 100/* poison a page for testing */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
arch/parisc/include/asm/mman.h +2 -0
@@ -59,6 +59,8 @@#define MADV_MERGEABLE 65/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 66/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 67/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0#define MAP_VARIABLE 0
arch/xtensa/include/asm/mman.h +2 -0
@@ -83,6 +83,8 @@#define MADV_MERGEABLE 12/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
include/asm-generic/mman-common.h +2 -0
@@ -45,6 +45,8 @@#define MADV_MERGEABLE 12/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 update futex compound knowledge
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Futex code is smarter than most other gup_fast O_DIRECT code and knows about the compound internals. However now doing a put_page(head_page) will not release the pin on the tail page taken by gup-fast, leading to all sort of refcounting bugchecks. Getting a stable head_page is a little tricky.
page_head = page is there because if this is not a tail page it's also the page_head. Only in case this is a tail page, compound_head is called, otherwise it's guaranteed unnecessary. And if it's a tail page compound_head has to run atomically inside irq disabled section __get_user_pages_fast before returning. Otherwise ->first_page won't be a stable pointer.
Disableing irq before __get_user_page_fast and releasing irq after running compound_head is needed because if __get_user_page_fast returns == 1, it means the huge pmd is established and cannot go away from under us. pmdp_splitting_flush_notify in __split_huge_page_splitting will have to wait for local_irq_enable before the IPI delivery can return. This means __split_huge_page_refcount can't be running from under us, and in turn when we run compound_head(page) we're not reading a dangling pointer from tailpage->first_page. Then after we get to stable head page, we are always safe to call compound_lock and after taking the compound lock on head page we can finally re-check if the page returned by gup-fast is still a tail page. in which case we're set and we didn't need to split the hugepage in order to take a futex on it.
---
kernel/futex.c +37 -9
@@ -218,7 +218,7 @@ get_futex_key(u32 __user *uaddr, int fsh {unsigned long address = (unsigned long )uaddr;struct mm_struct *mm = current->mm; -struct page *page; +struct page *page, *page_head;int err;/*
@@ -250,10 +250,36 @@ again:if (err <0 )return err; - page =compound_head (page); -lock_page (page); -if (!page->mapping) { -unlock_page (page); +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + page_head = page; +if (unlikely (PageTail (page))) { +put_page (page); +/* serialize against __split_huge_page_splitting() */ +local_irq_disable (); +if (likely (__get_user_pages_fast (address,1 ,1 , &page) ==1 )) { + page_head =compound_head (page); +local_irq_enable (); + }else { +local_irq_enable (); + goto again; + } + } +#else + page_head =compound_head (page); +#endif + +lock_page (page_head); +if (unlikely (page_head != page)) { +compound_lock (page_head); +if (unlikely (!PageTail (page))) { +compound_unlock (page_head); +unlock_page (page_head); +put_page (page); + goto again; + } + } +if (!page_head->mapping) { +unlock_page (page_head);put_page (page); goto again; }
@@ -265,19 +291,21 @@ again:* it's a read-only handle, it's expected that futexes attach to * the object not the particular process. */ -if (PageAnon (page)) { +if (PageAnon (page_head)) { key->both.offset |=FUT_OFF_MMSHARED ;/* ref taken on mm */ key->private.mm = mm; key->private.address = address; }else { key->both.offset |=FUT_OFF_INODE ;/* inode-based key */ - key->shared.inode = page->mapping->host; - key->shared.pgoff = page->index; + key->shared.inode = page_head->mapping->host; + key->shared.pgoff = page_head->index; }get_futex_key_refs (key); -unlock_page (page); +if (unlikely (PageTail (page))) +compound_unlock (page_head); +unlock_page (page_head);put_page (page);return 0 ; }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Peter Zijlstra
maintainerRe: [PATCH 04 of 32] update futex compound knowledge
Quoted 74 lines · Andrea Arcangeli
From: Andrea Arcangeli <[email protected]>
Futex code is smarter than most other
gup_fastO_DIRECTcode and knows about the compound internals. However now doing aput_page(head_page)will not release the pin on the tail page taken by gup-fast, leading to all sort of refcounting bugchecks. Getting a stablehead_pageis a little tricky.
page_head= page is there because if this is not a tail page it's also thepage_head. Only in case this is a tail page,compound_headis called, otherwise it's guaranteed unnecessary. And if it's a tail pagecompound_headhas to run atomically inside irq disabled section__get_user_pages_fastbefore returning. Otherwise ->first_page won't be a stable pointer.Disableing irq before
__get_user_page_fastand releasing irq after runningcompound_headis needed because if__get_user_page_fastreturns == 1, it means the huge pmd is established and cannot go away from under us.pmdp_splitting_flush_notifyin__split_huge_page_splittingwill have to wait forlocal_irq_enablebefore the IPI delivery can return. This means__split_huge_page_refcountcan't be running from under us, and in turn when we runcompound_head(page)we're not reading a dangling pointer fromtailpage->first_page. Then after we get to stable head page, we are always safe to callcompound_lockand after taking the compound lock on head page we can finally re-check if the page returned by gup-fast is still a tail page. in which case we're set and we didn't need to split the hugepage in order to take a futex on it.Signed-off-by Andrea Arcangeli <[email protected]>Acked-by Mel Gorman <[email protected]>Acked-by Rik van Riel <[email protected]>---
kernel/futex.c +24
-5@@ -218,7 +218,7 @@ get_futex_key(u32 __user *uaddr, int fsh {unsigned long address = (unsigned long )uaddr;struct mm_struct *mm = current->mm; -struct page *page; +struct page *page, *page_head;int err;/* @@ -250,10 +250,36 @@ again:if (err <0 )return err; - page =compound_head (page); -lock_page (page); -if (!page->mapping) { -unlock_page (page); +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + page_head = page; +if (unlikely (PageTail (page))) { +put_page (page); +/* serialize against __split_huge_page_splitting() */ +local_irq_disable (); +if (likely (__get_user_pages_fast (address,1 ,1 , &page) ==1 )) { + page_head =compound_head (page); +local_irq_enable (); + }else { +local_irq_enable (); + goto again; + } + } +#else + page_head =compound_head (page); +#endif + +lock_page (page_head); +if (unlikely (page_head != page)) { +compound_lock (page_head); +if (unlikely (!PageTail (page))) { +compound_unlock (page_head);
kernel/futex.c again: · line 285
Quoted 10 lines
kernel/futex.c +7
-0+unlock_page (page_head); +put_page (page); + goto again; + } + } +if (!page_head->mapping) { +unlock_page (page_head);put_page (page); goto again; }
OK, so I really don't like this, the futex code is pain enough without having all this open-coded gunk in. Is there really no sensible vm-helper you can use here?
Also, that whole local_irq_disable(); __gup_fast(); dance is terribly x86 specific, and this is generic core kernel code.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 04 of 32] update futex compound knowledge
Quoted 3 lines · Peter Zijlstra
OK, so I really don't like this, the futex code is pain enough without having all this open-coded gunk in. Is there really no sensible vm-helper you can use here?
I also don't like this but there's no vm helper and this is the only case where this happens. No other place pretends to work on the head page while calling gup on a tail page! So this requires special care considering tail page may disappear any time (and head page as well) if split_huge_page is running.
Quoted 2 lines
Also, that whole
local_irq_disable();__gup_fast(); dance is terribly x86 specific, and this is generic core kernel code.
But nothing risks to break at build time, simply any arch with transparent hugepage support also has to implement __get_user_pages_fast. Disabling irq and using __get_user_pages_fast looked the best way to serialize against split_huge_page here (rather than taking locks).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Peter Zijlstra
maintainerRe: [PATCH 04 of 32] update futex compound knowledge
Quoted 6 lines · Andrea Arcangeli
But nothing risks to break at build time, simply any arch with transparent hugepage support also has to implement
__get_user_pages_fast. Disabling irq and using__get_user_pages_fastlooked the best way to serialize againstsplit_huge_pagehere (rather than taking locks).
PowerPC uses rcu-free'd pagetables for gup_fast() iirc, so no need to disable IRQs there.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 04 of 32] update futex compound knowledge
Quoted 10 lines · Peter Zijlstra
Quoted 6 lines · Andrea Arcangeli
But nothing risks to break at build time, simply any arch with transparent hugepage support also has to implement
__get_user_pages_fast. Disabling irq and using__get_user_pages_fastlooked the best way to serialize againstsplit_huge_pagehere (rather than taking locks).PowerPC uses rcu-free'd pagetables for
gup_fast()iirc, so no need to disable IRQs there.
btw, powerpc right now doesn't support transparent hugepages. IRQs have to be disabled to stop pmdp_splitting_flush_notify on x86, for the same reason why x86 has to disable irq in gup-fast.
I surely can try to abstract it before there is a second arch involved, but it'd be more natural in the process of porting to an arch that wants rcu_read_lock instead of local_irq_disable.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 special pmd_trans_* functions
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
These returns 0 at compile time when the config option is disabled, to allow gcc to eliminate the transparent hugepage function calls at compile time without additional #ifdefs (only the export of those functions have to be visible to gcc but they won't be required at link time and huge_memory.o can be not built at all).
_PAGE_BIT_UNUSED1 is never used for pmd, only on pte.
---
arch/x86/include/asm/pgtable_64.h +13 -0
@@ -168,6 +168,19 @@ extern void cleanup_highmap(void);#define kc_offset_to_vaddr (o) ((o) | ~__VIRTUAL_MASK)#define __HAVE_ARCH_PTE_SAME + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline int pmd_trans_splitting (pmd_t pmd) +{ +return pmd_val (pmd) & _PAGE_SPLITTING; +} + +static inline int pmd_trans_huge (pmd_t pmd) +{ +return pmd_val (pmd) & _PAGE_PSE; +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif /* !__ASSEMBLY__ */ #endif /* _ASM_X86_PGTABLE_64_H */
arch/x86/include/asm/pgtable_types.h +2 -0
@@ -22,6 +22,7 @@#define _PAGE_BIT_PAT_LARGE 12/* On 2MB or 1GB pages */ #define _PAGE_BIT_SPECIAL _PAGE_BIT_UNUSED1#define _PAGE_BIT_CPA_TEST _PAGE_BIT_UNUSED1 +#define _PAGE_BIT_SPLITTING _PAGE_BIT_UNUSED1/* only valid on a PSE pmd */ #define _PAGE_BIT_NX 63/* No execute: only valid after cpuid check */ /* If _PAGE_BIT_PRESENT is clear, we use these: */
@@ -45,6 +46,7 @@#define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE)#define _PAGE_SPECIAL (_AT(pteval_t, 1) << _PAGE_BIT_SPECIAL)#define _PAGE_CPA_TEST (_AT(pteval_t, 1) << _PAGE_BIT_CPA_TEST) +#define _PAGE_SPLITTING (_AT(pteval_t, 1) << _PAGE_BIT_SPLITTING)#define __HAVE_ARCH_PTE_SPECIAL#ifdef CONFIG_KMEMCHECK
include/asm-generic/pgtable.h +5 -0
@@ -344,6 +344,11 @@ extern void untrack_pfn_vma(struct vm_ar unsigned long size);#endif +#ifndef CONFIG_TRANSPARENT_HUGEPAGE +#define pmd_trans_huge (pmd) 0 +#define pmd_trans_splitting (pmd) ({ BUG(); 0; }) +#endif +#endif /* !__ASSEMBLY__ */ #endif /* _ASM_GENERIC_PGTABLE_H */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 no paravirt version of pmd ops
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
No paravirt version of set_pmd_at/pmd_update/pmd_update_defer.
---
arch/x86/include/asm/pgtable.h +3 -0
@@ -33,6 +33,7 @@ extern struct list_head pgd_list;#else /* !CONFIG_PARAVIRT */ #define set_pte (ptep, pte) native_set_pte(ptep, pte)#define set_pte_at (mm, addr, ptep, pte) native_set_pte_at(mm, addr, ptep, pte) +#define set_pmd_at (mm, addr, pmdp, pmd) native_set_pmd_at(mm, addr, pmdp, pmd)#define set_pte_atomic (ptep, pte) \ native_set_pte_atomic(ptep, pte)
@@ -57,6 +58,8 @@ extern struct list_head pgd_list;#define pte_update (mm, addr, ptep) do { } while (0)#define pte_update_defer (mm, addr, ptep) do { } while (0) +#define pmd_update (mm, addr, ptep) do { } while (0) +#define pmd_update_defer (mm, addr, ptep) do { } while (0)#define pgd_val (x) native_pgd_val(x)#define __pgd (x) native_make_pgd(x)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 transparent hugepage core
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Lately I've been working to make KVM use hugepages transparently without the usual restrictions of hugetlbfs. Some of the restrictions I'd like to see removed:
1) hugepages have to be swappable or the guest physical memory remains locked in RAM and can't be paged out to swap
2) if a hugepage allocation fails, regular pages should be allocated instead and mixed in the same vma without any failure and without userland noticing
3) if some task quits and more hugepages become available in the buddy, guest physical memory backed by regular pages should be relocated on hugepages automatically in regions under madvise(MADV_HUGEPAGE) (ideally event driven by waking up the kernel deamon if the order=HPAGE_PMD_SHIFT-PAGE_SHIFT list becomes not null)
4) avoidance of reservation and maximization of use of hugepages whenever possible. Reservation (needed to avoid runtime fatal faliures) may be ok for 1 machine with 1 database with 1 database cache with 1 database cache size known at boot time. It's definitely not feasible with a virtualization hypervisor usage like RHEV-H that runs an unknown number of virtual machines with an unknown size of each virtual machine with an unknown amount of pagecache that could be potentially useful in the host for guest not using O_DIRECT (aka cache=off).
hugepages in the virtualization hypervisor (and also in the guest!) are much more important than in a regular host not using virtualization, becasue with NPT/EPT they decrease the tlb-miss cacheline accesses from 24 to 19 in case only the hypervisor uses transparent hugepages, and they decrease the tlb-miss cacheline accesses from 19 to 15 in case both the linux hypervisor and the linux guest both uses this patch (though the guest will limit the addition speedup to anonymous regions only for now...). Even more important is that the tlb miss handler is much slower on a NPT/EPT guest than for a regular shadow paging or no-virtualization scenario. So maximizing the amount of virtual memory cached by the TLB pays off significantly more with NPT/EPT than without (even if there would be no significant speedup in the tlb-miss runtime).
The first (and more tedious) part of this work requires allowing the VM to handle anonymous hugepages mixed with regular pages transparently on regular anonymous vmas. This is what this patch tries to achieve in the least intrusive possible way. We want hugepages and hugetlb to be used in a way so that all applications can benefit without changes (as usual we leverage the KVM virtualization design: by improving the Linux VM at large, KVM gets the performance boost too).
The most important design choice is: always fallback to 4k allocation if the hugepage allocation fails! This is the _very_ opposite of some large pagecache patches that failed with -EIO back then if a 64k (or similar) allocation failed...
Second important decision (to reduce the impact of the feature on the existing pagetable handling code) is that at any time we can split an hugepage into 512 regular pages and it has to be done with an operation that can't fail. This way the reliability of the swapping isn't decreased (no need to allocate memory when we are short on memory to swap) and it's trivial to plug a split_huge_page* one-liner where needed without polluting the VM. Over time we can teach mprotect, mremap and friends to handle pmd_trans_huge natively without calling split_huge_page*. The fact it can't fail isn't just for swap:
if split_huge_page would return -ENOMEM (instead of the current void) we'd need to rollback the mprotect from the middle of it (ideally including undoing the split_vma) which would be a big change and in the very wrong direction (it'd likely be simpler not to call split_huge_page at all and to teach mprotect and friends to handle hugepages instead of rolling them back from the middle). In short the very value of split_huge_page is that it can't fail.
The collapsing and madvise(MADV_HUGEPAGE) part will remain separated and incremental and it'll just be an "harmless" addition later if this initial part is agreed upon. It also should be noted that locking-wise replacing regular pages with hugepages is going to be very easy if compared to what I'm doing below in split_huge_page, as it will only happen when page_count(page) matches page_mapcount(page) if we can take the PG_lock and mmap_sem in write mode. collapse_huge_page will be a "best effort" that (unlike split_huge_page) can fail at the minimal sign of trouble and we can try again later. collapse_huge_page will be similar to how KSM works and the madvise(MADV_HUGEPAGE) will work similar to madvise(MADV_MERGEABLE).
The default I like is that transparent hugepages are used at page fault time. This can be changed with /sys/kernel/mm/transparent_hugepage/enabled. The control knob can be set to three values "always", "madvise", "never" which mean respectively that hugepages are always used, or only inside madvise(MADV_HUGEPAGE) regions, or never used. /sys/kernel/mm/transparent_hugepage/defrag instead controls if the hugepage allocation should defrag memory aggressively "always", only inside "madvise" regions, or "never".
The pmd_trans_splitting/pmd_trans_huge locking is very solid. The put_page (from get_user_page users that can't use mmu notifier like O_DIRECT) that runs against a __split_huge_page_refcount instead was a pain to serialize in a way that would result always in a coherent page count for both tail and head. I think my locking solution with a compound_lock taken only after the page_first is valid and is still a PageHead should be safe but it surely needs review from SMP race point of view. In short there is no current existing way to serialize the O_DIRECT final put_page against split_huge_page_refcount so I had to invent a new one (O_DIRECT loses knowledge on the mapping status by the time gup_fast returns so...). And I didn't want to impact all gup/gup_fast users for now, maybe if we change the gup interface substantially we can avoid this locking, I admit I didn't think too much about it because changing the gup unpinning interface would be invasive.
If we ignored O_DIRECT we could stick to the existing compound refcounting code, by simply adding a get_user_pages_fast_flags(foll_flags) where KVM (and any other mmu notifier user) would call it without FOLL_GET (and if FOLL_GET isn't set we'd just BUG_ON if nobody registered itself in the current task mmu notifier list yet). But O_DIRECT is fundamental for decent performance of virtualized I/O on fast storage so we can't avoid it to solve the race of put_page against split_huge_page_refcount to achieve a complete hugepage feature for KVM.
Swap and oom works fine (well just like with regular pages ;). MMU notifier is handled transparently too, with the exception of the young bit on the pmd, that didn't have a range check but I think KVM will be fine because the whole point of hugepages is that EPT/NPT will also use a huge pmd when they notice gup returns pages with PageCompound set, so they won't care of a range and there's just the pmd young bit to check in that case.
NOTE: in some cases if the L2 cache is small, this may slowdown and waste memory during COWs because 4M of memory are accessed in a single fault instead of 8k (the payoff is that after COW the program can run faster). So we might want to switch the copy_huge_page (and clear_huge_page too) to not temporal stores. I also extensively researched ways to avoid this cache trashing with a full prefault logic that would cow in 8k/16k/32k/64k up to 1M (I can send those patches that fully implemented prefault) but I concluded they're not worth it and they add an huge additional complexity and they remove all tlb benefits until the full hugepage has been faulted in, to save a little bit of memory and some cache during app startup, but they still don't improve substantially the cache-trashing during startup if the prefault happens in >4k chunks. One reason is that those 4k pte entries copied are still mapped on a perfectly cache-colored hugepage, so the trashing is the worst one can generate in those copies (cow of 4k page copies aren't so well colored so they trashes less, but again this results in software running faster after the page fault). Those prefault patches allowed things like a pte where post-cow pages were local 4k regular anon pages and the not-yet-cowed pte entries were pointing in the middle of some hugepage mapped read-only. If it doesn't payoff substantially with todays hardware it will payoff even less in the future with larger l2 caches, and the prefault logic would blot the VM a lot. If one is emebdded transparent_hugepage can be disabled during boot with sysfs or with the boot commandline parameter transparent_hugepage=0 (or transparent_hugepage=2 to restrict hugepages inside madvise regions) that will ensure not a single hugepage is allocated at boot time. It is simple enough to just disable transparent hugepage globally and let transparent hugepages be allocated selectively by applications in the MADV_HUGEPAGE region (both at page fault time, and if enabled with the collapse_huge_page too through the kernel daemon).
This patch supports only hugepages mapped in the pmd, archs that have smaller hugepages will not fit in this patch alone. Also some archs like power have certain tlb limits that prevents mixing different page size in the same regions so they will not fit in this framework that requires "graceful fallback" to basic PAGE_SIZE in case of physical memory fragmentation. hugetlbfs remains a perfect fit for those because its software limits happen to match the hardware limits. hugetlbfs also remains a perfect fit for hugepage sizes like 1GByte that cannot be hoped to be found not fragmented after a certain system uptime and that would be very expensive to defragment with relocation, so requiring reservation. hugetlbfs is the "reservation way", the point of transparent hugepages is not to have any reservation at all and maximizing the use of cache and hugepages at all times automatically.
Some performance result:
vmx andrea # LD_PRELOAD=/usr/lib64/libhugetlbfs.so HUGETLB_MORECORE=yes HUGETLB_PATH=/mnt/huge/ ./largep ages3
memset page fault 1566023
memset tlb miss 453854
memset second tlb miss 453321
random access tlb miss 41635
random access second tlb miss 41658
vmx andrea # LD_PRELOAD=/usr/lib64/libhugetlbfs.so HUGETLB_MORECORE=yes HUGETLB_PATH=/mnt/huge/ ./largepages3 memset page fault 1566471
memset tlb miss 453375
memset second tlb miss 453320
random access tlb miss 41636
random access second tlb miss 41637
vmx andrea # ./largepages3
memset page fault 1566642
memset tlb miss 453417
memset second tlb miss 453313
random access tlb miss 41630
random access second tlb miss 41647
vmx andrea # ./largepages3
memset page fault 1566872
memset tlb miss 453418
memset second tlb miss 453315
random access tlb miss 41618
random access second tlb miss 41659
vmx andrea # echo 0 > /proc/sys/vm/transparent_hugepage
vmx andrea # ./largepages3
memset page fault 2182476
memset tlb miss 460305
memset second tlb miss 460179
random access tlb miss 44483
random access second tlb miss 44186
vmx andrea # ./largepages3
memset page fault 2182791
memset tlb miss 460742
memset second tlb miss 459962
random access tlb miss 43981
random access second tlb miss 43988
============
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/time.h>
#define SIZE (3UL*1024*1024*1024)
int main()
{
char *p = malloc(SIZE), *p2;
struct timeval before, after;
gettimeofday(&before, NULL);
memset(p, 0, SIZE);
gettimeofday(&after, NULL);
printf("memset page fault %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
memset(p, 0, SIZE);
gettimeofday(&after, NULL);
printf("memset tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
memset(p, 0, SIZE);
gettimeofday(&after, NULL);
printf("memset second tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
for (p2 = p; p2 < p+SIZE; p2 += 4096)
*p2 = 0;
gettimeofday(&after, NULL);
printf("random access tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
for (p2 = p; p2 < p+SIZE; p2 += 4096)
*p2 = 0;
gettimeofday(&after, NULL);
printf("random access second tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
return 0;
}============
---
include/linux/huge_mm.h new file +138 -0
@@ -0,0 +1,138 @@ +#ifndef _LINUX_HUGE_MM_H +#define _LINUX_HUGE_MM_H + +extern int do_huge_pmd_anonymous_page (struct mm_struct *mm, +struct vm_area_struct *vma, +unsigned long address,pmd_t *pmd, +unsigned int flags); +extern int copy_huge_pmd (struct mm_struct *dst_mm,struct mm_struct *src_mm, +pmd_t *dst_pmd,pmd_t *src_pmd,unsigned long addr, +struct vm_area_struct *vma); +extern int do_huge_pmd_wp_page (struct mm_struct *mm,struct vm_area_struct *vma, +unsigned long address,pmd_t *pmd, +pmd_t orig_pmd); +extern pgtable_t get_pmd_huge_pte (struct mm_struct *mm); +extern struct page *follow_trans_huge_pmd (struct mm_struct *mm, +unsigned long addr, +pmd_t *pmd, +unsigned int flags); +extern int zap_huge_pmd (struct mmu_gather *tlb, +struct vm_area_struct *vma, +pmd_t *pmd); + +enum transparent_hugepage_flag { +TRANSPARENT_HUGEPAGE_FLAG , +TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG , +TRANSPARENT_HUGEPAGE_DEFRAG_FLAG , +TRANSPARENT_HUGEPAGE_DEFRAG_REQ_MADV_FLAG , +#ifdef CONFIG_DEBUG_VM +TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG , +#endif +}; + +enum page_check_address_pmd_flag { +PAGE_CHECK_ADDRESS_PMD_FLAG , +PAGE_CHECK_ADDRESS_PMD_NOTSPLITTING_FLAG , +PAGE_CHECK_ADDRESS_PMD_SPLITTING_FLAG , +}; +extern pmd_t *page_check_address_pmd (struct page *page, +struct mm_struct *mm, +unsigned long address, +enum page_check_address_pmd_flag flag); + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define HPAGE_PMD_SHIFT HPAGE_SHIFT +#define HPAGE_PMD_MASK HPAGE_MASK +#define HPAGE_PMD_SIZE HPAGE_SIZE + +#define transparent_hugepage_enabled (__vma) \ + (transparent_hugepage_flags & (1<<TRANSPARENT_HUGEPAGE_FLAG) || \ + (transparent_hugepage_flags & \ + (1<<TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG) && \ + (__vma)->vm_flags & VM_HUGEPAGE)) +#define transparent_hugepage_defrag (__vma) \ + (transparent_hugepage_flags & \ + (1<<TRANSPARENT_HUGEPAGE_DEFRAG_FLAG) || \ + (transparent_hugepage_flags & \ + (1<<TRANSPARENT_HUGEPAGE_DEFRAG_REQ_MADV_FLAG) && \ + (__vma)->vm_flags & VM_HUGEPAGE)) +#ifdef CONFIG_DEBUG_VM +#define transparent_hugepage_debug_cow () \ + (transparent_hugepage_flags & \ + (1<<TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG)) +#else /* CONFIG_DEBUG_VM */ +#define transparent_hugepage_debug_cow () 0 +#endif /* CONFIG_DEBUG_VM */ + +extern unsigned long transparent_hugepage_flags; +extern int copy_pte_range (struct mm_struct *dst_mm,struct mm_struct *src_mm, +pmd_t *dst_pmd,pmd_t *src_pmd, +struct vm_area_struct *vma, +unsigned long addr,unsigned long end); +extern int handle_pte_fault (struct mm_struct *mm, +struct vm_area_struct *vma,unsigned long address, +pte_t *pte,pmd_t *pmd,unsigned int flags); +extern void __split_huge_page_mm (struct mm_struct *mm,unsigned long address, +pmd_t *pmd); +extern void __split_huge_page_vma (struct vm_area_struct *vma,pmd_t *pmd); +extern int split_huge_page (struct page *page); +#define split_huge_page_mm (__mm, __addr, __pmd) \ + do { \ + pmd_t *____pmd = (__pmd); \ + if (unlikely(pmd_trans_huge(*____pmd))) \ + __split_huge_page_mm(__mm, __addr, ____pmd); \ + } while (0) +#define split_huge_page_vma (__vma, __pmd) \ + do { \ + pmd_t *____pmd = (__pmd); \ + if (unlikely(pmd_trans_huge(*____pmd))) \ + __split_huge_page_vma(__vma, ____pmd); \ + } while (0) +#define wait_split_huge_page (__anon_vma, __pmd) \ + do { \ + pmd_t *____pmd = (__pmd); \ + spin_unlock_wait(&(__anon_vma)->lock); \ +/* \ +* spin_unlock_wait() is just a loop in C and so the \ +* CPU can reorder anything around it. \ +*/ \ +smp_mb (); \ +BUG_ON (pmd_trans_splitting (*____pmd) || \ +pmd_trans_huge (*____pmd)); \ + } while (0) +#define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) +#define HPAGE_PMD_NR (1<<HPAGE_PMD_ORDER) +#if HPAGE_PMD_ORDER >MAX_ORDER +#error "hugepages can't be allocated by the buddy allocator" +#endif + +extern unsigned long vma_address (struct page *page,struct vm_area_struct *vma); +static inline int PageTransHuge (struct page *page) +{ +VM_BUG_ON (PageTail (page)); +return PageHead (page); +} +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define HPAGE_PMD_SHIFT ({ BUG(); 0; }) +#define HPAGE_PMD_MASK ({ BUG(); 0; }) +#define HPAGE_PMD_SIZE ({ BUG(); 0; }) + +#define transparent_hugepage_enabled (__vma) 0 +#define transparent_hugepage_defrag (__vma) 0 +#define transparent_hugepage_debug_cow () 0 + +#define transparent_hugepage_flags 0UL +static inline int split_huge_page (struct page *page) +{ +return 0 ; +} +#define split_huge_page_mm (__mm, __addr, __pmd) \ + do { } while (0) +#define split_huge_page_vma (__vma, __pmd) \ + do { } while (0) +#define wait_split_huge_page (__anon_vma, __pmd) \ + do { } while (0) +#define PageTransHuge (page) 0 +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ + +#endif /* _LINUX_HUGE_MM_H */
include/linux/mm.h +4 -0
@@ -106,6 +106,9 @@ extern unsigned int kobjsize(const void#define VM_SAO 0x20000000/* Strong Access Ordering (powerpc) */ #define VM_PFN_AT_MMAP 0x40000000/* PFNMAP vma that is fully mapped at mmap time */ #define VM_MERGEABLE 0x80000000/* KSM may merge identical pages */ +#if BITS_PER_LONG >32 +#define VM_HUGEPAGE 0x100000000UL/* MADV_HUGEPAGE marked this vma */ +#endif #ifndef VM_STACK_DEFAULT_FLAGS /* arch can override this */ #define VM_STACK_DEFAULT_FLAGS VM_DATA_DEFAULT_FLAGS
@@ -234,6 +237,7 @@ struct inode;* files which need it (119 of them) */ #include <linux/page-flags.h> +#include <linux/huge_mm.h> /* * Methods to modify the page usage count.
include/linux/mm_inline.h +10 -3
@@ -20,11 +20,18 @@ static inline int page_is_file_cache(str }static inline void +__add_page_to_lru_list (struct zone *zone,struct page *page,enum lru_list l, +struct list_head *head) +{ +list_add (&page->lru, head); +__inc_zone_state (zone,NR_LRU_BASE + l); +mem_cgroup_add_lru_list (page, l); +} + +static inline void add_page_to_lru_list (struct zone *zone,struct page *page,enum lru_list l) { -list_add (&page->lru, &zone->lru[l].list); -__inc_zone_state (zone,NR_LRU_BASE + l); -mem_cgroup_add_lru_list (page, l); +__add_page_to_lru_list (zone, page, l, &zone->lru[l].list); } static inline void
include/linux/swap.h +2 -0
@@ -205,6 +205,8 @@ extern unsigned int nr_free_pagecache_pa/* linux/mm/swap.c */ extern void __lru_cache_add (struct page *,enum lru_list lru);extern void lru_cache_add_lru (struct page *,enum lru_list lru); +extern void lru_add_page_tail (struct zone * zone, +struct page *page,struct page *page_tail);extern void activate_page (struct page *);extern void mark_page_accessed (struct page *);extern void lru_add_drain (void );
mm/Makefile +1 -0
@@ -40,3 +40,4 @@ obj-$(CONFIG_MEMORY_FAILURE) += memory-f obj-$(CONFIG_HWPOISON_INJECT) += hwpoison-inject.o obj-$(CONFIG_DEBUG_KMEMLEAK) += kmemleak.o obj-$(CONFIG_DEBUG_KMEMLEAK_TEST) += kmemleak-test.o +obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o
mm/huge_memory.c new file +839 -0
839 lines not on this page · raw message
mm/memory.c +58 -7
105 lines not on this page · raw message
mm/rmap.c +36 -23
93 lines not on this page · raw message
mm/swap.c +37 -0
@@ -461,6 +461,43 @@ void __pagevec_release(struct pagevec *pEXPORT_SYMBOL (__pagevec_release); +/* used by __split_huge_page_refcount() */ +void lru_add_page_tail (struct zone * zone, +struct page *page,struct page *page_tail) +{ +int active; +enum lru_list lru; +const int file =0 ; +struct list_head *head; + +VM_BUG_ON (!PageHead (page)); +VM_BUG_ON (PageCompound (page_tail)); +VM_BUG_ON (PageLRU (page_tail)); +VM_BUG_ON (!spin_is_locked (&zone->lru_lock)); + +SetPageLRU (page_tail); + +if (page_evictable (page_tail,NULL )) { +if (PageActive (page)) { +SetPageActive (page_tail); + active =1 ; + lru =LRU_ACTIVE_ANON ; + }else { + active =0 ; + lru =LRU_INACTIVE_ANON ; + } +update_page_reclaim_stat (zone, page_tail, file, active); +if (likely (PageLRU (page))) + head = page->lru.prev; +else + head = &zone->lru[lru].list; +__add_page_to_lru_list (zone, page_tail, lru, head); + }else { +SetPageUnevictable (page_tail); +add_page_to_lru_list (zone, page_tail,LRU_UNEVICTABLE ); + } +} +/* * Add the passed pages to the LRU, then drop the caller's refcount * on them. Reinitialises the caller's pagevec.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 add pmd paravirt ops
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Paravirt ops pmd_update/pmd_update_defer/pmd_set_at. Not all might be necessary (vmware needs pmd_update, Xen needs set_pmd_at, nobody needs pmd_update_defer), but this is to keep full simmetry with pte paravirt ops, which looks cleaner and simpler from a common code POV.
---
arch/x86/include/asm/paravirt.h +23 -0
@@ -449,6 +449,11 @@ static inline void pte_update(struct mm_ {PVOP_VCALL3 (pv_mmu_ops.pte_update, mm, addr, ptep); } +static inline void pmd_update (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp) +{ +PVOP_VCALL3 (pv_mmu_ops.pmd_update, mm, addr, pmdp); +}static inline void pte_update_defer (struct mm_struct *mm,unsigned long addr,pte_t *ptep)
@@ -456,6 +461,12 @@ static inline void pte_update_defer(struPVOP_VCALL3 (pv_mmu_ops.pte_update_defer, mm, addr, ptep); } +static inline void pmd_update_defer (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp) +{ +PVOP_VCALL3 (pv_mmu_ops.pmd_update_defer, mm, addr, pmdp); +} +static inline pte_t __pte (pteval_t val) {pteval_t ret;
@@ -557,6 +568,18 @@ static inline void set_pte_at(struct mm_PVOP_VCALL4 (pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte); } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void set_pmd_at (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp,pmd_t pmd) +{ +if (sizeof (pmdval_t) >sizeof (long )) +/* 5 arg words */ + pv_mmu_ops.set_pmd_at (mm, addr, pmdp, pmd); +else +PVOP_VCALL4 (pv_mmu_ops.set_pmd_at, mm, addr, pmdp, pmd.pmd); +} +#endif +static inline void set_pmd (pmd_t *pmdp,pmd_t pmd) {pmdval_t val =native_pmd_val (pmd);
arch/x86/include/asm/paravirt_types.h +6 -0
@@ -266,10 +266,16 @@ struct pv_mmu_ops {void (*set_pte_at)(struct mm_struct *mm,unsigned long addr,pte_t *ptep,pte_t pteval);void (*set_pmd)(pmd_t *pmdp,pmd_t pmdval); +void (*set_pmd_at)(struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp,pmd_t pmdval);void (*pte_update)(struct mm_struct *mm,unsigned long addr,pte_t *ptep);void (*pte_update_defer)(struct mm_struct *mm,unsigned long addr,pte_t *ptep); +void (*pmd_update)(struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp); +void (*pmd_update_defer)(struct mm_struct *mm, +unsigned long addr,pmd_t *pmdp);pte_t (*ptep_modify_prot_start)(struct mm_struct *mm,unsigned long addr,pte_t *ptep);
arch/x86/kernel/paravirt.c +3 -0
@@ -422,8 +422,11 @@ struct pv_mmu_ops pv_mmu_ops = { .set_pte = native_set_pte, .set_pte_at = native_set_pte_at, .set_pmd = native_set_pmd, + .set_pmd_at = native_set_pmd_at, .pte_update = paravirt_nop, .pte_update_defer = paravirt_nop, + .pmd_update = paravirt_nop, + .pmd_update_defer = paravirt_nop, .ptep_modify_prot_start = __ptep_modify_prot_start, .ptep_modify_prot_commit = __ptep_modify_prot_commit,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 kvm mmu transparent hugepage support
In reply to Andrea ArcangeliFrom: Marcelo Tosatti <[email protected]>
This should work for both hugetlbfs and transparent hugepages.
---
arch/x86/kvm/mmu.c +9 -0
@@ -489,6 +489,15 @@ static int host_mapping_level(struct kvm out:up_read (¤t->mm->mmap_sem); +/* check for transparent hugepages */ +if (page_size ==PAGE_SIZE ) { +struct page *page =gfn_to_page (kvm, gfn); + +if (!is_error_page (page) &&PageHead (page)) + page_size =KVM_HPAGE_SIZE (2 ); +kvm_release_page_clean (page); + } +for (i =PT_PAGE_TABLE_LEVEL ; i < (PT_PAGE_TABLE_LEVEL +KVM_NR_PAGE_SIZES ); ++i) {if (page_size >=KVM_HPAGE_SIZE (i))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 add pmd mangling generic functions
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Some are needed to build but not actually used on archs not supporting transparent hugepages. Others like pmdp_clear_flush are used by x86 too.
---
include/asm-generic/pgtable.h +125 -0
@@ -25,6 +25,26 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_SET_ACCESS_FLAGS +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_set_access_flags (__vma, __address, __pmdp, __entry, __dirty) \ + ({ \ + int __changed = !pmd_same(*(__pmdp), __entry); \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + if (__changed) { \ + set_pmd_at((__vma)->vm_mm, __address, __pmdp, \ + __entry); \ + flush_tlb_range(__vma, __address, \ + (__address) + HPAGE_PMD_SIZE); \ + } \ + __changed; \ + }) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_set_access_flags (__vma, __address, __pmdp, __entry, __dirty) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG#define ptep_test_and_clear_young (__vma, __address, __ptep) \ ({ \
@@ -39,6 +59,25 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_TEST_AND_CLEAR_YOUNG +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_test_and_clear_young (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd = *(__pmdp); \ + int r = 1; \ + if (!pmd_young(__pmd)) \ + r = 0; \ + else \ + set_pmd_at((__vma)->vm_mm, (__address), \ + (__pmdp), pmd_mkold(__pmd)); \ + r; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_test_and_clear_young (__vma, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH#define ptep_clear_flush_young (__vma, __address, __ptep) \ ({ \
@@ -50,6 +89,24 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_CLEAR_YOUNG_FLUSH +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_clear_flush_young (__vma, __address, __pmdp) \ +({ \ + int __young; \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + __young = pmdp_test_and_clear_young(__vma, __address, __pmdp); \ + if (__young) \ + flush_tlb_range(__vma, __address, \ + (__address) + HPAGE_PMD_SIZE); \ + __young; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_clear_flush_young (__vma, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR#define ptep_get_and_clear (__mm, __address, __ptep) \ ({ \
@@ -59,6 +116,20 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_GET_AND_CLEAR +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_get_and_clear (__mm, __address, __pmdp) \ +({ \ + pmd_t __pmd = *(__pmdp); \ + pmd_clear((__mm), (__address), (__pmdp)); \ + __pmd; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_get_and_clear (__mm, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR_FULL#define ptep_get_and_clear_full (__mm, __address, __ptep, __full) \ ({ \
@@ -90,6 +161,22 @@ do { \ })#endif +#ifndef __HAVE_ARCH_PMDP_CLEAR_FLUSH +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_clear_flush (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd; \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + __pmd = pmdp_get_and_clear((__vma)->vm_mm, __address, __pmdp); \ + flush_tlb_range(__vma, __address, (__address) + HPAGE_PMD_SIZE);\ + __pmd; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_clear_flush (__vma, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_SET_WRPROTECTstruct mm_struct ;static inline void ptep_set_wrprotect (struct mm_struct *mm,unsigned long address,pte_t *ptep)
@@ -99,10 +186,45 @@ static inline void ptep_set_wrprotect(st }#endif +#ifndef __HAVE_ARCH_PMDP_SET_WRPROTECT +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void pmdp_set_wrprotect (struct mm_struct *mm,unsigned long address,pmd_t *pmdp) +{ +pmd_t old_pmd = *pmdp; +set_pmd_at (mm, address, pmdp,pmd_wrprotect (old_pmd)); +} +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_set_wrprotect (mm, address, pmdp) BUG() +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif + +#ifndef __HAVE_ARCH_PMDP_SPLITTING_FLUSH +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_splitting_flush (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd = pmd_mksplitting(*(__pmdp)); \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + set_pmd_at((__vma)->vm_mm, __address, __pmdp, __pmd); \ +/* tlb flush only to serialize against gup-fast */ \ +flush_tlb_range (__vma, __address, (__address) +HPAGE_PMD_SIZE );\ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_splitting_flush (__vma, __address, __pmdp) BUG() +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTE_SAME#define pte_same (A ,B ) (pte_val(A) == pte_val(B))#endif +#ifndef __HAVE_ARCH_PMD_SAME +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmd_same (A ,B ) (pmd_val(A) == pmd_val(B)) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmd_same (A ,B ) ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PAGE_TEST_DIRTY#define page_test_dirty (page) (0)#endif
@@ -347,6 +469,9 @@ extern void untrack_pfn_vma(struct vm_ar#ifndef CONFIG_TRANSPARENT_HUGEPAGE #define pmd_trans_huge (pmd) 0#define pmd_trans_splitting (pmd) ({ BUG(); 0; }) +#ifndef __HAVE_ARCH_PMD_WRITE +#define pmd_write (pmd) ({ BUG(); 0; }) +#endif /* __HAVE_ARCH_PMD_WRITE */ #endif #endif /* !__ASSEMBLY__ */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 pte alloc trans splitting
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
pte alloc routines must wait for split_huge_page if the pmd is not present and not null (i.e. pmd_trans_splitting). The additional branches are optimized away at compile time by pmd_trans_splitting if the config option is off. However we must pass the vma down in order to know the anon_vma lock to wait for.
---
include/linux/mm.h +8 -5
@@ -955,7 +955,8 @@ static inline int __pmd_alloc(struct mm_int __pmd_alloc (struct mm_struct *mm,pud_t *pud,unsigned long address);#endif -int __pte_alloc (struct mm_struct *mm,pmd_t *pmd,unsigned long address); +int __pte_alloc (struct mm_struct *mm,struct vm_area_struct *vma, +pmd_t *pmd,unsigned long address);int __pte_alloc_kernel (pmd_t *pmd,unsigned long address);/*
@@ -1024,12 +1025,14 @@ static inline void pgtable_page_dtor(strpte_unmap (pte); \ } while (0) -#define pte_alloc_map (mm, pmd, address) \ - ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \ - NULL: pte_offset_map(pmd, address)) +#define pte_alloc_map (mm, vma, pmd, address) \ + ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, vma, \ + pmd, address))? \ + NULL: pte_offset_map(pmd, address))#define pte_alloc_map_lock (mm, pmd, address, ptlp) \ - ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \ + ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, NULL, \ + pmd, address))? \ NULL: pte_offset_map_lock(mm, pmd, address, ptlp))#define pte_alloc_kernel (pmd, address) \
mm/memory.c +13 -6
@@ -324,9 +324,11 @@ void free_pgtables(struct mmu_gather *tl } } -int __pte_alloc (struct mm_struct *mm,pmd_t *pmd,unsigned long address) +int __pte_alloc (struct mm_struct *mm,struct vm_area_struct *vma, +pmd_t *pmd,unsigned long address) {pgtable_t new =pte_alloc_one (mm, address); +int wait_split_huge_page;if (!new)return -ENOMEM ;
@@ -346,14 +348,18 @@ int __pte_alloc(struct mm_struct *mm, pmsmp_wmb ();/* Could be smp_wmb__xxx(before|after)_spin_lock */ spin_lock (&mm->page_table_lock); -if (!pmd_present (*pmd)) {/* Has another populated it ? */ + wait_split_huge_page =0 ; +if (likely (pmd_none (*pmd))) {/* Has another populated it ? */ mm->nr_ptes++;pmd_populate (mm, pmd, new); new =NULL ; - } + }else if (unlikely (pmd_trans_splitting (*pmd))) + wait_split_huge_page =1 ;spin_unlock (&mm->page_table_lock);if (new)pte_free (mm, new); +if (wait_split_huge_page) +wait_split_huge_page (vma->anon_vma, pmd);return 0 ; }
@@ -366,10 +372,11 @@ int __pte_alloc_kernel(pmd_t *pmd, unsigsmp_wmb ();/* See comment in __pte_alloc */ spin_lock (&init_mm.page_table_lock); -if (!pmd_present (*pmd)) {/* Has another populated it ? */ +if (likely (pmd_none (*pmd))) {/* Has another populated it ? */ pmd_populate_kernel (&init_mm, pmd, new); new =NULL ; - } + }else +VM_BUG_ON (pmd_trans_splitting (*pmd));spin_unlock (&init_mm.page_table_lock);if (new)pte_free_kernel (&init_mm, new);
@@ -3020,7 +3027,7 @@ int handle_mm_fault(struct mm_struct *mm pmd =pmd_alloc (mm, pud, address);if (!pmd)return VM_FAULT_OOM ; - pte =pte_alloc_map (mm, pmd, address); + pte =pte_alloc_map (mm, vma, pmd, address);if (!pte)return VM_FAULT_OOM ;
mm/mremap.c +4 -3
@@ -48,7 +48,8 @@ static pmd_t *get_old_pmd(struct mm_strureturn pmd; } -static pmd_t *alloc_new_pmd (struct mm_struct *mm,unsigned long addr) +static pmd_t *alloc_new_pmd (struct mm_struct *mm,struct vm_area_struct *vma, +unsigned long addr) {pgd_t *pgd;pud_t *pud;
@@ -63,7 +64,7 @@ static pmd_t *alloc_new_pmd(struct mm_stif (!pmd)return NULL ; -if (!pmd_present (*pmd) &&__pte_alloc (mm, pmd, addr)) +if (!pmd_present (*pmd) &&__pte_alloc (mm, vma, pmd, addr))return NULL ;return pmd;
@@ -148,7 +149,7 @@ unsigned long move_page_tables(struct vm old_pmd =get_old_pmd (vma->vm_mm, old_addr);if (!old_pmd)continue ; - new_pmd =alloc_new_pmd (vma->vm_mm, new_addr); + new_pmd =alloc_new_pmd (vma->vm_mm, vma, new_addr);if (!new_pmd)break ; next = (new_addr +PMD_SIZE ) &PMD_MASK ;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 add pmd_huge_pte to mm_struct
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
This increase the size of the mm struct a bit but it is needed to preallocate one pte for each hugepage so that split_huge_page will not require a fail path. Guarantee of success is a fundamental property of split_huge_page to avoid decrasing swapping reliability and to avoid adding -ENOMEM fail paths that would otherwise force the hugepage-unaware VM code to learn rolling back in the middle of its pte mangling operations (if something we need it to learn handling pmd_trans_huge natively rather being capable of rollback). When split_huge_page runs a pte is needed to succeed the split, to map the newly splitted regular pages with a regular pte. This way all existing VM code remains backwards compatible by just adding a split_huge_page* one liner. The memory waste of those preallocated ptes is negligible and so it is worth it.
---
include/linux/mm_types.h +3 -0
@@ -291,6 +291,9 @@ struct mm_struct {#ifdef CONFIG_MMU_NOTIFIER struct mmu_notifier_mm *mmu_notifier_mm;#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +pgtable_t pmd_huge_pte;/* protected by page_table_lock */ +#endif };/* Future-safe accessor for struct mm_struct's cpu_vm_mask. */
kernel/fork.c +7 -0
@@ -498,6 +498,9 @@ void __mmdrop(struct mm_struct *mm)mm_free_pgd (mm);destroy_context (mm);mmu_notifier_mm_destroy (mm); +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +VM_BUG_ON (mm->pmd_huge_pte); +#endif free_mm (mm); }EXPORT_SYMBOL_GPL (__mmdrop);
@@ -638,6 +641,10 @@ struct mm_struct *dup_mm(struct task_str mm->token_priority =0 ; mm->last_interval =0 ; +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + mm->pmd_huge_pte =NULL ; +#endif +if (!mm_init (mm, tsk)) goto fail_nomem;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 clear page compound
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
split_huge_page must transform a compound page to a regular page and needs ClearPageCompound.
---
include/linux/page-flags.h +16 -1
@@ -349,7 +349,7 @@ static inline void set_page_writeback(st* tests can be used in performance sensitive paths. PageCompound is * generally not used in hot code paths. */ -__PAGEFLAG(Head, head) +__PAGEFLAG(Head, head) CLEARPAGEFLAG(Head, head) __PAGEFLAG(Tail, tail)static inline int PageCompound (struct page *page)
@@ -357,6 +357,13 @@ static inline int PageCompound(struct pa return page->flags & ((1L << PG_head) | (1L << PG_tail)); } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void ClearPageCompound (struct page *page) +{ +BUG_ON (!PageHead (page)); +ClearPageHead (page); +} +#endif #else /* * Reduce page flag use as much as possible by overlapping
@@ -394,6 +401,14 @@ static inline void __ClearPageTail(struc page->flags &= ~PG_head_tail_mask; } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void ClearPageCompound (struct page *page) +{ +BUG_ON (page->flags & PG_head_tail_mask != (1 << PG_compound)); +ClearPageCompound (page); +} +#endif +#endif /* !PAGEFLAGS_EXTENDED */ #ifdef CONFIG_MMU
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 19 of 32] clear page compound
Quoted 2 lines · Andrea Arcangeli
split_huge_pagemust transform a compound page to a regular page and needs ClearPageCompound.
This should not be as me agreeing with the approach just that the patch is correct.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 compound_lock
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add a new compound_lock() needed to serialize put_page against __split_huge_page_refcount().
---
include/linux/mm.h +15 -0
@@ -12,6 +12,7 @@#include <linux/prio_tree.h> #include <linux/debug_locks.h> #include <linux/mm_types.h> +#include <linux/bit_spinlock.h> struct mempolicy ;struct anon_vma ;
@@ -294,6 +295,20 @@ static inline int is_vmalloc_or_module_a }#endif +static inline void compound_lock (struct page *page) +{ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +bit_spin_lock (PG_compound_lock, &page->flags); +#endif +} + +static inline void compound_unlock (struct page *page) +{ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +bit_spin_unlock (PG_compound_lock, &page->flags); +#endif +} +static inline struct page *compound_head (struct page *page) {if (unlikely (PageTail (page)))
include/linux/page-flags.h +11 -1
@@ -108,6 +108,9 @@ enum pageflags {#ifdef CONFIG_MEMORY_FAILURE PG_hwpoison, /* hardware poisoned page. Don't touch */#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + PG_compound_lock, +#endif __NR_PAGEFLAGS,/* Filesystems */
@@ -399,6 +402,12 @@ static inline void __ClearPageTail(struc#define __PG_MLOCKED 0#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define __PG_COMPOUND_LOCK (1 << PG_compound_lock) +#else +#define __PG_COMPOUND_LOCK 0 +#endif +/* * Flags checked when a page is freed. Pages being freed should not have * these flags set. It they are, there is a problem.
@@ -408,7 +417,8 @@ static inline void __ClearPageTail(struc1 << PG_private |1 << PG_private_2 | \1 << PG_buddy |1 << PG_writeback |1 << PG_reserved | \1 << PG_slab |1 << PG_swapcache |1 << PG_active | \ - 1 << PG_unevictable | __PG_MLOCKED | __PG_HWPOISON) +1 << PG_unevictable | __PG_MLOCKED | __PG_HWPOISON | \ + __PG_COMPOUND_LOCK)/* * Flags checked when a page is prepped for return by the page allocator.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 config_transparent_hugepage
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add config option.
---
mm/Kconfig +14 -0
@@ -283,3 +283,17 @@ config NOMMU_INITIAL_TRIM_EXCESS of 1 says that all excess pages should be trimmed. See Documentation/nommu-mmap.txt for more information. + +config TRANSPARENT_HUGEPAGE + bool "Transparent Hugepage support" if EMBEDDED + depends on X86_64 + default y + help + Transparent Hugepages allows the kernel to use huge pages and + huge tlb transparently to the applications whenever possible. + This feature can improve computing performance to certain + applications by speeding up page faults during memory + allocation, by reducing the number of tlb misses and by speeding + up the pagetable walking. + + If memory constrained on embedded, you may want to say N.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 fix bad_page to show the real reason the page is bad
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
page_count shows the count of the head page, but the actual check is done on the tail page, so show what is really being checked.
---
mm/page_alloc.c +1 -1
@@ -265,7 +265,7 @@ static void bad_page(struct page *page) current->comm, page_to_pfn(page));printk (KERN_ALERT "page:%p flags:%p count:%d mapcount:%d mapping:%p index:%lx\n" , - page, (void *)page->flags,page_count (page), + page, (void *)page->flags,atomic_read (&page->_count),page_mapcount (page), page->mapping, page->index);dump_stack ();
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 comment reminder in destroy_compound_page
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Warn destroy_compound_page that __split_huge_page_refcount is heavily dependent on its internal behavior.
---
mm/page_alloc.c +1 -0
@@ -311,6 +311,7 @@ void prep_compound_page(struct page *pag } } +/* update __split_huge_page_refcount if you change this function */ static int destroy_compound_page (struct page *page,unsigned long order) {int i;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 export maybe_mkwrite
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
huge_memory.c needs it too when it fallbacks in copying hugepages into regular fragmented pages if hugepage allocation fails during COW.
---
include/linux/mm.h +13 -0
@@ -387,6 +387,19 @@ static inline void set_compound_order(st }/* +* Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when +* servicing faults for write access. In the normal case, do always want +* pte_mkwrite. But get_user_pages can cause write faults for mappings +* that do not have writing enabled, when used by access_process_vm. +*/ +static inline pte_t maybe_mkwrite (pte_t pte,struct vm_area_struct *vma) +{ +if (likely (vma->vm_flags &VM_WRITE )) + pte =pte_mkwrite (pte); +return pte; +} + +/* * Multiple processes may "see" the same page. E.g. for untouched * mappings of /dev/null, all processes see the same page full of * zeroes, and text pages of executables and shared libraries have
mm/memory.c +0 -13
@@ -1943,19 +1943,6 @@ static inline int pte_unmap_same(structreturn same; } -/* -* Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when -* servicing faults for write access. In the normal case, do always want -* pte_mkwrite. But get_user_pages can cause write faults for mappings -* that do not have writing enabled, when used by access_process_vm. -*/ -static inline pte_t maybe_mkwrite (pte_t pte,struct vm_area_struct *vma) -{ -if (likely (vma->vm_flags &VM_WRITE )) - pte =pte_mkwrite (pte); -return pte; -} -static inline void cow_user_page (struct page *dst,struct page *src,unsigned long va,struct vm_area_struct *vma) {/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 clear compound mapping
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Clear compound mapping for anonymous compound pages like it already happens for regular anonymous pages.
---
mm/page_alloc.c +2 -0
@@ -585,6 +585,8 @@ static void __free_pages_ok(struct pagekmemcheck_free_shadow (page, order); +if (PageAnon (page)) + page->mapping =NULL ;for (i =0 ; i < (1 << order) ; ++i) bad +=free_pages_check (page + i);if (bad)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 add pmd mangling functions to x86
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add needed pmd mangling functions with simmetry with their pte counterparts. pmdp_freeze_flush is the only exception only present on the pmd side and it's needed to serialize the VM against split_huge_page, it simply atomically clears the present bit in the same way pmdp_clear_flush_young atomically clears the accessed bit (and both need to flush the tlb to make it effective, which is mandatory to happen synchronously for pmdp_freeze_flush).
---
arch/x86/include/asm/pgtable.h +4 -4
@@ -300,15 +300,15 @@ pmd_t *populate_extra_pmd(unsigned longpte_t *populate_extra_pte (unsigned long vaddr);#endif /* __ASSEMBLY__ */ +#ifndef __ASSEMBLY__ +#include <linux/mm_types.h> +#ifdef CONFIG_X86_32 # include "pgtable_32.h" #else # include "pgtable_64.h" #endif -#ifndef __ASSEMBLY__ -#include <linux/mm_types.h> -static inline int pte_none (pte_t pte) {return !pte.pte;
@@ -351,7 +351,7 @@ static inline unsigned long pmd_page_vad* Currently stuck as a macro due to indirect forward reference to * linux/mmzone.h's __section_mem_map_addr() definition: */ -#define pmd_page (pmd) pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT) +#define pmd_page (pmd) pfn_to_page((pmd_val(pmd) & PTE_PFN_MASK) >> PAGE_SHIFT)/* * the pmd page can be thought of an array like this: pmd_t[PTRS_PER_PMD]
arch/x86/include/asm/pgtable_64.h +105 -0
117 lines not on this page · raw message
arch/x86/mm/pgtable.c +66 -0
84 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 khugepaged
In reply to Andrea ArcangeliFrom: Andrea Arcangeli <[email protected]>
Add khugepaged to relocate fragmented pages into hugepages if new hugepages become available. (this is indipendent of the defrag logic that will have to make new hugepages available)
---
include/linux/huge_mm.h +6 -2
@@ -25,6 +25,8 @@ enum transparent_hugepage_flag {TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG ,TRANSPARENT_HUGEPAGE_DEFRAG_FLAG ,TRANSPARENT_HUGEPAGE_DEFRAG_REQ_MADV_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG , #ifdef CONFIG_DEBUG_VM TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG, #endif
@@ -50,12 +52,14 @@ extern pmd_t *page_check_address_pmd(str (transparent_hugepage_flags & \ (1<<TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG) && \ (__vma)->vm_flags & VM_HUGEPAGE)) -#define transparent_hugepage_defrag (__vma) \ +#define __transparent_hugepage_defrag (__in_madv) \ (transparent_hugepage_flags & \ (1<<TRANSPARENT_HUGEPAGE_DEFRAG_FLAG) || \ (transparent_hugepage_flags & \ (1<<TRANSPARENT_HUGEPAGE_DEFRAG_REQ_MADV_FLAG) && \ - (__vma)->vm_flags & VM_HUGEPAGE)) + (__in_madv))) +#define transparent_hugepage_defrag (__vma) \ + __transparent_hugepage_defrag((__vma)->vm_flags & VM_HUGEPAGE)#ifdef CONFIG_DEBUG_VM #define transparent_hugepage_debug_cow () \ (transparent_hugepage_flags & \
include/linux/khugepaged.h new file +32 -0
@@ -0,0 +1,32 @@ +#ifndef _LINUX_KHUGEPAGED_H +#define _LINUX_KHUGEPAGED_H + +#include <linux/sched.h> /* MMF_VM_HUGEPAGE */ + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +extern int __khugepaged_enter (struct mm_struct *mm); +extern void __khugepaged_exit (struct mm_struct *mm); + +static inline int khugepaged_fork (struct mm_struct *mm,struct mm_struct *oldmm) +{ +if (test_bit (MMF_VM_HUGEPAGE , &oldmm->flags)) +return __khugepaged_enter (mm); +return 0 ; +} + +static inline void khugepaged_exit (struct mm_struct *mm) +{ +if (test_bit (MMF_VM_HUGEPAGE , &mm->flags)) +__khugepaged_exit (mm); +} +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +static inline int khugepaged_fork (struct mm_struct *mm,struct mm_struct *oldmm) +{ +return 0 ; +} +static inline void khugepaged_exit (struct mm_struct *mm) +{ +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ + +#endif /* _LINUX_KHUGEPAGED_H */
include/linux/sched.h +1 -0
@@ -482,6 +482,7 @@ extern int get_dumpable(struct mm_struct#endif /* leave room for more dump flags */ #define MMF_VM_MERGEABLE 16/* KSM may merge identical pages */ +#define MMF_VM_HUGEPAGE 17/* set when VM_HUGEPAGE is set on vma */ #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK)
kernel/fork.c +5 -0
@@ -65,6 +65,7 @@#include <linux/perf_event.h> #include <linux/posix-timers.h> #include <linux/user-return-notifier.h> +#include <linux/khugepaged.h> #include <asm/pgtable.h> #include <asm/pgalloc.h>
@@ -306,6 +307,9 @@ static int dup_mmap(struct mm_struct *mm retval =ksm_fork (mm, oldmm);if (retval) goto out; + retval =khugepaged_fork (mm, oldmm); +if (retval) + goto out;for (mpnt = oldmm->mmap; mpnt; mpnt = mpnt->vm_next) {struct file *file;
@@ -515,6 +519,7 @@ void mmput(struct mm_struct *mm)if (atomic_dec_and_test (&mm->mm_users)) {exit_aio (mm);ksm_exit (mm); +khugepaged_exit (mm);/* must run before exit_mmap */ exit_mmap (mm);set_mm_exe_file (mm,NULL );if (!list_empty (&mm->mmlist)) {
mm/huge_memory.c +963 -9
1,014 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1469
Quoted 2 lines · Andrea Arcangeli
mm/huge_memory.c +2
-0+/* stop anon_vma rmap pagetable access */ +spin_lock (&vma->anon_vma->lock);
This is no longer enough. The anon_vma changes that went into -mm recently mean that a VMA can be associated with multiple anon_vmas.
Of course, forcefully COW copying/writing every page in the VMA will ensure that they are all in the anon_vma you lock with the code above.
I suspect the easiest fix would be to lock all the anon_vmas attached to a VMA. That should not lead to any deadlocks, since multiple siblings of the same parent process would be encountering their anon_vma structs in the same order, due to the way that anon_vma_clone and anon_vma_fork work.
This may be too subtle for lockdep, though :/
Signature · 7 lines
All rights reversed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
Quoted 13 lines · Rik van Riel
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1469
Quoted 2 lines · Andrea Arcangeli
mm/huge_memory.c +2
-0+/* stop anon_vma rmap pagetable access */ +spin_lock (&vma->anon_vma->lock);This is no longer enough. The
anon_vmachanges that went into -mm recently mean that a VMA can be associated with multipleanon_vmas.Of course, forcefully COW copying/writing every page in the VMA will ensure that they are all in the
anon_vmayou lock with the code above.
Quoted 8 lines
I suspect the easiest fix would be to lock all the
anon_vmasattached to a VMA. That should not lead to any deadlocks, since multiple siblings of the same parent process would be encountering theiranon_vmastructs in the same order, due to the way thatanon_vma_cloneandanon_vma_forkwork.This may be too subtle for lockdep, though :/
I hope I can do this in split_huge_page_mm/vma:
if (pmd_trans_huge(*pmd)) {
spin_lock(&mm->page_table_lock); /* stop pmd updates */
if (pmd_trans_huge(*pmd)) {
unsigned long anon_mapping;
struct page *page;
struct anon_vma *anon_vma;
page = pmd_page(*pmd); /* works even while pmd_splitting is set */
anon_mapping = page->mapping; /* ACCESS_ONCE not needed page has to go away before anon_vma */
VM_BUG_ON((anon_mapping & PAGE_MAPPING_FLAGS) != PAGE_MAPPING_ANON);
VM_BUG_ON(!page_mapped(page));
anon_vma = (struct anon_vma *)((unsigned long)page->mapping - PAGE_MAPPING_ANON);
rcu_read_lock();
spin_unlock(&mm->page_table_lock);
spin_lock(&anon_vma->lock);
rcu_read_unlock();If this only causes at most 1 more memory allocation for each new vma created in the child, at the very first cow on the newly allocated vma in the child (and no more memory allocation) it should be unmeasurable overhead so it should be worth it and main downside seems to be in making the tricky vma adjusting more complex.
I think the most urgent info that is missing is if this enough to fix the regressions in AIM that grinds to an halt now and prevents to get results. That is what started the development of this patch (for the other pages not cowed there is nothing we can do about it and current anon-vma is already as efficient as it can be in complexity terms). Optimizing for one-process-per-connection not so important, even if I know proprietary db do that. I've no idea how many pages there are in AIM that are cowed and how many that are totally shared and purely readonly for all processes in the system, and for the latter this is a noop... If it won't be proven that this fixes AIM we'll have to still to bisect previous patches.
So in short I recommend to test this patch on Larry's system but again I think this change is good idea regardless (just I'm not convinced it'll be enough to prevent aim to grind to an halt, if you call page_referenced or try_to_unmap in a loop it won't be showing less in the profiling just because it returns faster, still a loop that will be and I suspect more the caller not the callee given the callee was fine in previous kernels... but I didn't have time to look into it so I may as well be wrong and maybe some legitimate change happened that requires a more frequent page_referenced calls, dunno).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
In reply to Andrea ArcangeliQuoted 21 lines · Andrea Arcangeli
mm/huge_memory.c +21
-0+static int __collapse_huge_page_isolate (struct vm_area_struct *vma, +unsigned long address, +pte_t *pte) +{ +struct page *page; +pte_t *_pte; +int referenced =0 , isolated =0 ; +for (_pte = pte; _pte < pte+HPAGE_PMD_NR ; + _pte++, address +=PAGE_SIZE ) { +pte_t pteval = *_pte; +if (!pte_present (pteval) || !pte_write (pteval)) { +release_pte_pages (pte, _pte); + goto out; + } +/* If there is no mapped pte young don't collapse the page */ +if (pte_young (pteval)) + referenced =1 ; + page =vm_normal_page (vma, address, pteval); +if (unlikely (!page)) { +release_pte_pages (pte, _pte); + goto out;
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1356
Quoted 10 lines
mm/huge_memory.c +10
-0+ } +VM_BUG_ON (PageCompound (page)); +BUG_ON (!PageAnon (page)); +VM_BUG_ON (!PageSwapBacked (page)); + +/* cannot use mapcount: can't collapse if there's a gup pin */ +if (page_count (page) !=1 ) { +release_pte_pages (pte, _pte); + goto out; + }
Ok you hold mmap_sem locked the pte_lock and we know that there is/was only one refcount. However, this does not mean that nothing can reach the page. The hardware tlb lookup / tlb walker can still reach the page and potentially modify bits. follow_page() can still reach the page. LRU is also possible?
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1366
Quoted 10 lines
mm/huge_memory.c +10
-0+/* +* We can do it before isolate_lru_page because the +* page can't be freed from under us. NOTE: PG_lock +* seems entirely unnecessary but in doubt this is +* safer. If proven unnecessary it can be removed. +*/ +if (!trylock_page (page)) { +release_pte_pages (pte, _pte); + goto out; + }
Who could be locking the page if the only ref is the page table and we hold the pte lock?
Is this for the case that someone does a follow_page() and lock?
If so: One can also do a follow_page() and take a refcount.
The page migration code puts migration ptes in there to stop access to the page.
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1375
Quoted 9 lines
mm/huge_memory.c +9
-0+/* +* Isolate the page to avoid collapsing an hugepage +* currently in use by the VM. +*/ +if (isolate_lru_page (page)) { +unlock_page (page); +release_pte_pages (pte, _pte); + goto out; + }
The page can also be reached via the LRU until here? Reclaim code?
Note the requirement in the comments for isolate_lru_page() for an elevated refcount.
Seems to rely on the teardown of a pte before release of a page in reclaim.
Would it not be better and safer to use and extend the existing page migration code for this purpose?
You are performing almost the same activities.
1. Isolation
2. Copying
3. Reestablish reachability.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
Quoted 31 lines · Christoph Lameter
Quoted 29 lines · Andrea Arcangeli
mm/huge_memory.c +29
-0+static int __collapse_huge_page_isolate (struct vm_area_struct *vma, +unsigned long address, +pte_t *pte) +{ +struct page *page; +pte_t *_pte; +int referenced =0 , isolated =0 ; +for (_pte = pte; _pte < pte+HPAGE_PMD_NR ; + _pte++, address +=PAGE_SIZE ) { +pte_t pteval = *_pte; +if (!pte_present (pteval) || !pte_write (pteval)) { +release_pte_pages (pte, _pte); + goto out; + } +/* If there is no mapped pte young don't collapse the page */ +if (pte_young (pteval)) + referenced =1 ; + page =vm_normal_page (vma, address, pteval); +if (unlikely (!page)) { +release_pte_pages (pte, _pte); + goto out; + } +VM_BUG_ON (PageCompound (page)); +BUG_ON (!PageAnon (page)); +VM_BUG_ON (!PageSwapBacked (page)); + +/* cannot use mapcount: can't collapse if there's a gup pin */ +if (page_count (page) !=1 ) { +release_pte_pages (pte, _pte);
Quoted 8 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ goto out; + }Ok you hold
mmap_semlocked thepte_lockand we know that there is/was only one refcount. However, this does not mean that nothing can reach the page. The hardware tlb lookup / tlb walker can still reach the page and potentially modify bits.follow_page()can still reach the page. LRU is also possible?
Check this:
spin_lock(&mm->page_table_lock); /* probably unnecessary */ /* after this gup_fast can't run anymore */ _pmd = pmdp_clear_flush_notify(vma, address, pmd); spin_unlock(&mm->page_table_lock);
This already stopped gup_fast and tlb/mmu before the above code could run. Otherwise the page_count check is meaningless if gup_fast can run.
Quoted 5 lines
Quoted 5 lines
mm/huge_memory.c +5
-0+/* +* We can do it before isolate_lru_page because the +* page can't be freed from under us. NOTE: PG_lock +* seems entirely unnecessary but in doubt this is +* safer. If proven unnecessary it can be removed.
Quoted 8 lines
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1366
Quoted 5 lines
mm/huge_memory.c +5
-0+*/ +if (!trylock_page (page)) { +release_pte_pages (pte, _pte); + goto out; + }Who could be locking the page if the only ref is the page table and we hold the pte lock?
split_huge_page through rmap. Maybe the comment should be removed as it's misleading and probably not accurate. I'll remove the "if proven unnecessary" because comment is misleading.
Quoted 1 line
Is this for the case that someone does a
follow_page()and lock?
follow_page can't run, it's only to serialize against split_huge_page running through rmap code, and the VM takes the lock on the page before it can split_huge_page.
Quoted 2 lines
The page migration code puts migration ptes in there to stop access to the page.
No need of that when pmdp_clear_flush_notify is enough and it has to invoke mmu notifier to be safe so sptes are dropped too.
Quoted 11 lines
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1375
Quoted 9 lines
mm/huge_memory.c +9
-0+/* +* Isolate the page to avoid collapsing an hugepage +* currently in use by the VM. +*/ +if (isolate_lru_page (page)) { +unlock_page (page); +release_pte_pages (pte, _pte); + goto out; + }The page can also be reached via the LRU until here? Reclaim code?
Yes. If it's already taken by it, we just abort and try later.
Quoted 2 lines
Note the requirement in the comments for
isolate_lru_page()for an elevated refcount.
The refcount is elevated by the fact the pte mapping can't go away from under us (we only invalidated the pmd the pte still there).
Quoted 2 lines
Seems to rely on the teardown of a pte before release of a page in reclaim.
Not sure I get this, we simply take the lock on the page to serialize against split_huge_page, if we arrived first we try to isolate the page by relaying on the refcount of the page_mapcount == 1, and if we again arrived first again we collapsed the pages.
Quoted 10 lines
Would it not be better and safer to use and extend the existing page migration code for this purpose?
You are performing almost the same activities.
1. Isolation
2. Copying
3. Reestablish reachability.
KSM also works exactly the same as khugepaged and migration but we solved it without migration pte and apparently nobody wants to deal with that special migration pte logic. So before worrying about khugepaged out of the tree, you should actively go fix ksm that works exactly the same and it's in mainline. Until you don't fix ksm I think I should be allowed to keep khugepaged simple and lightweight without being forced to migration pte.
Thanks for the review!
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
Quoted 7 lines · Andrea Arcangeli
KSM also works exactly the same as khugepaged and migration but we solved it without migration pte and apparently nobody wants to deal with that special migration pte logic. So before worrying about khugepaged out of the tree, you should actively go fix ksm that works exactly the same and it's in mainline. Until you don't fix ksm I think I should be allowed to keep khugepaged simple and lightweight without being forced to migration pte.
You are being "forced"? What language... You do not want to reuse the ksm code or the page migration code?
Please consider consolidating the code for the multiple ways that we do these complex moves of physical memory without changing the physical one.
The code needs to be understandable and easy to maintain after all.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
Quoted 11 lines · Christoph Lameter
Quoted 7 lines · Andrea Arcangeli
KSM also works exactly the same as khugepaged and migration but we solved it without migration pte and apparently nobody wants to deal with that special migration pte logic. So before worrying about khugepaged out of the tree, you should actively go fix ksm that works exactly the same and it's in mainline. Until you don't fix ksm I think I should be allowed to keep khugepaged simple and lightweight without being forced to migration pte.
You are being "forced"? What language... You do not want to reuse the ksm
How would you say it? I think if ksm was forced to the migration pte like it was discussed when ksm was first submitted, I would definitely be forced to use it here too in order to get it merged. Do you disagree?
Quoted 1 line
code or the page migration code?
I prefer not to reuse the migration pte. I prefer to stick to the ksm method. My rationale is pretty simple, migration pte requires an additional logic in the pagefault code, while this doesn't and so it has less dependencies and it looks simpler and more self contained to me and it is enough for khugepaged as it is enough for ksm.
Quoted 4 lines
Please consider consolidating the code for the multiple ways that we do these complex moves of physical memory without changing the physical one.
The code needs to be understandable and easy to maintain after all.
Again, I recommend to consolidate the code between ksm.c and migrate.c yourself in mainline upsteam, then I'll be sure to share it in khugepaged. I think it'll make it worse and more complicated and this is all different enough that there's not enough to share, but then if you find a way and your patch has more - lines than + lines, I'll be happy to remove lines from huge_memory.c. I just don't have an obvious point where to start removing code from the two files given the enough difference in the logic and how the comparison (in ksm case) and copies from regular to hugepage (in khugepaged case) are nested post pte freezing (ksm) or pmd_huge freezing (khugepaged). I think what you're asking is over-engineering but again I welcome you to do it yourself and prove you actually save lines, I don't see it myself. I think if it was it so obvious as you pretend it to be, Hugh would have cleaned it up considering it was an issue mentioned already.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
Quoted 3 lines · Andrea Arcangeli
How would you say it? I think if ksm was forced to the migration pte like it was discussed when ksm was first submitted, I would definitely be forced to use it here too in order to get it merged. Do you disagree?
How about at least consolidating the code with ksm pieces?
Quoted 5 lines
I prefer not to reuse the migration pte. I prefer to stick to the ksm method. My rationale is pretty simple, migration pte requires an additional logic in the pagefault code, while this doesn't and so it has less dependencies and it looks simpler and more self contained to me and it is enough for khugepaged as it is enough for ksm.
The logic is already there ready for use.
Quoted 5 lines
pte freezing (ksm) or
pmd_hugefreezing (khugepaged). I think what you're asking is over-engineering but again I welcome you to do it yourself and prove you actually save lines, I don't see it myself. I think if it was it so obvious as you pretend it to be, Hugh would have cleaned it up considering it was an issue mentioned already.
I am asking for simplification and that you do the cleanup work that comes with introcing new functionality in the kernel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [PATCH 32 of 32] khugepaged
Quoted 7 lines · Christoph Lameter
Quoted 3 lines · Andrea Arcangeli
How would you say it? I think if ksm was forced to the migration pte like it was discussed when ksm was first submitted, I would definitely be forced to use it here too in order to get it merged. Do you disagree?
How about at least consolidating the code with ksm pieces?
It's much easier and realistic to consolidate ksm with migrate (which isn't even done yet) than to consolidate any of the two with khugepaged (both things you're asked and magically you don't care about consolidation of ksm and migrate despite it's stuff already in mainline).
ksm at least runs ptep_clear_flush_notify and works with ptes, so it is more similar to what migrate does. khugepaged to be a lot faster and execute a single IPI instead a flood of 512 per pmd, uses pmdp_clear_flush_notify... it never calls ptep_clear_flush_notify and ksm will never be able to call pmdp_clear_flush_notify (well of course until we add transhuge support to ksm too, at which point not even ksm will merge with migration code).
So unless you create a migration pmd in addition to the migration pte I'd be shooting khugepaged with 511 unnecessary IPIs by consolidating it at this point. Or at the very least first you have to make migrate capable of migrating natively transhuge pages with a migration pmd.
But again at this point all you can hope to consolidate is ksm with migrate, khugepaged is the most different in having the serialiation point in the pmd and not in the pte.
Quoted 2 lines
I am asking for simplification and that you do the cleanup work that comes with introcing new functionality in the kernel.
If I thought it was possible or more robust to consolidate I think I wouldn't be opposing it, I just don't think this is cleanup work but gratuitous complexity added to ksm and khugepaged. And unless I add even more functionality (migration pmd and native handling of hugepage migration in pmd instead of a 3 liner) there's no way to merge khugepaged with migrate, so I think if one wants to start removing lines of code, it should start with ksm/migrate consolidation, that at least won't require adding more functionality (i.e. more lines and more complexity) not just to migrate but all over the page faults that could run on a not present (migrate) pmd.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>